From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A790A04DD for ; Fri, 30 Oct 2020 08:10:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14B9B72D9; Fri, 30 Oct 2020 08:10:55 +0100 (CET) Received: from relay.smtp-ext.broadcom.com (saphodev.broadcom.com [192.19.232.172]) by dpdk.org (Postfix) with ESMTP id EE8325B38; Fri, 30 Oct 2020 08:10:48 +0100 (CET) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 1AE9380CF; Fri, 30 Oct 2020 00:10:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 1AE9380CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1604041847; bh=FKzrLPiO+lC9rYMK9jUuFIykID4/GWSlJC8Sm6/G9Ro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wN6J0xp9vGPB2W9IJUWH4UisvY2ULbj8fpvIwJ8O+eWiBSu9joIKl5p1GkwUt7uWw RB9PffHrf8O10OwWUGOvhDqhft3BHulUkHVL/asdERtrW/J5nHiQ1KlR4hmyYrq0rg rCJ7RAfD+GKu5IaLQd4onwSlG+S/os/IH+fRH0xM= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Somnath Kotur , stable@dpdk.org, Kalesh Anakkur Purayil Date: Fri, 30 Oct 2020 12:33:04 +0530 Message-Id: <20201030070304.22318-2-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.28.0.450.g3a238e5 In-Reply-To: <20201030070304.22318-1-somnath.kotur@broadcom.com> References: <20201030070304.22318-1-somnath.kotur@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH 2/2] net/bnxt: pass dev args by reference X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Pass 'eth_da' pointer instead of pass by value to bnxt_rep_port_probe() Coverity issue: 360841 Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Cc: stable@dpdk.org Signed-off-by: Somnath Kotur Reviewed-by: Kalesh Anakkur Purayil --- drivers/net/bnxt/bnxt_ethdev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 31e94f2..6a77e57 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -6288,7 +6288,7 @@ static int bnxt_init_rep_info(struct bnxt *bp) } static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, - struct rte_eth_devargs eth_da, + struct rte_eth_devargs *eth_da, struct rte_eth_dev *backing_eth_dev, const char *dev_args) { @@ -6299,7 +6299,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, int i, ret = 0; struct rte_kvargs *kvlist = NULL; - num_rep = eth_da.nb_representor_ports; + num_rep = eth_da->nb_representor_ports; if (num_rep > BNXT_MAX_VF_REPS) { PMD_DRV_LOG(ERR, "nb_representor_ports = %d > %d MAX VF REPS\n", num_rep, BNXT_MAX_VF_REPS); @@ -6329,7 +6329,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, for (i = 0; i < num_rep; i++) { struct bnxt_representor representor = { - .vf_id = eth_da.representor_ports[i], + .vf_id = eth_da->representor_ports[i], .switch_domain_id = backing_bp->switch_domain_id, .parent_dev = backing_eth_dev }; @@ -6342,7 +6342,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, /* representor port net_bdf_port */ snprintf(name, sizeof(name), "net_%s_representor_%d", - pci_dev->device.name, eth_da.representor_ports[i]); + pci_dev->device.name, eth_da->representor_ports[i]); kvlist = rte_kvargs_parse(dev_args, bnxt_dev_args); if (kvlist) { @@ -6505,7 +6505,7 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, return ret; /* probe representor ports now */ - ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev, + ret = bnxt_rep_port_probe(pci_dev, ð_da, backing_eth_dev, pci_dev->device.devargs->args); return ret; -- 2.7.4