From: Dharmik Thakkar <dharmik.thakkar@arm.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Gavin Hu <gavin.hu@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Cc: dev@dpdk.org, nd@arm.com,
Dharmik Thakkar <dharmik.thakkar@arm.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v5 2/4] test/lpm: return error on failure in rcu qsbr perf
Date: Wed, 4 Nov 2020 12:58:56 -0600 [thread overview]
Message-ID: <20201104185858.18397-3-dharmik.thakkar@arm.com> (raw)
In-Reply-To: <20201104185858.18397-1-dharmik.thakkar@arm.com>
Return error if Add/Delete fail in multiwriter perf test
Return error if single or multi writer test fails
Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: honnappa.nagarahalli@arm.com
Cc: stable@dpdk.org
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
app/test/test_lpm_perf.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c
index 45164b23214b..873ecf511c97 100644
--- a/app/test/test_lpm_perf.c
+++ b/app/test/test_lpm_perf.c
@@ -453,6 +453,7 @@ test_lpm_rcu_qsbr_writer(void *arg)
next_hop_add) != 0) {
printf("Failed to add iteration %d, route# %d\n",
i, j);
+ goto error;
}
pthread_mutex_unlock(&lpm_mutex);
}
@@ -464,6 +465,7 @@ test_lpm_rcu_qsbr_writer(void *arg)
large_ldepth_route_table[j].depth) != 0) {
printf("Failed to delete iteration %d, route# %d\n",
i, j);
+ goto error;
}
pthread_mutex_unlock(&lpm_mutex);
}
@@ -474,6 +476,10 @@ test_lpm_rcu_qsbr_writer(void *arg)
__atomic_fetch_add(&gwrite_cycles, total_cycles, __ATOMIC_RELAXED);
return 0;
+
+error:
+ pthread_mutex_unlock(&lpm_mutex);
+ return -1;
}
/*
@@ -947,9 +953,11 @@ test_lpm_perf(void)
rte_lpm_delete_all(lpm);
rte_lpm_free(lpm);
- test_lpm_rcu_perf();
+ if (test_lpm_rcu_perf() < 0)
+ return -1;
- test_lpm_rcu_perf_multi_writer();
+ if (test_lpm_rcu_perf_multi_writer() < 0)
+ return -1;
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2020-11-04 18:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 15:36 [dpdk-stable] [PATCH 1/4] test/lpm: fix cycle calculation " Dharmik Thakkar
2020-10-29 15:36 ` [dpdk-stable] [PATCH 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-10-29 15:36 ` [dpdk-stable] [PATCH 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-02 10:08 ` [dpdk-stable] [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation " David Marchand
2020-11-02 15:11 ` [dpdk-stable] " Bruce Richardson
2020-11-02 16:58 ` Dharmik Thakkar
2020-11-02 17:21 ` Medvedkin, Vladimir
2020-11-02 17:33 ` Bruce Richardson
[not found] ` <20201102235203.6342-1-dharmik.thakkar@arm.com>
2020-11-02 23:52 ` [dpdk-stable] [PATCH v2 " Dharmik Thakkar
2020-11-03 1:30 ` Honnappa Nagarahalli
2020-11-02 23:52 ` [dpdk-stable] [PATCH v2 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 1:28 ` Honnappa Nagarahalli
2020-11-03 4:42 ` Dharmik Thakkar
2020-11-02 23:52 ` [dpdk-stable] [PATCH v2 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-03 1:21 ` Honnappa Nagarahalli
2020-11-03 4:56 ` Dharmik Thakkar
[not found] ` <20201103051224.12620-1-dharmik.thakkar@arm.com>
2020-11-03 5:12 ` [dpdk-stable] [PATCH v3 1/4] test/lpm: fix cycle calculation " Dharmik Thakkar
2020-11-03 5:12 ` [dpdk-stable] [PATCH v3 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 5:21 ` Honnappa Nagarahalli
2020-11-03 5:12 ` [dpdk-stable] [PATCH v3 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-03 5:22 ` Honnappa Nagarahalli
[not found] ` <20201103222352.11566-1-dharmik.thakkar@arm.com>
2020-11-03 22:23 ` [dpdk-stable] [PATCH v4 1/4] test/lpm: fix cycle calculation " Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-stable] [PATCH v4 2/4] test/lpm: return error on failure " Dharmik Thakkar
2020-11-03 22:23 ` [dpdk-stable] [PATCH v4 3/4] test/lpm: remove error checking " Dharmik Thakkar
[not found] ` <20201104185858.18397-1-dharmik.thakkar@arm.com>
2020-11-04 18:58 ` [dpdk-stable] [PATCH v5 1/4] test/lpm: fix cycle calculation " Dharmik Thakkar
2020-11-04 19:34 ` Medvedkin, Vladimir
2020-11-04 18:58 ` Dharmik Thakkar [this message]
2020-11-04 19:35 ` [dpdk-stable] [PATCH v5 2/4] test/lpm: return error on failure " Medvedkin, Vladimir
2020-11-04 18:58 ` [dpdk-stable] [PATCH v5 3/4] test/lpm: remove error checking " Dharmik Thakkar
2020-11-04 19:35 ` Medvedkin, Vladimir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104185858.18397-3-dharmik.thakkar@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).