From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 007B3A04B1 for ; Thu, 5 Nov 2020 13:41:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4108C7F6; Thu, 5 Nov 2020 13:41:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id DD76EC31B for ; Thu, 5 Nov 2020 13:41:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1aggzHxP5mE350XOOeoIe3wQNdFHLxNpM7PUpE00o6E=; b=OgDDMTamNY05TNWThHQKXAkHMTrAQyE/EvI3yCuUCRfZDqxr3/WyE8JrmsfiPYimI0+EOK ZYtHE5ab2SAzsFJYU3Egi1ZM6kBTmjarbrMA95vogWCjPWgCyNI6YTDU+0CvtwpRBBcQBm fPCkcfJueFFFv/rsWTFZc5GMddqQVw8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-bjyR8hKyOiGYqI4lP0-tcw-1; Thu, 05 Nov 2020 07:41:31 -0500 X-MC-Unique: bjyR8hKyOiGYqI4lP0-tcw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F33F805F06; Thu, 5 Nov 2020 12:41:30 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72DEA5C3E1; Thu, 5 Nov 2020 12:41:29 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Ferruh Yigit , dpdk stable Date: Thu, 5 Nov 2020 12:39:42 +0000 Message-Id: <20201105124015.306404-35-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'net/qede: fix dereference before null check' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/6d382f6a1c2a2d5209a4427e20c5d65432e7714b Thanks. Kevin. --- >From 6d382f6a1c2a2d5209a4427e20c5d65432e7714b Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 24 Aug 2020 19:46:53 +0800 Subject: [PATCH] net/qede: fix dereference before null check [ upstream commit b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 ] Coverity flags that 'fp->sb_info' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 260413 Fixes: 4c4bdadfa9e7 ("net/qede: refactoring multi-queue implementation") Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit --- drivers/net/qede/qede_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 0ccfea4912..f62b2ef583 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -677,7 +677,7 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev) for (sb_idx = 0; sb_idx < QEDE_RXTX_MAX(qdev); sb_idx++) { fp = &qdev->fp_array[sb_idx]; - DP_INFO(edev, "Free sb_info index 0x%x\n", - fp->sb_info->igu_sb_id); if (fp->sb_info) { + DP_INFO(edev, "Free sb_info index 0x%x\n", + fp->sb_info->igu_sb_id); OSAL_DMA_FREE_COHERENT(edev, fp->sb_info->sb_virt, fp->sb_info->sb_phys, -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:54.936688940 +0000 +++ 0035-net-qede-fix-dereference-before-null-check.patch 2020-11-05 12:38:54.237896017 +0000 @@ -1 +1 @@ -From b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 Mon Sep 17 00:00:00 2001 +From 6d382f6a1c2a2d5209a4427e20c5d65432e7714b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b5c2f5a0ba7b2f7c21be167d5ea418c46552a299 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index ea264f59d7..75d78cebb5 100644 +index 0ccfea4912..f62b2ef583 100644