From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5376BA04B1 for ; Thu, 5 Nov 2020 13:42:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B65CC7E8; Thu, 5 Nov 2020 13:42:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 3083BC802 for ; Thu, 5 Nov 2020 13:42:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4zxRkBKzOQY55KLq4ZUbXisjc2dI5QEPVk3+7Zcc5o=; b=J+GN+XL3pJli/LF7Oo2xBJEE8VAo6qRR6G3wnj5LhQDqMuIwYnyMLz5O3CIBj7WPnqV8Te GH5LxT7FyBV031Yu+h7gNOHw/1vKQ+8mGOdTG8yW4C/48F5JfH4JAjGe8ZfqGBIQAhOM48 1Fu8hV+H+aEhEO9AANbA1FhFdL0HNUI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-1u0jiCv7PSa888jL-ErarQ-1; Thu, 05 Nov 2020 07:42:05 -0500 X-MC-Unique: 1u0jiCv7PSa888jL-ErarQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2866C1007463; Thu, 5 Nov 2020 12:42:04 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 012C85C5DE; Thu, 5 Nov 2020 12:42:02 +0000 (UTC) From: Kevin Traynor To: Rasesh Mody Cc: Ferruh Yigit , Igor Russkikh , dpdk stable Date: Thu, 5 Nov 2020 12:39:59 +0000 Message-Id: <20201105124015.306404-52-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'net/qede: fix getting link details' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/b4fa19fc18cd83aad28df7bb973c28a4918ee694 Thanks. Kevin. --- >From b4fa19fc18cd83aad28df7bb973c28a4918ee694 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Fri, 2 Oct 2020 12:59:45 -0700 Subject: [PATCH] net/qede: fix getting link details [ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ] This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index 0ac4300465..c124b2532b 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -576,11 +576,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) if (IS_PF(edev)) { ptt = ecore_ptt_acquire(hwfn); - if (!ptt) - DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n"); - + if (ptt) { qed_fill_link(hwfn, ptt, if_link); - - if (ptt) ecore_ptt_release(hwfn, ptt); + } else { + DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n"); + } } else { qed_fill_link(hwfn, NULL, if_link); -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:55.230290183 +0000 +++ 0052-net-qede-fix-getting-link-details.patch 2020-11-05 12:38:54.251896028 +0000 @@ -1 +1 @@ -From effb1d0b9527815a7cd5422bce5defbc0884cea0 Mon Sep 17 00:00:00 2001 +From b4fa19fc18cd83aad28df7bb973c28a4918ee694 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 0d3cea6e42..caa9d1d4f6 100644 +index 0ac4300465..c124b2532b 100644 @@ -23 +24 @@ -@@ -588,11 +588,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link) +@@ -576,11 +576,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)