From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B38A0A04B1 for ; Thu, 5 Nov 2020 13:42:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A03D72EE; Thu, 5 Nov 2020 13:42:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 023D6C802 for ; Thu, 5 Nov 2020 13:42:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wF27XjHPI5NX+2celbowFZcc0oSV+Kw5SSHPFEbKwUk=; b=iToKuhlhqrTllyCuZZfQ8OVcSzZNamS6Uh1mgmAWXTfxyjkmrBY1WvQ7a8sY5GcZqGztdw rXOJDB7tpy2XdeMf6tjD656X4NejabUrgdRXzsjctl2D64PNWefjehob5zjvUwBSLR+E6Z ETQ2+qX1emGIh9ebPoyZhk2GUNeUxlI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-8kkkn5QTP8yPI-N4BxWBRQ-1; Thu, 05 Nov 2020 07:42:28 -0500 X-MC-Unique: 8kkkn5QTP8yPI-N4BxWBRQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 638DA1868403; Thu, 5 Nov 2020 12:42:27 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43E065C3E1; Thu, 5 Nov 2020 12:42:25 +0000 (UTC) From: Kevin Traynor To: Ruifeng Wang Cc: Adam Dybkowski , dpdk stable Date: Thu, 5 Nov 2020 12:40:11 +0000 Message-Id: <20201105124015.306404-64-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'test/crypto: fix stats test' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/52d2001b4edc3c92018349718f961a0c6168bcb4 Thanks. Kevin. --- >From 52d2001b4edc3c92018349718f961a0c6168bcb4 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Mon, 31 Aug 2020 16:51:43 +0800 Subject: [PATCH] test/crypto: fix stats test [ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ] ut_setup / ut_teardown are invoked for each test case by test framework. The call inside test_stats is unnecessary and even incorrect. This caused double free of objects such as crypto operation structure. Trapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled. Fix issue by removing ut_setup / ut_teardown from test case implementation. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Signed-off-by: Ruifeng Wang Tested-by: Adam Dybkowski --- test/test/test_cryptodev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index 210507eb8a..021fc099b3 100644 --- a/test/test/test_cryptodev.c +++ b/test/test/test_cryptodev.c @@ -6509,7 +6509,5 @@ test_stats(void) /* Test expected values */ - ut_setup(); test_AES_CBC_HMAC_SHA1_encrypt_digest(); - ut_teardown(); TEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats), -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:55.737527335 +0000 +++ 0064-test-crypto-fix-stats-test.patch 2020-11-05 12:38:54.275896047 +0000 @@ -1 +1 @@ -From b450503612eebc59de96aa3f20ec5ea0e3ceb400 Mon Sep 17 00:00:00 2001 +From 52d2001b4edc3c92018349718f961a0c6168bcb4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - app/test/test_cryptodev.c | 2 -- + test/test/test_cryptodev.c | 2 -- @@ -21,5 +22,5 @@ -diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c -index 704aa7c414..d702cb91a3 100644 ---- a/app/test/test_cryptodev.c -+++ b/app/test/test_cryptodev.c -@@ -9327,7 +9327,5 @@ test_stats(void) +diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c +index 210507eb8a..021fc099b3 100644 +--- a/test/test/test_cryptodev.c ++++ b/test/test/test_cryptodev.c +@@ -6509,7 +6509,5 @@ test_stats(void)