From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB704A04B1 for ; Thu, 5 Nov 2020 13:42:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AB95C802; Thu, 5 Nov 2020 13:42:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 0E608C81A for ; Thu, 5 Nov 2020 13:42:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604580152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QpMlfV35D08BFY4la5vKfYxr8n4L1BEedcdYekdnUus=; b=V4BXAq+DOZsFkdcHldYiBnLrRvkNc9LwckGEX7VYHuSYGnnfqNEHMSWWy6+RK9n/VbjgvV wT/EQBx7aCsFDr4m+pGLZVPKRU3egoIfmDPzcXHV5YWdjuQVgbVhqGP3VorcuH8mKDezud LopzXz2l6FXd5TfwVFTV0/kNTEMs00U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-208-82SNQr1kPp61AfmC3dKVqA-1; Thu, 05 Nov 2020 07:42:30 -0500 X-MC-Unique: 82SNQr1kPp61AfmC3dKVqA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EC19E1074643; Thu, 5 Nov 2020 12:42:28 +0000 (UTC) Received: from rh.redhat.com (ovpn-113-249.ams2.redhat.com [10.36.113.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 012AB5C3E1; Thu, 5 Nov 2020 12:42:27 +0000 (UTC) From: Kevin Traynor To: Haggai Eran Cc: Akhil Goyal , dpdk stable Date: Thu, 5 Nov 2020 12:40:12 +0000 Message-Id: <20201105124015.306404-65-ktraynor@redhat.com> In-Reply-To: <20201105124015.306404-1-ktraynor@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'cryptodev: fix parameter parsing' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/e9e725d903f2ac1759223d472849a44765d0f0ca Thanks. Kevin. --- >From e9e725d903f2ac1759223d472849a44765d0f0ca Mon Sep 17 00:00:00 2001 From: Haggai Eran Date: Thu, 8 Oct 2020 22:42:14 +0300 Subject: [PATCH] cryptodev: fix parameter parsing [ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ] The rte_cryptodev_pmd_parse_input_args function crashes with a segmentation fault when passing a non-empty argument string. The function passes cryptodev_pmd_valid_params to rte_kvargs_parse, which accepts a NULL-terminated list of valid keys, yet cryptodev_pmd_valid_params does not end with NULL. The patch adds the missing NULL pointer. Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation") Signed-off-by: Haggai Eran Acked-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h index 5297912265..0fa11582d8 100644 --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h @@ -42,5 +42,6 @@ static const char * const cryptodev_pmd_valid_params[] = { RTE_CRYPTODEV_PMD_NAME_ARG, RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG, - RTE_CRYPTODEV_PMD_SOCKET_ID_ARG + RTE_CRYPTODEV_PMD_SOCKET_ID_ARG, + NULL }; -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-05 12:38:55.774862437 +0000 +++ 0065-cryptodev-fix-parameter-parsing.patch 2020-11-05 12:38:54.275896047 +0000 @@ -1 +1 @@ -From 784fb396f72d98070f3afaf309a7addb4c0d8da1 Mon Sep 17 00:00:00 2001 +From e9e725d903f2ac1759223d472849a44765d0f0ca Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 784fb396f72d98070f3afaf309a7addb4c0d8da1 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 81975d72b4..1367222f73 100644 +index 5297912265..0fa11582d8 100644