From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFECEA0527 for ; Mon, 9 Nov 2020 19:45:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6F4472E9; Mon, 9 Nov 2020 19:45:46 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 85B2672E9 for ; Mon, 9 Nov 2020 19:45:44 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id v5so472846wmh.1 for ; Mon, 09 Nov 2020 10:45:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i4Twff5Rgwl+c5sp8S3ccP1xk6wn9vy0Fu5GCRtXIUc=; b=uE57gDoHF5xKQ5kkt2fp7ZXWX5qDwBktPbLZxndWCUlEwCg6BfWt+tha8fjs5tFq3Y a4NkhsJepl/3piTw0d+KT2A6EKBriflopyUPYV25Yely0D+IRXVGWYN0OZP6+X+ptHVw ZY2XjXpXgbVw3rczhHurcro7ZgbKdRX3/7610vKyePvGF5hP30/vw1kFTEo6KB45/VMW 3kg5ich3TItI63Bpv52+Fv0Ej9YEUJ1i4UeJPLYV0+pYtd2/g7axBOF6BcrKpdHQJ0hB s0aVMsYGRYXYA3q7Ecx6rYatiHEDLKe0MPTwgW0RGmw9va7yJUsj6lQ/v8SwvcV96y1a hlMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i4Twff5Rgwl+c5sp8S3ccP1xk6wn9vy0Fu5GCRtXIUc=; b=Lcc2hw95RDbggAgLTcCxR9kwSq3DXIhxybFS4Ubf+L2IcTid7g1Qu8cdZpeIYjL8Ld joHHPnxAqTcKaP38/BPgtVRo9hjeKYCW7FhdJoAb8uzDZJnfatyRMgJuzXPaopATzR1T 5+u15lP03m6SYPnrjwosj563A32XT/iUx6m/OSUeDOVmZjP9RHcmdFQx4B/eiyzACiVk naEuiCiQ+dX0S5WQn9COliCBEz6Cx1GNGkyu0+2lzjDYQTSrkWkrEpNpeCqBYxZQ/DaJ 9Bl/6FqDOIYvgEb1jK6ooOE4zNDHg93ivCSJAUoUqmtJlYBkYQFqXIuSP8UpgRVGOTqy 8ptA== X-Gm-Message-State: AOAM530+aUJhxMx/OjPVxE9zDQyZBcRXZxx+UxqknTcIhCec+PWBxSjQ 7XYNeqWUppweN4j3lelYskb71h0/BfSG9SHX X-Google-Smtp-Source: ABdhPJz1vcdHhXvH1UNCxiGkb0MZgkzDf8SbbS0LMX/FXLz0mzmB2/mR5RcSqzfhUlZMo2z7Y45L/g== X-Received: by 2002:a7b:c14f:: with SMTP id z15mr583122wmi.174.1604947544269; Mon, 09 Nov 2020 10:45:44 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x10sm13625362wrp.62.2020.11.09.10.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 10:45:43 -0800 (PST) From: luca.boccassi@gmail.com To: Guoyang Zhou Cc: dpdk stable Date: Mon, 9 Nov 2020 18:41:07 +0000 Message-Id: <20201109184111.3463090-79-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201109184111.3463090-1-luca.boccassi@gmail.com> References: <20201028104606.3504127-207-luca.boccassi@gmail.com> <20201109184111.3463090-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hinic/base: fix log info for PF command channel' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/11/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b89d88303019c9fcb655de23c78b657411845253 Thanks. Luca Boccassi --- >From b89d88303019c9fcb655de23c78b657411845253 Mon Sep 17 00:00:00 2001 From: Guoyang Zhou Date: Wed, 4 Nov 2020 10:03:20 +0800 Subject: [PATCH] net/hinic/base: fix log info for PF command channel [ upstream commit 1e4593db1d58e01c29d79259f5d98148e635963e ] When PF command channel is error, the variables in the log has been cleared, which is not printed yet. Fixes: 214164a6bf7f ("net/hinic/base: remove unused function parameters") Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_mgmt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c index a57036d531..8bff353da8 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.c +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c @@ -614,16 +614,18 @@ static int recv_mgmt_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, u8 *dest_msg; u8 seq_id, seq_len; u32 msg_buf_max = MAX_PF_MGMT_BUF_SIZE; + u8 front_id; seq_id = HINIC_MSG_HEADER_GET(msg_header, SEQID); seq_len = HINIC_MSG_HEADER_GET(msg_header, SEG_LEN); + front_id = recv_msg->sed_id; if (!check_mgmt_seq_id_and_seg_len(recv_msg, seq_id, seq_len)) { PMD_DRV_LOG(ERR, "Mgmt msg sequence and segment check fail, " "func id: 0x%x, front id: 0x%x, current id: 0x%x, seg len: 0x%x", hinic_global_func_id(pf_to_mgmt->hwdev), - recv_msg->sed_id, seq_id, seq_len); + front_id, seq_id, seq_len); return HINIC_ERROR; } -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-09 18:40:14.093509377 +0000 +++ 0079-net-hinic-base-fix-log-info-for-PF-command-channel.patch 2020-11-09 18:40:11.231312838 +0000 @@ -1 +1 @@ -From 1e4593db1d58e01c29d79259f5d98148e635963e Mon Sep 17 00:00:00 2001 +From b89d88303019c9fcb655de23c78b657411845253 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1e4593db1d58e01c29d79259f5d98148e635963e ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index babb93a204..fb31bc8581 100644 +index a57036d531..8bff353da8 100644 @@ -33 +34 @@ - "Mgmt msg sequence and segment check failed, " + "Mgmt msg sequence and segment check fail, "