patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com,
	stable@dpdk.org, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [PATCH 1/1] devtools: fix build test config inheritance from env
Date: Tue, 10 Nov 2020 11:20:44 +0000
Message-ID: <20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2429206.vUhvlFYDAN@thomas>

On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote:
> 10/11/2020 11:14, Bruce Richardson:
> > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote:
> > > PKG_CONFIG_PATH is specific to each target, so it must be empty
> > > before configuring each build from the file according to DPDK_TARGET.
> > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> > > and is prone to confusion.
> > > 
> > > DPDK_MESON_OPTIONS might take a global initial value from environment
> > > to customize a build test from the shell. Example:
> > > 	DPDK_MESON_OPTIONS="b_lto=true"
> > > Some target-specific options can be added in the configuration file:
> > > 	DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
> > > 
> > > Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > 
> > Patch looks fine, but I think the log (and comments in the code too,
> > perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the
> > local config file, to make it available to the script.
> 
> OK, I'll look at improving the "doc".
> We could also provide a template for the config file.
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>


  reply	other threads:[~2020-11-10 11:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:00 Thomas Monjalon
2020-11-10 10:14 ` Bruce Richardson
2020-11-10 10:45   ` Thomas Monjalon
2020-11-10 11:20     ` Bruce Richardson [this message]
2020-11-10 14:08       ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-11-10 17:18 ` [dpdk-stable] " Ferruh Yigit
2020-11-10 17:55   ` Thomas Monjalon
2020-11-10 18:09     ` Ferruh Yigit
2020-11-11  9:18       ` Bruce Richardson
2020-11-11 10:37         ` Thomas Monjalon
2020-11-11 11:00           ` Bruce Richardson
2020-11-11 11:13             ` Ferruh Yigit
2020-11-11 11:18               ` Thomas Monjalon
2020-11-12 14:22 ` [dpdk-stable] [PATCH v2 " Thomas Monjalon
2020-11-12 14:36   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git