From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBD97A04DB for ; Tue, 17 Nov 2020 12:15:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC9804C90; Tue, 17 Nov 2020 12:15:33 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 443FDF3E for ; Tue, 17 Nov 2020 12:15:32 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id r17so22794229wrw.1 for ; Tue, 17 Nov 2020 03:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mOZp3oaTADItGCOZoxMI0SPQKHOTAzGDo+ibm265gmA=; b=Emb4IIJOmylnZLxJk/3S9yGTPIRfpzdEvGFPh0sXO+sfeqG7BV40OCepGoL/q54A4l wsiDCeHARwiwBuVeXiA/+1twYtNBFiTEvAGuKPuE52sOQ6cV23NdFl2AZU3Nqc1LB7Qy AP9+d0ppsQZfxaInAG4rbsQ3RJqZMEqtxTCltiZifq/fE8rMm8rugrUn6NTNZHB7ANrI Tzoa0LafRv+Nh8NtsS+OgocdV9ZX4xJFP9T+DBovSnyb7PtM4pxQPkwpK0Gg0y0TSFL2 eL1PKuf9FS/q7gcYO7vKZeLLP2fAg1BtCuCW1QOVCNCWXJhZKpA7JmTjlYFP7HLlbYA0 Jo0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mOZp3oaTADItGCOZoxMI0SPQKHOTAzGDo+ibm265gmA=; b=PaC7l2HNxql/LSLgfZv2XcXHi5lgzM9WFUIMUy9MuO9bENskXwc1U3+up7NaHR4GxO 2/Q9tXfnBoFQQpBID8MvXkUWzR6HT0XOSmxxgKPY5Agi8DQFJ90lhN6qiUr3NRHV9vgJ YjoMQjqPg3fXpjZVbI/NcwCqOV6yKklt/IigQqhxazh3GIxsMysPUJcMzbIjIrvXtkBr qWXTfxv+1jLj9+k6ZY/GLUMW8x72xZ1kZPDPnnmGsGmkKMP14t3sTgFYpl/GBc8UY6TX U8sBCsdWO9dQWKUUFuQ99jhKCtx9AM9xyKW/yXGedWVCO7GAXeLzg3zRG3AsRFXwW6jS jllw== X-Gm-Message-State: AOAM533CtmZAiIroHFVU63Lcdsw7ANaLICcdkIp9Di0eOF68EaFE21/B kXHCIBoV3u1UHTHITIFbkSSSBr3zEeIlw7C1 X-Google-Smtp-Source: ABdhPJy9L5NMC2mRffSGIEG8C4gLNlGy0qQRneW8fB/hlBr2/RsuQjEuKpW8CCXpKyQcLjYYs9otlA== X-Received: by 2002:a05:6000:345:: with SMTP id e5mr23491588wre.333.1605611732038; Tue, 17 Nov 2020 03:15:32 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u14sm24398637wrq.93.2020.11.17.03.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:15:31 -0800 (PST) From: luca.boccassi@gmail.com To: Ting Xu Cc: Jingjing Wu , dpdk stable Date: Tue, 17 Nov 2020 11:13:56 +0000 Message-Id: <20201117111416.1961049-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201117111416.1961049-1-luca.boccassi@gmail.com> References: <20201109185030.3478760-2-luca.boccassi@gmail.com> <20201117111416.1961049-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/iavf: fix releasing mbufs' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/abf41510fca7349ecc03c412b9919427604d2f38 Thanks. Luca Boccassi --- >From abf41510fca7349ecc03c412b9919427604d2f38 Mon Sep 17 00:00:00 2001 From: Ting Xu Date: Wed, 11 Nov 2020 11:06:51 +0800 Subject: [PATCH] net/iavf: fix releasing mbufs [ upstream commit 36b8b062885f2b6576818a1c18ffaacb4dccefa5 ] In the function _iavf_rx_queue_release_mbufs_vec to release rx mbufs, rxq->rxrearm_nb is given the value of rx descriptor number at last. However, since the process to release and allocate mbufs lacks the initialization of rxrearm_nb, if we try to release mbufs next time, it will return without releasing directly. In this patch, rxrearm_nb is initialized to be zero in rx queue reset. Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") Signed-off-by: Ting Xu Acked-by: Jingjing Wu --- drivers/net/iavf/iavf_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 6aafc72e24..9672666567 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -167,6 +167,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) rxq->nb_rx_hold = 0; rxq->pkt_first_seg = NULL; rxq->pkt_last_seg = NULL; + rxq->rxrearm_nb = 0; } static inline void -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-17 11:13:13.916973222 +0000 +++ 0022-net-iavf-fix-releasing-mbufs.patch 2020-11-17 11:13:12.917116528 +0000 @@ -1 +1 @@ -From 36b8b062885f2b6576818a1c18ffaacb4dccefa5 Mon Sep 17 00:00:00 2001 +From abf41510fca7349ecc03c412b9919427604d2f38 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 36b8b062885f2b6576818a1c18ffaacb4dccefa5 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index baac5d65c8..8f43208c80 100644 +index 6aafc72e24..9672666567 100644 @@ -26 +27 @@ -@@ -194,6 +194,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq) +@@ -167,6 +167,7 @@ reset_rx_queue(struct iavf_rx_queue *rxq)