From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C00CA04DB for ; Tue, 17 Nov 2020 12:16:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 55AA337B0; Tue, 17 Nov 2020 12:16:23 +0100 (CET) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by dpdk.org (Postfix) with ESMTP id 00AE237B0 for ; Tue, 17 Nov 2020 12:16:21 +0100 (CET) Received: by mail-wr1-f44.google.com with SMTP id p1so22729299wrf.12 for ; Tue, 17 Nov 2020 03:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ui2PNlbUJPbFEeO+wmYuWSmQ+QGOzkMm5YBbcodBmNc=; b=D8ryj0/kfYB7upoqs8OmaH4UaOOz25Hcn5iOtDAKnB/JycAOf87KlNTzmY5mnNiylt IVR4owjfmY+5M2ciw3O1tGGXKac6hxQLT5NHT7RcI+yZg1TchMA49cD5IUrM4J8OY+Mm 0MKDWOsx1AEYUafggOyjMSmU4O52c0ZS1yBtZWyZrX9I+fWF0VXma0Tsd5QhFDEGWgqK gBplo/9Rqe973fFNh8i0nVCOHV/CEJGB1uYwbFhlC8TnGbQ9Xii/ekPjKhQLM713oaz+ Yn5RurNsGOUq2WAKjSkx/Jc9srNieYLI165Zi6CE2aARwjilxJttJOf9XNDgWv8wJ9p6 3hXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ui2PNlbUJPbFEeO+wmYuWSmQ+QGOzkMm5YBbcodBmNc=; b=HMZoCog9XoQ/8xIuTxJ5HyFmsNzI7iAINGLO6/UQ44yrBOscK8i64rzqLN8drTzyGN G6mKyOHvGuzjo2upgEOR0aRC/R4pGZk8ldqvMlAErTPpHur+L+a8YkjR8Tcme8kD9i2Q ql5/I7yd/d3534EGKUPi4mxgeyQe34DIUOQwPrcs7Xc/m0KTbtTPCobK+Yoo+2pLCqa+ cyWqDnt2oZt3ShWHN5M2tfEITwlszPZNcn2w9xpQckrOWbrrB5531qw4kD8hYTiiG1Tr rZT1jDoQAZ6216bjtb7jtgpPjP/gzdIssDt08O9/+JhZ4I5m/1XcD1ulgmrkXQk3ljZ7 LvUg== X-Gm-Message-State: AOAM531esArebtexO+oSRyvXILgRUvMVsR/sQE+7KDBTUyPkFkZjQ2tL eWB4iE8qpLqnnH21QkonIAXmqZfSAzKp8lhr X-Google-Smtp-Source: ABdhPJzUFj1HAIvFQ+HU3IwxRJxa+L3vc3yFcMev+6DvbV5aGc/9kIR4mdw+45x6aspYBT71Etnd1g== X-Received: by 2002:adf:fe0f:: with SMTP id n15mr25638275wrr.357.1605611780798; Tue, 17 Nov 2020 03:16:20 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a131sm3091917wmh.30.2020.11.17.03.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 03:16:20 -0800 (PST) From: luca.boccassi@gmail.com To: David Marchand Cc: Bruce Richardson , dpdk stable Date: Tue, 17 Nov 2020 11:14:11 +0000 Message-Id: <20201117111416.1961049-37-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201117111416.1961049-1-luca.boccassi@gmail.com> References: <20201109185030.3478760-2-luca.boccassi@gmail.com> <20201117111416.1961049-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/kni: fix build with pkg-config' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8a08b390f358454f343774222e34d38350030699 Thanks. Luca Boccassi --- >From 8a08b390f358454f343774222e34d38350030699 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Sat, 14 Nov 2020 10:05:25 +0100 Subject: [PATCH] examples/kni: fix build with pkg-config [ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ] rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/kni/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/kni/Makefile b/examples/kni/Makefile index 8fcb67c619..10b42891da 100644 --- a/examples/kni/Makefile +++ b/examples/kni/Makefile @@ -25,6 +25,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +LDFLAGS += -pthread + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-17 11:13:14.542381978 +0000 +++ 0037-examples-kni-fix-build-with-pkg-config.patch 2020-11-17 11:13:12.953117254 +0000 @@ -1 +1 @@ -From 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 Mon Sep 17 00:00:00 2001 +From 8a08b390f358454f343774222e34d38350030699 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index fa9fa85319..bbf3bcae12 100644 +index 8fcb67c619..10b42891da 100644 @@ -28 +29 @@ -@@ -27,6 +27,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API +@@ -25,6 +25,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API