patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org, Maryam Tahhan <maryam.tahhan@intel.com>,
	Reshma Pattan <reshma.pattan@intel.com>,
	Kuba Kozak <kubax.kozak@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	stable@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: [dpdk-stable] [v21.02 v3 02/10] app/procinfo: fix negative check on unsigned variable
Date: Thu, 19 Nov 2020 11:58:52 +0000	[thread overview]
Message-ID: <20201119115900.4095566-3-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com>

'parse_xstats_ids()' return 'int'. The return value is assigned to
'nb_xstats_ids' unsigned value, later negative check on this variable is
wrong.

Adding interim 'int' variable for negative check.

Fixes: 7ac16a3660c0 ("app/proc-info: support xstats by ID and by name")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
---
v3:
* Removed casting
---
 app/proc-info/main.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 35e5b596eb..8ee30ddb71 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -301,14 +301,13 @@ proc_info_parse_args(int argc, char **argv)
 			} else if (!strncmp(long_option[option_index].name,
 					"xstats-ids",
 					MAX_LONG_OPT_SZ))	{
-				nb_xstats_ids = parse_xstats_ids(optarg,
+				int ret = parse_xstats_ids(optarg,
 						xstats_ids, MAX_NB_XSTATS_IDS);
-
-				if (nb_xstats_ids <= 0) {
+				if (ret <= 0) {
 					printf("xstats-id list parse error.\n");
 					return -1;
 				}
-
+				nb_xstats_ids = ret;
 			}
 			break;
 		default:
-- 
2.26.2


  parent reply	other threads:[~2020-11-19 11:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200824094021.2323605-1-ferruh.yigit@intel.com>
2020-08-24  9:40 ` [dpdk-stable] [PATCH 6/7] ethdev: remove invalid symbols from map file Ferruh Yigit
2020-08-29 12:14   ` Andrew Rybchenko
     [not found] ` <20200903211000.244931-1-ferruh.yigit@intel.com>
2020-09-03 21:09   ` [dpdk-stable] [PATCH v2 " Ferruh Yigit
     [not found] ` <20200909111220.1195759-1-ferruh.yigit@intel.com>
2020-09-09 11:12   ` [dpdk-stable] [PATCH v3 " Ferruh Yigit
     [not found] ` <20200909130148.1756518-1-ferruh.yigit@intel.com>
2020-09-09 13:01   ` [dpdk-stable] [PATCH v4 " Ferruh Yigit
     [not found] ` <20201119115900.4095566-1-ferruh.yigit@intel.com>
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 01/10] app/procinfo: fix redundant condition Ferruh Yigit
2021-01-08 10:36     ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-11-19 11:58   ` Ferruh Yigit [this message]
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 04/10] app/procinfo: remove useless assignment Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one Ferruh Yigit
2021-01-08 10:31     ` David Marchand
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 06/10] net/bonding: " Ferruh Yigit
2021-01-08 10:34     ` [dpdk-stable] [dpdk-dev] " David Marchand
2021-01-11  1:03     ` [dpdk-stable] " Min Hu (Connor)
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 07/10] net/af_xdp: remove useless assignment Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 08/10] net/bnxt: fix redundant return Ferruh Yigit
2020-11-19 11:58   ` [dpdk-stable] [v21.02 v3 09/10] app/crypto-perf: remove always true condition Ferruh Yigit
2020-11-23 15:25     ` [dpdk-stable] [dpdk-dev] " Zhang, Roy Fan
2020-11-19 11:59   ` [dpdk-stable] [v21.02 v3 10/10] net/avp: " Ferruh Yigit
2020-11-20 17:40     ` Steven Webster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119115900.4095566-3-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kubax.kozak@intel.com \
    --cc=maryam.tahhan@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).