From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 022DFA04B1 for ; Mon, 23 Nov 2020 18:13:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFE03C90A; Mon, 23 Nov 2020 18:13:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C5751A3 for ; Mon, 23 Nov 2020 18:13:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J73R1DRI/ehOGTlnxB1a4FMyiYbT/05owRLtVYMyZ9w=; b=Mmz5j3XpoSf6jWPAlaMraqVQb6PCCT8fqtOoNn4hN9mNZTN+5uIEwEg3xfTxfXFkNkLM+3 QCx2Jt8BfXJ4trzvkk2spgPhk7eHMUfIxp4e6yxI1paVirj1Oe6dyKGuXusoH7V1KtpLBR 68eES9dEiIvXUeEbAv86Ip7qGauA4a4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-Xp9hTtjHMvGxfHgIP03G3Q-1; Mon, 23 Nov 2020 12:13:02 -0500 X-MC-Unique: Xp9hTtjHMvGxfHgIP03G3Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34E539A22D; Mon, 23 Nov 2020 17:13:01 +0000 (UTC) Received: from rh.redhat.com (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27EE360C04; Mon, 23 Nov 2020 17:12:59 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Luca Boccassi , dpdk stable Date: Mon, 23 Nov 2020 17:12:04 +0000 Message-Id: <20201123171222.79398-12-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-1-ktraynor@redhat.com> References: <20201123171222.79398-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'net/i40e: fix build for log format specifier' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/4d522efdc0340556319d2fc97c2b4e4493f2c80e Thanks. Kevin. --- >From 4d522efdc0340556319d2fc97c2b4e4493f2c80e Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 10 Nov 2020 17:54:57 +0000 Subject: [PATCH] net/i40e: fix build for log format specifier [ upstream commit c2f4dc6d60098a4596cdf5cee34fbeb8fab74410 ] Build error: i40e_common.c: In function "i40e_parse_discover_capabilities": ../drivers/net/i40e/base/../i40e_logs.h:43:50: error: format "%llX" expects argument of type "long long unsigned int", but argument 7 has type "u64" {aka "long unsigned int" [-Werror=format=] 43 | rte_log(RTE_LOG_ ## level, i40e_logtype_driver, "%s(): " fmt, \ | ^~~~~~~~ .../i40e_osdep.h:87:3: note: in expansion of macro "PMD_DRV_LOG_RAW" 87 | PMD_DRV_LOG_RAW(DEBUG, "i40e %02x.%x " s, \ | ^~~~~~~~~~~~~~~ .../base/i40e_common.c:4100:4: note: in expansion of macro "i40e_debug" 4100 | i40e_debug(hw, I40E_DEBUG_INIT, | ^~~~~~~~~~ There are multiple build error because of same reason, all fixed. Using 'PRIX64' to fix the build error. Fixes: 889bc9f0cd3a ("i40e/base: unify the capability function") Fixes: 9b1041574cd4 ("i40e/base: enhance polling of NVM semaphore") Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 3b7271f3958a ("i40e/base: catch NVM write semaphore timeout and retry") Signed-off-by: Ferruh Yigit Acked-by: Luca Boccassi --- drivers/net/i40e/base/i40e_common.c | 4 +++- drivers/net/i40e/base/i40e_nvm.c | 8 +++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index d22184daa6..8a2a84f65d 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -3,4 +3,6 @@ */ +#include + #include "i40e_type.h" #include "i40e_adminq.h" @@ -3986,5 +3988,5 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, p->wr_csr_prot |= (u64)logical_id << 32; i40e_debug(hw, I40E_DEBUG_INIT, - "HW Capability: wr_csr_prot = 0x%llX\n\n", + "HW Capability: wr_csr_prot = 0x%" PRIX64 "\n\n", (p->wr_csr_prot & 0xffff)); break; diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c index d87a6e56ff..16aebd077f 100644 --- a/drivers/net/i40e/base/i40e_nvm.c +++ b/drivers/net/i40e/base/i40e_nvm.c @@ -3,4 +3,6 @@ */ +#include + #include "i40e_prototype.h" @@ -78,5 +80,5 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw, if (ret_code) i40e_debug(hw, I40E_DEBUG_NVM, - "NVM acquire type %d failed time_left=%llu ret=%d aq_err=%d\n", + "NVM acquire type %d failed time_left=%" PRIu64 " ret=%d aq_err=%d\n", access, time_left, ret_code, hw->aq.asq_last_status); @@ -100,5 +102,5 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw, hw->nvm.hw_semaphore_timeout = 0; i40e_debug(hw, I40E_DEBUG_NVM, - "NVM acquire timed out, wait %llu ms before trying again. status=%d aq_err=%d\n", + "NVM acquire timed out, wait %" PRIu64 " ms before trying again. status=%d aq_err=%d\n", time_left, ret_code, hw->aq.asq_last_status); } @@ -1204,5 +1206,5 @@ retry: if (gtime >= hw->nvm.hw_semaphore_timeout) { i40e_debug(hw, I40E_DEBUG_ALL, - "NVMUPD: write semaphore expired (%d >= %lld), retrying\n", + "NVMUPD: write semaphore expired (%d >= %" PRIu64 "), retrying\n", gtime, hw->nvm.hw_semaphore_timeout); i40e_release_nvm(hw); -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-23 17:10:14.275972614 +0000 +++ 0012-net-i40e-fix-build-for-log-format-specifier.patch 2020-11-23 17:10:13.987061578 +0000 @@ -1 +1 @@ -From c2f4dc6d60098a4596cdf5cee34fbeb8fab74410 Mon Sep 17 00:00:00 2001 +From 4d522efdc0340556319d2fc97c2b4e4493f2c80e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c2f4dc6d60098a4596cdf5cee34fbeb8fab74410 ] + @@ -29 +30,0 @@ -Cc: stable@dpdk.org @@ -39 +40 @@ -index 8e3db0756c..e20bb9ac35 100644 +index d22184daa6..8a2a84f65d 100644 @@ -49 +50 @@ -@@ -4099,5 +4101,5 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, +@@ -3986,5 +3988,5 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, @@ -57 +58 @@ -index 6466d86486..561ed21136 100644 +index d87a6e56ff..16aebd077f 100644 @@ -81 +82 @@ -@@ -1301,5 +1303,5 @@ retry: +@@ -1204,5 +1206,5 @@ retry: