From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCC2BA04B1 for ; Mon, 23 Nov 2020 18:13:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C53CBC8F4; Mon, 23 Nov 2020 18:13:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id C1576C8F4 for ; Mon, 23 Nov 2020 18:13:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGIWQvbZEiNm22XHF95gYxqIfmmttDGhSv4t9tUcxtQ=; b=MGxHHIih96zgL7P6Um3F4k6F0BgSTtMy0WXZWnRRtydA6eQN34lQW3ZMLtlJtdtYymw9tv c+hQn0ZzcgKY4atkcULzLL6kTk5Ps+FmD9MjAxxX8iOyg0acrYM0rSwsdnPTkx4u/d8e4x 35iIuq03wXKqTHehZbSEvu6G+z4XksU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-u5lwYCi9MFKDFnDyWg6c5A-1; Mon, 23 Nov 2020 12:13:19 -0500 X-MC-Unique: u5lwYCi9MFKDFnDyWg6c5A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32358100A648; Mon, 23 Nov 2020 17:13:18 +0000 (UTC) Received: from rh.redhat.com (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3589960C04; Mon, 23 Nov 2020 17:13:13 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Bruce Richardson , dpdk stable Date: Mon, 23 Nov 2020 17:12:11 +0000 Message-Id: <20201123171222.79398-19-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-1-ktraynor@redhat.com> References: <20201123171222.79398-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'examples/kni: fix build with pkg-config' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/80741c6a2ce00ce9a46a9944caa0457d85378685 Thanks. Kevin. --- >From 80741c6a2ce00ce9a46a9944caa0457d85378685 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Sat, 14 Nov 2020 10:05:25 +0100 Subject: [PATCH] examples/kni: fix build with pkg-config [ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ] rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- examples/kni/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/kni/Makefile b/examples/kni/Makefile index b3d39a5778..c6e3b8eed0 100644 --- a/examples/kni/Makefile +++ b/examples/kni/Makefile @@ -26,4 +26,6 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk) +LDFLAGS += -pthread + build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build $(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED) -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-23 17:10:14.444258906 +0000 +++ 0019-examples-kni-fix-build-with-pkg-config.patch 2020-11-23 17:10:14.001061594 +0000 @@ -1 +1 @@ -From 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 Mon Sep 17 00:00:00 2001 +From 80741c6a2ce00ce9a46a9944caa0457d85378685 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index fa9fa85319..bbf3bcae12 100644 +index b3d39a5778..c6e3b8eed0 100644 @@ -28,2 +29,2 @@ -@@ -28,4 +28,6 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) - LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk) +@@ -26,4 +26,6 @@ LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk) + LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)