From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85A73A04B1 for ; Mon, 23 Nov 2020 18:13:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79F4EC8F8; Mon, 23 Nov 2020 18:13:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 6A438A3 for ; Mon, 23 Nov 2020 18:13:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606151615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EJQXBMsHSgh0IjaOhuJC1NVq6bp7P2RM+33qoEX6ZbM=; b=OSMgleiKZ42Mf6rGh4TTcGSY4JlLnDfHRbNXZ1Qw83LRY/WTL8egd/ps8URhvTJSsi913m dWtjhuoVcL2C4L0n49IqlPeqQWsvy9/MKcgJdXBrUgKccdVSDKX7X+Rt+IgZHYWLnrjXeS OhiVk3REHIO2vq1uoWxjcTSGucnk/40= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-iC37DwAvPBSGc-n6PgvNDA-1; Mon, 23 Nov 2020 12:13:31 -0500 X-MC-Unique: iC37DwAvPBSGc-n6PgvNDA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9D8884A5E6; Mon, 23 Nov 2020 17:13:30 +0000 (UTC) Received: from rh.redhat.com (ovpn-112-19.ams2.redhat.com [10.36.112.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id CAF5D60C04; Mon, 23 Nov 2020 17:13:29 +0000 (UTC) From: Kevin Traynor To: Gregory Etelson Cc: dpdk stable Date: Mon, 23 Nov 2020 17:12:19 +0000 Message-Id: <20201123171222.79398-27-ktraynor@redhat.com> In-Reply-To: <20201123171222.79398-1-ktraynor@redhat.com> References: <20201123171222.79398-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-stable] patch 'examples/l3fwd-power: check packet types after start' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.11 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/27/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/82297adc98c43bcd82460d107f8c4b115ecca7c7 Thanks. Kevin. --- >From 82297adc98c43bcd82460d107f8c4b115ecca7c7 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Tue, 17 Nov 2020 20:49:39 +0200 Subject: [PATCH] examples/l3fwd-power: check packet types after start [ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ] l3fwd-power uses `--parse-ptype' parameter to query egress packets type. Before that feature is enabled l3fwd-power verifies PMD ability to advertise supported packet types with rte_eth_dev_get_supported_ptypes(). The above ethdev function API contains this note: " Better to invoke this API after the device is already started or rx burst function is decided, to obtain correct supported ptypes. " The patch updates code for PMDs that register supported types after dev_start. Fixes: 82bea4661626 ("examples/l3fwd-power: add --parse-ptype option") Signed-off-by: Gregory Etelson --- examples/l3fwd-power/main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index c2a9d36cb6..4d1f24a1e8 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -2150,7 +2150,5 @@ main(int argc, char **argv) rte_exit(EXIT_FAILURE, "Fail to add ptype cb\n"); - } else if (!check_ptype(portid)) - rte_exit(EXIT_FAILURE, - "PMD can not provide needed ptypes\n"); + } } } @@ -2178,4 +2176,9 @@ main(int argc, char **argv) /* initialize spinlock for each port */ rte_spinlock_init(&(locks[portid])); + + if (!parse_ptype) + if (!check_ptype(portid)) + rte_exit(EXIT_FAILURE, + "PMD can not provide needed ptypes\n"); } -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-23 17:10:14.630943861 +0000 +++ 0027-examples-l3fwd-power-check-packet-types-after-start.patch 2020-11-23 17:10:14.014061609 +0000 @@ -1 +1 @@ -From 6184a02223722b929ae99dff2ba967626448dd63 Mon Sep 17 00:00:00 2001 +From 82297adc98c43bcd82460d107f8c4b115ecca7c7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 2874285c4e..995a3b6ad7 100644 +index c2a9d36cb6..4d1f24a1e8 100644 @@ -32 +33 @@ -@@ -2708,7 +2708,5 @@ main(int argc, char **argv) +@@ -2150,7 +2150,5 @@ main(int argc, char **argv) @@ -41 +42 @@ -@@ -2741,4 +2739,9 @@ main(int argc, char **argv) +@@ -2178,4 +2176,9 @@ main(int argc, char **argv)