From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B66F4A0527 for ; Wed, 25 Nov 2020 10:03:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE249C960; Wed, 25 Nov 2020 10:03:39 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by dpdk.org (Postfix) with ESMTP id 5E1C8C96E for ; Wed, 25 Nov 2020 10:03:38 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id p8so1101242wrx.5 for ; Wed, 25 Nov 2020 01:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BWkyxHKiW1aO+2C5KMbmbLlSZh+f7fHuxs/k1Zzxf7U=; b=sqFB6wWAekLAdhswES4x49iPYPZrN7GIn15RDH+J7YSKqVavwTSladNmgQTCI6a1Uw fZjKqHQDv3wwLuObRPyzYpmKfeozddinUnl+xV3fFdcpkGrFB8tRU1lH8NGLdXe0oJjS c1PHgYXmXYv76WF2MuZzkmHufvAODDCwE4n2aqOw3RR94zuBDXUeYQ6XKTNh8DIXqzEE ykhnX+VTCmTRqjwl7quvGafSrY7u0BQRZP15OtLjwey4ynDoj0oOqvOTJRhKXWKhDgzo sunQJvTPZMfuSu1BI/OT0h+bCmOh7LDUNjEP524A/j5BSJnOTweKzQ5PqPn2obTuJkGv 1Ldw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BWkyxHKiW1aO+2C5KMbmbLlSZh+f7fHuxs/k1Zzxf7U=; b=OBwMTHUb1B5wJ6JdabJQewQPrVVvthwdH6T3XyHyYR3fchYDZTRkA39IVLi/zfqHz1 xCphRBw3RdkZHp21+yWFl7NYwDi1+q8jJQuDnrQvO12bm7kpMEbrOEN7H5rtN5owVF7b TvTX0TGSBlQ38oYFIQnZbej/ZKKG3odRLNsELdBASPd0NX2qVb7RdH0qEOLxwgL4TS/A dGzTPBtcNHL0TqZ5zRN2lLPMwaj9VslNNbG4frmFNPzlRPfJd4ERKeS6rHG0fX490ZcA 1uIou3DyxBfWKuUYzaiBnkru5VwJFYTptzLi2l0YE/rJllmH/Hib197GMLQAdGKjmwNb 1Efw== X-Gm-Message-State: AOAM532lxnXYuKtjC9CdFwL2Q+Lyf+DKSYo2hAxinGQmqBtcNyFIvSTy WQLD2G9IAXOeNqctGnkJ6e5uHNu35UHtzA== X-Google-Smtp-Source: ABdhPJwx5eD7BxfrvNoHkixvINDatJU5+vzA5BsmFFSs7Z0tkVtaXIQcCTaAijk4JcaEdRnr4tHY6g== X-Received: by 2002:adf:f8d2:: with SMTP id f18mr2723206wrq.379.1606295017177; Wed, 25 Nov 2020 01:03:37 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id e3sm3775628wrn.25.2020.11.25.01.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:03:36 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: dpdk stable Date: Wed, 25 Nov 2020 09:02:54 +0000 Message-Id: <20201125090258.21457-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201125090258.21457-1-luca.boccassi@gmail.com> References: <20201117111416.1961049-42-luca.boccassi@gmail.com> <20201125090258.21457-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/l3fwd-power: check packet types after start' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b015138d9a73e355cda98840fe70da888cf1531b Thanks. Luca Boccassi --- >From b015138d9a73e355cda98840fe70da888cf1531b Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Tue, 17 Nov 2020 20:49:39 +0200 Subject: [PATCH] examples/l3fwd-power: check packet types after start [ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ] l3fwd-power uses `--parse-ptype' parameter to query egress packets type. Before that feature is enabled l3fwd-power verifies PMD ability to advertise supported packet types with rte_eth_dev_get_supported_ptypes(). The above ethdev function API contains this note: " Better to invoke this API after the device is already started or rx burst function is decided, to obtain correct supported ptypes. " The patch updates code for PMDs that register supported types after dev_start. Fixes: 82bea4661626 ("examples/l3fwd-power: add --parse-ptype option") Signed-off-by: Gregory Etelson --- examples/l3fwd-power/main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index aa6ff2627b..7fe5cbf577 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -2445,9 +2445,7 @@ main(int argc, char **argv) if (add_cb_parse_ptype(portid, queueid) < 0) rte_exit(EXIT_FAILURE, "Fail to add ptype cb\n"); - } else if (!check_ptype(portid)) - rte_exit(EXIT_FAILURE, - "PMD can not provide needed ptypes\n"); + } } } @@ -2478,6 +2476,11 @@ main(int argc, char **argv) } /* initialize spinlock for each port */ rte_spinlock_init(&(locks[portid])); + + if (!parse_ptype) + if (!check_ptype(portid)) + rte_exit(EXIT_FAILURE, + "PMD can not provide needed ptypes\n"); } check_all_ports_link_status(enabled_port_mask); -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-24 16:50:37.069013320 +0000 +++ 0012-examples-l3fwd-power-check-packet-types-after-start.patch 2020-11-24 16:50:36.569496315 +0000 @@ -1 +1 @@ -From 6184a02223722b929ae99dff2ba967626448dd63 Mon Sep 17 00:00:00 2001 +From b015138d9a73e355cda98840fe70da888cf1531b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 2874285c4e..995a3b6ad7 100644 +index aa6ff2627b..7fe5cbf577 100644 @@ -32 +33 @@ -@@ -2707,9 +2707,7 @@ main(int argc, char **argv) +@@ -2445,9 +2445,7 @@ main(int argc, char **argv) @@ -43 +44 @@ -@@ -2740,6 +2738,11 @@ main(int argc, char **argv) +@@ -2478,6 +2476,11 @@ main(int argc, char **argv)