From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1BFEA0527 for ; Wed, 25 Nov 2020 10:03:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C680AC970; Wed, 25 Nov 2020 10:03:41 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 979CDC950 for ; Wed, 25 Nov 2020 10:03:39 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id w24so1407368wmi.0 for ; Wed, 25 Nov 2020 01:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gjig55qzEYOezfxyC0FOb4e9SUa52mdvF0duZONRMrw=; b=JV6HjM5gUQWJ9xko0We25d8wkrHvywyVZZYqdjShBYx/+R/PYCBHIpkjj+gqPknweK 7xVGL3pELNKPkAsoivtDhMlL2B9t6rW7pZT/C7OcUDtCeg6pghjj4OGMggr42VOEg6VM bhbHuuYb2o4xr3TWc1C7InUKPi3o0IgYnh58sGEtXTPX5nLkHldGebjl1KGPg3XTjQ1k ROjGXWNIGvVXnQAOZ6+vLdO00lEiuMvYAcsBnKfJj1Mmg61LOCDVjxhkDXdGkr86lEao OtwE9LfjCRjq+UUWRZNp12jaXHnMz/CqfFKuv6XsGneTCbYi25rjI6DvF0wEfjeip+E3 iQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gjig55qzEYOezfxyC0FOb4e9SUa52mdvF0duZONRMrw=; b=XVlfLzQWGWft9TQJF8mJM/DMHTnM1GlkI7cAf/Myd9DgiWSFIA4gOioCyPqcAl/DAv 6LWjGdoQQyCCq6QSbCLAUJwmLxvFW7YJQc2u2aEfVZ4J6YAvEyfVU8Ifn2IR7ZTdztk9 qy0abDsle9pwKAZh4oNtYOgAZkQw1/HA1ybpY0Pzy2ZsucP8bCU0bys6oe0b63h9Pkdw 74eJFyUkAyx3n5EtfWuyjjFCoKuLAOb4x57vtSaw+LVA8LqBNAdKYPGgoH4qeufPg7+v nE75Q1197aR0PyHG8XGkQGa2llnUa++eDiGgBjVU2pNA1BVos+R3YICQWDsat6BfBnER RltQ== X-Gm-Message-State: AOAM5336WeCscP2ut8HXjrHYntOmk1ZF+RgYKW56oqxj1wviSrcUcTiI LiQDkXg5m0JfX0bNKK4nA1Y= X-Google-Smtp-Source: ABdhPJx5kb2CA+lZeyBLby8Xr1o1j1Mi1XFw+wz5yiuVlVsLsf97FH2F8QqbkvAnh06QfwAtMfe7Qg== X-Received: by 2002:a7b:cb0c:: with SMTP id u12mr2695393wmj.11.1606295018398; Wed, 25 Nov 2020 01:03:38 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x13sm3274774wmi.20.2020.11.25.01.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:03:37 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Viacheslav Ovsiienko , dpdk stable Date: Wed, 25 Nov 2020 09:02:55 +0000 Message-Id: <20201125090258.21457-13-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201125090258.21457-1-luca.boccassi@gmail.com> References: <20201117111416.1961049-42-luca.boccassi@gmail.com> <20201125090258.21457-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix representor interrupts handler' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/08e7b069e6c72c91f93305cdd89459af8fbd4ca4 Thanks. Luca Boccassi --- >From 08e7b069e6c72c91f93305cdd89459af8fbd4ca4 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Tue, 17 Nov 2020 20:49:40 +0200 Subject: [PATCH] net/mlx5: fix representor interrupts handler [ upstream commit 5882bde88da28b82f138676544ca9e807a9124f5 ] Representor is a port in DPDK that is connected to a VF in such a way that assuming there are no offload flows, each packet that is sent from the VF will be received by the corresponding representor. While each packet that is sent to a representor will be received by the VF. This is very useful in case of SRIOV mode, where the first packet that is sent by the VF will be received by the DPDK application which will decide if this flow should be offloaded to the E-Switch. Representor shares interrupts handler with host PF over the PCI address. Therefore, after PF completes its interrupts handler initialization, no additional actions required for representor. Fixes: 26c08b979d26 ("net/mlx5: add port representor awareness") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index f3c2d99c15..104687db39 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -723,6 +723,9 @@ mlx5_rx_intr_vec_enable(struct rte_eth_dev *dev) unsigned int count = 0; struct rte_intr_handle *intr_handle = dev->intr_handle; + /* Representor shares dev->intr_handle with PF. */ + if (priv->representor) + return 0; if (!dev->data->dev_conf.intr_conf.rxq) return 0; mlx5_rx_intr_vec_disable(dev); @@ -800,6 +803,9 @@ mlx5_rx_intr_vec_disable(struct rte_eth_dev *dev) unsigned int rxqs_n = priv->rxqs_n; unsigned int n = RTE_MIN(rxqs_n, (uint32_t)RTE_MAX_RXTX_INTR_VEC_ID); + /* Representor shares dev->intr_handle with PF. */ + if (priv->representor) + return; if (!dev->data->dev_conf.intr_conf.rxq) return; if (!intr_handle->intr_vec) -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-24 16:50:37.108119220 +0000 +++ 0013-net-mlx5-fix-representor-interrupts-handler.patch 2020-11-24 16:50:36.573496401 +0000 @@ -1 +1 @@ -From 5882bde88da28b82f138676544ca9e807a9124f5 Mon Sep 17 00:00:00 2001 +From 08e7b069e6c72c91f93305cdd89459af8fbd4ca4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5882bde88da28b82f138676544ca9e807a9124f5 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index f298327005..da7a8b3cd7 100644 +index f3c2d99c15..104687db39 100644 @@ -31 +32 @@ -@@ -902,6 +902,9 @@ mlx5_rx_intr_vec_enable(struct rte_eth_dev *dev) +@@ -723,6 +723,9 @@ mlx5_rx_intr_vec_enable(struct rte_eth_dev *dev) @@ -41 +42 @@ -@@ -982,6 +985,9 @@ mlx5_rx_intr_vec_disable(struct rte_eth_dev *dev) +@@ -800,6 +803,9 @@ mlx5_rx_intr_vec_disable(struct rte_eth_dev *dev)