From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10AEBA0527 for ; Wed, 25 Nov 2020 10:03:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0866DC940; Wed, 25 Nov 2020 10:03:46 +0100 (CET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by dpdk.org (Postfix) with ESMTP id C852CC97A for ; Wed, 25 Nov 2020 10:03:42 +0100 (CET) Received: by mail-wm1-f44.google.com with SMTP id s13so1388107wmh.4 for ; Wed, 25 Nov 2020 01:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FJV89Z5xIBl2pwq6MM8Eg8RooLvCx0ajBsQOiVmxNCo=; b=vJCc6PjK9gBptTImOh0axCbG9TKBO81RIQV8PIG/Jvy39IqdXaQzboMIL2szddpY+P O7ZTleixUChR6nMqTYTmy8Fv6v2Gl/nhMa0M6K6BVQP5/L3ZtmwdsqOqb0a9zqMv6y4D 3URWfDHQwGBCWcDr8aJKPmymuZMI/ySxiJfpDBiTmBTLCqXVexlKvrVK2usEG3KLuY1M i2+zESn+A2d9etJqrPcn0EIHtnorY9u17kMyvWUgXqcFRlLOZXHYkHRZPhf/QNJdp5rn wgAcVh2O479Yk8w6qBwJb3ztKJ6yde4D+wJrD2uj4avHMCWs7Ki1mkn/d0xqMQE705AF dhzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FJV89Z5xIBl2pwq6MM8Eg8RooLvCx0ajBsQOiVmxNCo=; b=V72uAfhXSWwyde9YqltfMjR7TwKijmIqOCCQcmn836f9PpO+Z0FbHfp/CRyry3zjnT wqxw/sovtL4A0vq+t+8ehTSgroWFD3zoWWF+CGrW4m1mTXh4WBjElidc7kMAPMbC4fFG OSz/VRjS5AKiDfthbLjtdJgF0PI0FzWa8jaevOgivnThX+ipX+z2Ty2vaGU4qcTtwoYO pxCdPttguylKI+L+ero7e/V4OQTgL3m6XZd1/a+krALqpWEnQSciC8xIrb5uZRKhnP0d hcUjrL6C36wcQggEnF+u8LOWqFXxUnRiYfVWE9PU3eO677vhhPIBVHeeQli0er1oqU0j wMuA== X-Gm-Message-State: AOAM530jMktw1TFa3XMz2oeTLQ5fXrM2KASXS+H5aYEMQ/LVZVLbtkjH 7c4aS/8jvVFPuFhHR/oh9G42C6Y91v1MXg== X-Google-Smtp-Source: ABdhPJzoEmxT/ny+YQ5o+aPZoyN+saecTaGCVdhHWxD6wVs4FyjQtsihgRsaTW6upjMWm5mVwd++qQ== X-Received: by 2002:a7b:c0c2:: with SMTP id s2mr2699566wmh.78.1606295021587; Wed, 25 Nov 2020 01:03:41 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c64sm3204997wmd.41.2020.11.25.01.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:03:40 -0800 (PST) From: luca.boccassi@gmail.com To: Conor Walsh Cc: Lingli Chen , dpdk stable Date: Wed, 25 Nov 2020 09:02:57 +0000 Message-Id: <20201125090258.21457-15-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201125090258.21457-1-luca.boccassi@gmail.com> References: <20201117111416.1961049-42-luca.boccassi@gmail.com> <20201125090258.21457-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'build: fix gcc warning requiring Wformat' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/dd2c4e336023676ec665e94af942ac993d5a7532 Thanks. Luca Boccassi --- >From dd2c4e336023676ec665e94af942ac993d5a7532 Mon Sep 17 00:00:00 2001 From: Conor Walsh Date: Thu, 19 Nov 2020 10:16:59 +0000 Subject: [PATCH] build: fix gcc warning requiring Wformat [ upstream commit 654e893436649ca6a876b0bd0f30b4357edc4462 ] On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a warning on every build step saying that -Wformat-nonliteral and -Wformat-security warnings will be ignored unless -Wformat is also specified as a compiler flag. When the build is run with -werror the build will fail due to these warnings. Exact warning returned: cc1: error: -Wformat-nonliteral ignored without -Wformat [-Werror=format-nonliteral] cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security] cc1: all warnings being treated as errors This patch adds the -Wformat flag to config/meson.build. The warning id 181 has also been suppressed in icc as icc was showing false positives with -Wformat enabled. Fixes: 524a0d5d66b9 ("build: enable extra warnings with meson") Signed-off-by: Conor Walsh Tested-by: Lingli Chen --- config/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/meson.build b/config/meson.build index fca0461d67..bab00f1489 100644 --- a/config/meson.build +++ b/config/meson.build @@ -183,6 +183,7 @@ warning_flags = [ # additional warnings in alphabetical order '-Wcast-qual', '-Wdeprecated', + '-Wformat', '-Wformat-nonliteral', '-Wformat-security', '-Wmissing-declarations', -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-24 16:50:37.183903447 +0000 +++ 0015-build-fix-gcc-warning-requiring-Wformat.patch 2020-11-24 16:50:36.577496485 +0000 @@ -1 +1 @@ -From 654e893436649ca6a876b0bd0f30b4357edc4462 Mon Sep 17 00:00:00 2001 +From dd2c4e336023676ec665e94af942ac993d5a7532 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 654e893436649ca6a876b0bd0f30b4357edc4462 ] + @@ -24 +25,0 @@ -Cc: stable@dpdk.org @@ -29,2 +30,2 @@ - config/meson.build | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) + config/meson.build | 1 + + 1 file changed, 1 insertion(+) @@ -33 +34 @@ -index a29693b883..c02802c18e 100644 +index fca0461d67..bab00f1489 100644 @@ -36 +37 @@ -@@ -194,6 +194,7 @@ warning_flags = [ +@@ -183,6 +183,7 @@ warning_flags = [ @@ -44,9 +44,0 @@ -@@ -220,7 +221,7 @@ if not dpdk_conf.get('RTE_ARCH_64') - warning_flags += '-Wno-pointer-to-int-cast' - endif - if cc.get_id() == 'intel' -- warning_ids = [188, 2203, 2279, 2557, 3179, 3656] -+ warning_ids = [181, 188, 2203, 2279, 2557, 3179, 3656] - foreach i:warning_ids - warning_flags += '-diag-disable=@0@'.format(i) - endforeach