From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD6B0A0527 for ; Wed, 25 Nov 2020 10:03:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B06AC958; Wed, 25 Nov 2020 10:03:06 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id EB0BFC958 for ; Wed, 25 Nov 2020 10:03:04 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id 1so1396648wme.3 for ; Wed, 25 Nov 2020 01:03:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PRgTttj4JXeOeyIBy16f7OgOB2v6rFtZXhkG9Cr2WZ8=; b=TIcRIO0JsbLU8obXv1jL0r3Uu7AScx8wS1KjsaD8oSHk5R5girx2U0Xg6HPuu0rLVM Zqs1hi7Mfiw0GWhYdYx6a7n6ttrh6zh1d9scUX8Sae5vhYtmw/Rxxme4Kji5oBIuAYOX ttPQCvKZg4zmwj9pDt9Vcj6smRaa6V2gGMHeDH3FzOkNf86KEoYNMSIZYDi/b+SVMCbT 1zI9MkioX7ZRM+AFv5aaxTwAWIB8xyqh4sdkPV53rjkbJKlGbYjJWXUCGxSA5MuGx7VO eGIbgRddbz/bpf0E4tWlV2HTdoMEhofFf/p41pkadkM4OBDLkEBn9AgqRoQ17kVyl3tC KI1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PRgTttj4JXeOeyIBy16f7OgOB2v6rFtZXhkG9Cr2WZ8=; b=kVSNmzpOSCj5ohs8h1Oe8tUshL29mydVT/CChemQmHUH2nOzR1t0YaylQ72EZ4zQ5Q YsRKdsLOT6Sd0SqiDU6cYM1huqs5urcdfRGPLEISU6AmbFd9NXK0tYQvBmQHw2TyYLSP 4wUoJY+dbVd4hlsS4RrJzsE8ocjJMmjVSjHDsVx7+M/ZbrLfJF3ZoDKToPm0070krYyq UW3OeGn4rB1btCJBI/FwZliRjDS51iaYJOIpbsShwM9/SVPBkrG4wg4KYCrT4KSRs/u6 Cjw9hU+UqMdgUuBYHPKAiRLFQ7jC72uAXFEFTGxB3d3U336LfofOMY1sdNCLQwWD0R8Y j3UA== X-Gm-Message-State: AOAM531LgNf0ePnzDn0tXmUl7hG8Zz1miGNHynB50d4cvSyJYO3KrcMG CocDUroy/D6AWvSmJabKFGg= X-Google-Smtp-Source: ABdhPJzhsfJvdLb/HpGWRDHRYAVQvZSHzhbja52Am0Qvl5uXKSoXv0U1mTGj/rZhQuyPQd1xWRrPew== X-Received: by 2002:a1c:98cd:: with SMTP id a196mr2784953wme.42.1606294983670; Wed, 25 Nov 2020 01:03:03 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c187sm3938063wmd.23.2020.11.25.01.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:03:02 -0800 (PST) From: luca.boccassi@gmail.com To: Alexander Kozyrev Cc: Matan Azrad , dpdk stable Date: Wed, 25 Nov 2020 09:02:44 +0000 Message-Id: <20201125090258.21457-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201125090258.21457-1-luca.boccassi@gmail.com> References: <20201117111416.1961049-42-luca.boccassi@gmail.com> <20201125090258.21457-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix Rx packet padding config via DevX' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7d36191470aad626b69ad3751fbeb86c18ede3a7 Thanks. Luca Boccassi --- >From 7d36191470aad626b69ad3751fbeb86c18ede3a7 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Sun, 15 Nov 2020 14:25:34 +0000 Subject: [PATCH] net/mlx5: fix Rx packet padding config via DevX [ upstream commit ff2deada2ed8e1659e8774c42638657aaf77dc5b ] Received packets can be aligned to the size of the cache line on PCI transactions. This could improve performance by avoiding partial cache line writes in exchange for increased PCI bandwidth. This feature is supposed to be controlled by the rxq_pkt_pad_en devarg and it is true for an RxQ created via the Verbs API. But in the DevX API case, it is erroneously controlled by the rxq_cqe_pad_en devarg instead, which is in charge of the CQE padding instead and should not control the RxQ creation. Fix DevX RxQ creation by using the proper configuration flag for Rx packet padding that is being set by the rxq_pkt_pad_en devarg. Fixes: dc9ceff73c99 ("net/mlx5: create advanced RxQ via DevX") Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 5a11325430..f3c2d99c15 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1153,7 +1153,7 @@ static void mlx5_devx_wq_attr_fill(struct mlx5_priv *priv, struct mlx5_rxq_ctrl *rxq_ctrl, struct mlx5_devx_wq_attr *wq_attr) { - wq_attr->end_padding_mode = priv->config.cqe_pad ? + wq_attr->end_padding_mode = priv->config.hw_padding ? MLX5_WQ_END_PAD_MODE_ALIGN : MLX5_WQ_END_PAD_MODE_NONE; wq_attr->pd = priv->sh->pdn; -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-24 16:50:36.630541342 +0000 +++ 0002-net-mlx5-fix-Rx-packet-padding-config-via-DevX.patch 2020-11-24 16:50:36.533495553 +0000 @@ -1 +1 @@ -From ff2deada2ed8e1659e8774c42638657aaf77dc5b Mon Sep 17 00:00:00 2001 +From 7d36191470aad626b69ad3751fbeb86c18ede3a7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff2deada2ed8e1659e8774c42638657aaf77dc5b ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ - drivers/net/mlx5/mlx5_devx.c | 2 +- + drivers/net/mlx5/mlx5_rxq.c | 2 +- @@ -28,5 +29,5 @@ -diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c -index e9ceda5caf..34044fcb0c 100644 ---- a/drivers/net/mlx5/mlx5_devx.c -+++ b/drivers/net/mlx5/mlx5_devx.c -@@ -294,7 +294,7 @@ static void +diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c +index 5a11325430..f3c2d99c15 100644 +--- a/drivers/net/mlx5/mlx5_rxq.c ++++ b/drivers/net/mlx5/mlx5_rxq.c +@@ -1153,7 +1153,7 @@ static void