From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57339A0527 for ; Wed, 25 Nov 2020 10:03:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E4D6C95E; Wed, 25 Nov 2020 10:03:26 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by dpdk.org (Postfix) with ESMTP id 1A100C94E for ; Wed, 25 Nov 2020 10:03:22 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id w24so1406558wmi.0 for ; Wed, 25 Nov 2020 01:03:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OKh/KBZ4pCvr8am6MvZVk6nplM4OdQjW+gYVfvw0kE=; b=B4/ohJm2+R+I7qmr7H1HmIHLdM0/PO8zhkwVHuxn9GVZ94OAUCFy1sEtArleVXFTBt IojkCi5/rqkGeJ2A3SfSgXteIrJYaSvutUeH0qgheStY+ujjjSHriBiL3k1o4TA3UONb EM8DxxHaYqCEq8Cz/w3/ZmBlXdMeYBy5PX/b27a3HT6Zgq+8aAJMgVoTrx9CkxnkkXAM 72SEOwBy8xvuPF/mnehWM/IA78upclQK8nx0cr2IJBs7aJizEfHugu0/xA1QwV5Lt6WU AXsX+rCrUaeAasFNgkExv2GOVF9x8ijIq98/PmcLQpPtoHNKGekYLrzSurhygzu6Zd/m 82og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2OKh/KBZ4pCvr8am6MvZVk6nplM4OdQjW+gYVfvw0kE=; b=YauZ4GiBhGz4O9MOYrNFXtfsihVSWUFzx+k6yuA9cCtuWtpnZlwwHxdo+eY8z9+NQt GOCXCMwJKQTzsxoUddp2EQLojPlWh66Og6zl1aF7UBy3Oyge7BILEF2lNcgz/yOXEgA7 SkolpjfS/y9tPaQH2UlGK+z42zApzeO6VIC5WbIjO/LbNxv1JamUIbdFT834lAdIXXQK lJpNxDXWDQfvrSvef2Esgwiz0klJZt2CDLjB0AFOsGE5pFSngK4+wkEqpOCaNS8ZwBb8 Wta81SeQTb8hO4VVJz9PNwFe/sl9qGktfDtOBC/3mxwAgiErkF+nRnIpPxtSDaQrCtGb crHw== X-Gm-Message-State: AOAM533gAwoEApvY7RTgPZcHDII1Kbq2IKmlDDccn9M1B2HzTQYV4v6K CoFkT991tRLIzH6aKBguOnQ= X-Google-Smtp-Source: ABdhPJy7zMxl7Qr9z+VXx/e/TCT9iBLw2kYQGR2d5GCQK4vKAdCORmo9PRfNU4JMQ51T46ozjYL5rA== X-Received: by 2002:a1c:4d0a:: with SMTP id o10mr2711813wmh.107.1606295001878; Wed, 25 Nov 2020 01:03:21 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x4sm3551740wrv.81.2020.11.25.01.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 01:03:20 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Bo Chen , dpdk stable Date: Wed, 25 Nov 2020 09:02:50 +0000 Message-Id: <20201125090258.21457-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201125090258.21457-1-luca.boccassi@gmail.com> References: <20201117111416.1961049-42-luca.boccassi@gmail.com> <20201125090258.21457-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: revert setting MTU explicitly after configure' has been queued to stable release 19.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65 Thanks. Luca Boccassi --- >From bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 16 Nov 2020 19:03:54 +0000 Subject: [PATCH] app/testpmd: revert setting MTU explicitly after configure [ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ] Setting MTU after each 'rte_eth_dev_configure()' prevents using "--max-pkt-len=N" parameter and "port config all max-pkt-len #" command This is breaking DTS scatter test case which is using "--max-pkt-len=9000" testpmd parameter. Reverting workaround to recover the DTS testcase. Fixes: 1c21ee95cf52 ("app/testpmd: fix MTU after device configure") Signed-off-by: Ferruh Yigit Tested-by: Bo Chen --- app/test-pmd/testpmd.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 7b08bd2f59..8d3b7b2a3b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2334,8 +2334,6 @@ start_port(portid_t pid) } if (port->need_reconfig > 0) { - uint16_t mtu = RTE_ETHER_MTU; - port->need_reconfig = 0; if (flow_isolate_all) { @@ -2369,23 +2367,6 @@ start_port(portid_t pid) port->need_reconfig = 1; return -1; } - - /* - * Workaround for rte_eth_dev_configure(), max_rx_pkt_len - * set MTU wrong for the PMDs that have frame overhead - * bigger than RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN. - * For a PMD that has 26 bytes overhead, rte_eth_dev_configure() - * can set MTU to max 1492, not to expected 1500 bytes. - * Using rte_eth_dev_set_mtu() to be able to set MTU correctly, - * default MTU value is 1500. - */ - diag = rte_eth_dev_get_mtu(pi, &mtu); - if (diag) - printf("Failed to get MTU for port %d\n", pi); - diag = rte_eth_dev_set_mtu(pi, mtu); - if (diag != 0 && diag != -ENOTSUP) - printf("Failed to set MTU to %u for port %d\n", - mtu, pi); } if (port->need_reconfig_queues > 0) { port->need_reconfig_queues = 0; -- 2.27.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-11-24 16:50:36.909093974 +0000 +++ 0008-app-testpmd-revert-setting-MTU-explicitly-after-conf.patch 2020-11-24 16:50:36.565496231 +0000 @@ -1 +1 @@ -From 56f0534311d4c61c63e2455169749ae440278122 Mon Sep 17 00:00:00 2001 +From bdc1ebe7a0f4f8cd646f2f8e3851c1c5976aaa65 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 56f0534311d4c61c63e2455169749ae440278122 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 48e9647fc7..33fc0fddf5 100644 +index 7b08bd2f59..8d3b7b2a3b 100644 @@ -27 +28 @@ -@@ -2537,8 +2537,6 @@ start_port(portid_t pid) +@@ -2334,8 +2334,6 @@ start_port(portid_t pid) @@ -36 +37 @@ -@@ -2572,23 +2570,6 @@ start_port(portid_t pid) +@@ -2369,23 +2367,6 @@ start_port(portid_t pid)