From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA7A2A0545 for ; Wed, 25 Nov 2020 18:50:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9DA1C940; Wed, 25 Nov 2020 18:50:08 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id EA8B2C940 for ; Wed, 25 Nov 2020 18:50:07 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id s2so1464926plr.9 for ; Wed, 25 Nov 2020 09:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ayW1wghzA4cdBfAWNPeWf8WloO/EeOiKCqu9pncoT9c=; b=TWhMwm06VhB5m8r6Sp7CYzMQYTBxDFOB2cmvi4xDi64Rrry0bOAH/NOuFJvU1pKK5m 28H2Jk6Qza9do14g/M2j8bl0JdOEED+9pZCUcJHteSjisQ/hZ5nrFQwNPie1dIcQoRot /cRIFIO60HXrbR1Jt1G5m+6MdSKYq8Eedb+sKlva3EnkbKmS5eIQ3O55yubSh4Zm/FYK 7sWX5aZ3vRFmB8KAmm4v037trDgcyWwVJmKXZx9bA6RApF2LF5CwOS9DAo7yE4s4S7Qb jhj/Ms992lOUdoEXj4YL+mZC5AD1oAOPY6Ie9gfr2mHd0MlIqMBZTdYArlnuk/tejgie fSXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ayW1wghzA4cdBfAWNPeWf8WloO/EeOiKCqu9pncoT9c=; b=La/LFX/L+mjU4b4N3lvCqYWFoxEj2slGA0ts1/2rElRwT2BsKHRIpWL+7So/JCBROL 6xzN+Pw095lvAhyb8J/7a1zCb1AwNR0bGSCCQN7C9GlAARqeyeceyog3//nPGW7+YXx+ P43xWZ9N49CUfGbvVez4AQaid8gYLdEpxRW58bMdktYMz8uAJVWtc1FZegboe3NpPT/n fnHzdJZIrryfbQQmOMQHrDOTfcnJix2+U8qEGS5CNTLv16FW7bSeG8VvZS8ywOpW/+3n CFcnLLk5zj8/I2Av0u26ztVwh1MMJ5Twupeq5DQlABPqMm+eThMBmebHAZVH7b3rL+X3 2POQ== X-Gm-Message-State: AOAM531Fo28710ONJieakUH/0K9Fuk3+15w7kkHG3/GOizjm+dKUKaiS TK2J9yMZEamqiu3f1CH8h3KAiA== X-Google-Smtp-Source: ABdhPJxktU6FrmCfFjQDaMLLVhHmqyoauY+IJKJiCBAv3yoCPaKT+pkKsmaXcVzDpeCPtujIpwdHJQ== X-Received: by 2002:a17:902:8341:b029:d8:d123:2297 with SMTP id z1-20020a1709028341b02900d8d1232297mr3909437pln.65.1606326604986; Wed, 25 Nov 2020 09:50:04 -0800 (PST) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c19sm2551969pfp.1.2020.11.25.09.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Nov 2020 09:50:03 -0800 (PST) From: Stephen Hemminger To: ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com Cc: dev@dpdk.org, stable@dpdk.org, Stephen Hemminger , olivier.matz@6wind.com Date: Wed, 25 Nov 2020 09:49:51 -0800 Message-Id: <20201125174951.12198-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH] net/bnxt: don't fail rte_pmd_bnxt_set_all_queues_drop_en if no VF's X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" The function should return success if called with no active VF's. It is OK to call this function if the desired outcome is to change the flag for PF's even if there are no VF's. Original code may have worked by accidental uninitialized variable; then this bug was introduced by change to fix compilation warning. Fixes: 4a671fdea9f4 ("net/bnxt: fix compilation with -Og") Cc: olivier.matz@6wind.com Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/rte_pmd_bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index d67db46c65eb..6a236ff4803b 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.c +++ b/drivers/net/bnxt/rte_pmd_bnxt.c @@ -85,7 +85,7 @@ int rte_pmd_bnxt_set_all_queues_drop_en(uint16_t port, uint8_t on) struct rte_eth_dev *eth_dev; struct bnxt *bp; uint32_t i; - int rc = -EINVAL; + int rc; RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); @@ -118,6 +118,7 @@ int rte_pmd_bnxt_set_all_queues_drop_en(uint16_t port, uint8_t on) } /* Stall all active VFs */ + rc = 0; for (i = 0; i < bp->pf->active_vfs; i++) { rc = bnxt_hwrm_func_vf_vnic_query_and_config(bp, i, rte_pmd_bnxt_set_all_queues_drop_en_cb, &on, -- 2.27.0