From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EE43A09E9 for ; Tue, 8 Dec 2020 21:12:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 317D7C9DA; Tue, 8 Dec 2020 21:11:56 +0100 (CET) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id EE0A4C9A4 for ; Tue, 8 Dec 2020 21:11:50 +0100 (CET) Received: by mail-pf1-f194.google.com with SMTP id q22so14920301pfk.12 for ; Tue, 08 Dec 2020 12:11:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=KRZDJs+ASs1gH8vjG7pcnSTx4i7XxVmFr1s/NBOZ+UE=; b=EgUKflpkihFiVJOqxkQMXD7NLQ17xCKZA5fKJmAaX7a8Ngp3fNRzepFILG9C0h5Kj9 MKQ1lJYzNJQXD5LTL5KVSGjKSnuauk8TYcPcYIHE0KZx0JFVDN7P5WOSaLfkEMPjlVVU DF5QJ2yazKbp4SEVQH6bprtR2KYBXTK1oXCAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=KRZDJs+ASs1gH8vjG7pcnSTx4i7XxVmFr1s/NBOZ+UE=; b=NQdicthFIMdyw9nooH0KSMfx9PBHVa0gxraI32HDvf7wP2olRaO1d0CQAtKWoNTtOC 1tLkQ4czd19JbMgktgxYxueC0MNOgNUTqWR8Hyn6ACKHpb0LRnO9W8k9dIkUUgHnuVku NOxBU17saBFK/XI0HyoTPQCkiT6qyjfAYCvVBjs2vJhF6apthfKCMa6yhHjHY6kYy7Uw Y7SJTsJFE85xMhScRY60YpjgnlZ9KN+uz1c3fPfmNawi/tHYshFTe8+jhIVwPdPEUlda Fm8hqYdyH88x3UwjYeQEQGR26rfNXKxJ82A3ispiOdLJDE/UgqIuMYCdqYqHKLMjboqz px5w== X-Gm-Message-State: AOAM530CtSrFWdhTR2GUiXoSNNtW31DyDTcuN8E5tcWDCdGxmEFioUtN CEYczliSb6LCcIISa8ssStbVTggiOFx2bB+5pXyjHtlxQwh3YnLy5zP/gBDO2e2KHHsIkdIzgvV HxAuj0kCV X-Google-Smtp-Source: ABdhPJzirY5WbXQLiFT7AD896DotBF0yvteViHJIRqkbco0agvtdWs9k/JIYD8Jp2IxX1VRjVAMnoQ== X-Received: by 2002:a63:515f:: with SMTP id r31mr23845795pgl.200.1607458309174; Tue, 08 Dec 2020 12:11:49 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2020 12:11:48 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 8 Dec 2020 12:11:24 -0800 Message-Id: <20201208201134.47844-8-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201208201134.47844-1-ajit.khaparde@broadcom.com> References: <20201208201134.47844-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-stable] [PATCH 07/17] net/bnxt: fix cleanup on mutex init failure X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" In case mutex init fails during initialization, start cleanup and fail the initialization process. Fixes: a73b8e939f10 ("net/bnxt: fix race between start and interrupt handler") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 33358779b..0b14ca234 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4739,8 +4739,10 @@ bnxt_init_locks(struct bnxt *bp) } err = pthread_mutex_init(&bp->def_cp_lock, NULL); - if (err) + if (err) { PMD_DRV_LOG(ERR, "Unable to initialize def_cp_lock\n"); + return err; + } err = pthread_mutex_init(&bp->health_check_lock, NULL); if (err) -- 2.21.1 (Apple Git-122.3) -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.