patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-stable] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
Date: Thu, 7 Jan 2021 08:49:12 +0100
Message-ID: <20210107074912.GL2631@platinum> (raw)
In-Reply-To: <20210107013114.3477-1-ashish.sadanandan@gmail.com>

On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote:
> The header was missing the extern "C" directive which causes name
> mangling of functions by C++ compilers, leading to linker errors
> complaining of undefined references to these functions.
> 
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
> 
> Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48

I think this line can be dropped (it comes from gerrit).
David, can you do it when pushing the patch?

> Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks!

  reply	other threads:[~2021-01-07  7:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  1:31 Ashish Sadanandan
2021-01-07  7:49 ` Olivier Matz [this message]
2021-01-11 14:41   ` David Marchand
     [not found] <20201229194144.17824-1-ashish.sadanandan@gmail.com>
2021-01-07  1:38 ` Ashish Sadanandan
2021-01-07  6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107074912.GL2631@platinum \
    --to=olivier.matz@6wind.com \
    --cc=ashish.sadanandan@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git