patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ashish Sadanandan <ashish.sadanandan@gmail.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com,
	Ashish Sadanandan <ashish.sadanandan@gmail.com>,
	stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
Date: Thu,  7 Jan 2021 10:15:28 -0700	[thread overview]
Message-ID: <20210107171528.21074-1-ashish.sadanandan@gmail.com> (raw)
In-Reply-To: <20201229194144.17824-1-ashish.sadanandan@gmail.com>

The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.

Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org

 lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
  */
 
 #include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /**
  * Maximum length of the dynamic field or flag string.
  */
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
 __rte_experimental
 int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
 
+#ifdef __cplusplus
+}
 #endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
-- 
2.9.3


  parent reply	other threads:[~2021-01-07 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201229194144.17824-1-ashish.sadanandan@gmail.com>
2021-01-07  1:38 ` Ashish Sadanandan
2021-01-07  6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan [this message]
2021-01-07  1:31 Ashish Sadanandan
2021-01-07  7:49 ` Olivier Matz
2021-01-11 14:41   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107171528.21074-1-ashish.sadanandan@gmail.com \
    --to=ashish.sadanandan@gmail.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).