From: Bruce Richardson <bruce.richardson@intel.com>
To: Andrew Boyer <aboyer@pensando.io>
Cc: dev <dev@dpdk.org>,
thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option
Date: Mon, 11 Jan 2021 16:57:38 +0000 [thread overview]
Message-ID: <20210111165738.GA1083@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <0EF8D1A0-3838-442A-A4E9-006258035C34@pensando.io>
On Mon, Jan 11, 2021 at 11:19:26AM -0500, Andrew Boyer wrote:
>
>
> > On Jan 11, 2021, at 8:55 AM, Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> >
> > Rather than having the DPDK configuration error out when linking apps
> > and examples when "both" is select for "default_library" option, we can
> > detect that setting earlier in the build config and provide a suitable
> > error message to the user.
> >
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> ---
> > config/meson.build | 9 +++++++++ 1 file changed, 9 insertions(+)
> >
> > diff --git a/config/meson.build b/config/meson.build index
> > 3ddcc3539..05e9cede5 100644 --- a/config/meson.build +++
> > b/config/meson.build @@ -308,3 +308,12 @@ if get_option('b_lto')
> > add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
> > endif endif + +if get_option('default_library') == 'both' + error( '''
> > + Unsupported value "both" for "default_library" option. + +
> > NOTE: DPDK always builds both shared and static libraries. Please set
> > + "default_library" to either "static" or "shared" to select default
> > linkage + for apps and any examples''')
>
> Should there be a period after ‘examples’?
>
Yes, to have it a valid English sentence. If there are no other comments to
fix I'll not do a v2 for it alone, though - committers, feel free to add
one on apply.
/Bruce
next prev parent reply other threads:[~2021-01-11 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 13:55 Bruce Richardson
2021-01-11 16:19 ` Andrew Boyer
2021-01-11 16:57 ` Bruce Richardson [this message]
2021-01-20 0:49 ` Thomas Monjalon
2021-01-11 17:40 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111165738.GA1083@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aboyer@pensando.io \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).