From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CA98A0A03 for ; Thu, 14 Jan 2021 06:45:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85CDA140D38; Thu, 14 Jan 2021 06:45:52 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 7808E140D24; Thu, 14 Jan 2021 06:45:50 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id B132420B6C40; Wed, 13 Jan 2021 21:45:49 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B132420B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1610603149; bh=pE2El0faJQto4xA00N7DMBh9BcnieG1h6hX+0cRMgLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SKauK2EAC3jAoKVw1iG6r68REo5YTI0xIWqpWN7UJ+NHgGwlEDuF28cb+/ZuS+0Ut WalvC/tFwzG2Gfjf6jc4ed+21J8GYCNEzE3o/I9PhmCInXMaxvMWwCVGawvS5jiHeI /Ehi0x5tBbKwflsQvpBNdAjJg7Vj/BIijTe1VxTw= Date: Wed, 13 Jan 2021 21:45:49 -0800 From: Tyler Retzlaff To: Dmitry Kozlyuk Cc: dev@dpdk.org, navasile@linux.microsoft.com, stable@dpdk.org Message-ID: <20210114054549.GA27612@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1610414325-9104-1-git-send-email-roretzla@linux.microsoft.com> <20210113205255.6e865a04@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113205255.6e865a04@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-stable] [PATCH] eal/headers: explicitly cast void * to type * X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote: > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > > Explicitly cast void * to type * so that eal headers may be compiled > > as C or C++. > > Topic should probably be "eal/windows". i'll submit a new rev that changes this, it's not really windows specific but i guess windows is the only people crazy enough to use c++. > > Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") > Cc: stable@dpdk.org yep, will do thanks. > > > Signed-off-by: Tyler Retzlaff > > --- > [...] > > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h b/lib/librte_ethdev/rte_ethdev_pci.h > > index bf715896a..c20be29b1 100644 > > --- a/lib/librte_ethdev/rte_ethdev_pci.h > > +++ b/lib/librte_ethdev/rte_ethdev_pci.h > > @@ -47,7 +47,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, > > > > static inline int > > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) { > > - struct rte_pci_device *pci_dev = bus_device; > > + struct rte_pci_device *pci_dev = (struct rte_pci_device *)bus_device; > > > > if (!pci_dev) > > return -ENODEV; > > This is a private header, it's never exposed---why the change is needed (not > that I have a strong opinion, though)? interesting, i'll look into why/how it is being included and confirm. i suppose the question in the back of my mind is if it is private then why is the header being installed at all?