From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46D47A052A for ; Tue, 26 Jan 2021 10:52:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29742141302; Tue, 26 Jan 2021 10:52:32 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 250EB1412F3; Tue, 26 Jan 2021 10:52:26 +0100 (CET) IronPort-SDR: iZLpj9pPmxQntUmqKo3fMH8kzrGET2XCcry9eIlw7pMLMQ/LywglTymStW9Lji35qxg3Fxb2QM OrSuEjBrCNRA== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="241406013" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="241406013" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 01:52:23 -0800 IronPort-SDR: +thWOSYX+/B8Lv7hbWKSzyzmlHxY0sv/bNDcts2uZPvOXH/RVTLeGz/jO7Bar3lj+GBDz4DV8z K0uy3OZzAMuw== X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="361926641" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 01:52:21 -0800 From: dapengx.yu@intel.com To: beilei.xing@intel.com, jia.guo@intel.com Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Tue, 26 Jan 2021 17:52:11 +0800 Message-Id: <20210126095211.628354-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Dapeng Yu The original code causes wrong value to be set into PFQF_HENA register because unnecessary calling to get translated pctype value for X722 NIC. The result is RSS cannot work. So remove the unnecessary translation. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu --- drivers/net/i40e/i40e_hash.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index 9271797a7..b1cb24f43 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw, { uint32_t reg, reg_val, mask; - /* For X722, get translated pctype in fd pctype register */ - if (hw->mac.type == I40E_MAC_X722) - pctype = i40e_read_rx_ctl(hw, I40E_GLQF_FD_PCTYPES(pctype)); - if (pctype < 32) { mask = BIT(pctype); reg = I40E_PFQF_HENA(0); -- 2.27.0