patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2 1/5] net/ena: flush Rx buffers memory pool cache
       [not found] <20210126183226.2420903-1-mk@semihalf.com>
@ 2021-01-26 18:32 ` Michal Krawczyk
  2021-01-26 18:32 ` [dpdk-stable] [PATCH v2 2/5] net/ena: Tx doorbell statistics fix Michal Krawczyk
  1 sibling, 0 replies; 2+ messages in thread
From: Michal Krawczyk @ 2021-01-26 18:32 UTC (permalink / raw)
  To: dev; +Cc: gtzalik, igorch, mw, Ido Segev, stable, Michal Krawczyk

From: Ido Segev <idose@amazon.com>

As the refill called as part of ena_start(), we end up the refill
progress with stuck buffers at the caller core cache.

Calling to flush the cache results with invalidate this cache and free
those stuck buffers.

Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: stable@dpdk.org

Signed-off-by: Ido Segev <idose@amazon.com>
Reviewed-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 20ff3653c6..516e244295 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1246,6 +1246,10 @@ static int ena_queue_start(struct ena_ring *ring)
 		PMD_INIT_LOG(ERR, "Failed to populate rx ring !");
 		return ENA_COM_FAULT;
 	}
+	/* Flush per-core RX buffers pools cache as they can be used on other
+	 * cores as well.
+	 */
+	rte_mempool_cache_flush(NULL, ring->mb_pool);
 
 	return 0;
 }
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dpdk-stable] [PATCH v2 2/5] net/ena: Tx doorbell statistics fix
       [not found] <20210126183226.2420903-1-mk@semihalf.com>
  2021-01-26 18:32 ` [dpdk-stable] [PATCH v2 1/5] net/ena: flush Rx buffers memory pool cache Michal Krawczyk
@ 2021-01-26 18:32 ` Michal Krawczyk
  1 sibling, 0 replies; 2+ messages in thread
From: Michal Krawczyk @ 2021-01-26 18:32 UTC (permalink / raw)
  To: dev; +Cc: gtzalik, igorch, mw, Amit Bernstein, stable, Michal Krawczyk

From: Amit Bernstein <amitbern@amazon.com>

Increment Tx doorbell statistics on tx_pkt_burst
after writing to doorbell and in case max burst size achieved

Fixes: c7519ea5eb8d ("net/ena: call additional doorbells if needed")
Cc: stable@dpdk.org

Signed-off-by: Amit Bernstein <amitbern@amazon.com>
Reviewed-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 516e244295..111e830bfa 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2519,6 +2519,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)
 			"llq tx max burst size of queue %d achieved, writing doorbell to send burst\n",
 			tx_ring->id);
 		ena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);
+		tx_ring->tx_stats.doorbells++;
 	}
 
 	/* prepare the packet's descriptors to dma engine */
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-26 18:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210126183226.2420903-1-mk@semihalf.com>
2021-01-26 18:32 ` [dpdk-stable] [PATCH v2 1/5] net/ena: flush Rx buffers memory pool cache Michal Krawczyk
2021-01-26 18:32 ` [dpdk-stable] [PATCH v2 2/5] net/ena: Tx doorbell statistics fix Michal Krawczyk

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git