From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA8D2A0524 for ; Thu, 4 Feb 2021 12:38:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C418624079F; Thu, 4 Feb 2021 12:38:23 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id EE61524076C for ; Thu, 4 Feb 2021 12:38:20 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cxo-0005jf-Bf; Thu, 04 Feb 2021 11:38:20 +0000 From: Christian Ehrhardt To: Ashish Sadanandan Cc: Olivier Matz , dpdk stable Date: Thu, 4 Feb 2021 12:29:38 +0100 Message-Id: <20210204112954.2488123-123-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'mbuf: add C++ include guard for dynamic fields header' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/ce45afae63c3ac21c1159463a832d78442ac9407 Thanks. Christian Ehrhardt --- >From ce45afae63c3ac21c1159463a832d78442ac9407 Mon Sep 17 00:00:00 2001 From: Ashish Sadanandan Date: Wed, 6 Jan 2021 18:31:14 -0700 Subject: [PATCH] mbuf: add C++ include guard for dynamic fields header [ upstream commit 397fb6a8d96cf06fc83bd87cadf46d2226fc42ed ] The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Signed-off-by: Ashish Sadanandan Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h index f9f6dbbac8..638444724c 100644 --- a/lib/librte_mbuf/rte_mbuf_dyn.h +++ b/lib/librte_mbuf/rte_mbuf_dyn.h @@ -67,6 +67,11 @@ */ #include + +#ifdef __cplusplus +extern "C" { +#endif + /** * Maximum length of the dynamic field or flag string. */ @@ -250,4 +255,8 @@ void rte_mbuf_dyn_dump(FILE *out); #define RTE_MBUF_DYNFIELD_METADATA_NAME "rte_flow_dynfield_metadata" #define RTE_MBUF_DYNFLAG_METADATA_NAME "rte_flow_dynflag_metadata" +#ifdef __cplusplus +} #endif + +#endif /* _RTE_MBUF_DYN_H_ */ -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:33.054449081 +0100 +++ 0123-mbuf-add-C-include-guard-for-dynamic-fields-header.patch 2021-02-04 12:04:28.178789872 +0100 @@ -1 +1 @@ -From 397fb6a8d96cf06fc83bd87cadf46d2226fc42ed Mon Sep 17 00:00:00 2001 +From ce45afae63c3ac21c1159463a832d78442ac9407 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 397fb6a8d96cf06fc83bd87cadf46d2226fc42ed ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index d88e7bacc5..fc4eee71d0 100644 +index f9f6dbbac8..638444724c 100644 @@ -35,3 +36,3 @@ -@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag); - __rte_experimental - int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag); +@@ -250,4 +255,8 @@ void rte_mbuf_dyn_dump(FILE *out); + #define RTE_MBUF_DYNFIELD_METADATA_NAME "rte_flow_dynfield_metadata" + #define RTE_MBUF_DYNFLAG_METADATA_NAME "rte_flow_dynflag_metadata"