From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2912BA0524 for ; Thu, 4 Feb 2021 12:37:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2080424078B; Thu, 4 Feb 2021 12:37:01 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id CD1AA24074D for ; Thu, 4 Feb 2021 12:36:59 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cwV-0005XL-Kb; Thu, 04 Feb 2021 11:36:59 +0000 From: Christian Ehrhardt To: Bruce Richardson Cc: David Hunt , Anatoly Burakov , dpdk stable Date: Thu, 4 Feb 2021 12:29:03 +0100 Message-Id: <20210204112954.2488123-88-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'power: clean up includes' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/b086808ceed59989b5e7b83ce99c98719f45a6bf Thanks. Christian Ehrhardt --- >From b086808ceed59989b5e7b83ce99c98719f45a6bf Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 21 Jan 2021 17:22:01 +0000 Subject: [PATCH] power: clean up includes [ upstream commit 825fddf651d49b991a5a08eb02bab90695ec85c7 ] re-organise the including of the new public header file and remove un-needed includes Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Signed-off-by: Bruce Richardson Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.c | 1 - examples/vm_power_manager/channel_monitor.c | 1 - examples/vm_power_manager/channel_monitor.h | 3 ++- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 - examples/vm_power_manager/guest_cli/vm_power_cli_guest.h | 2 -- examples/vm_power_manager/vm_power_cli.c | 1 - lib/librte_power/guest_channel.c | 2 +- lib/librte_power/guest_channel.h | 2 -- lib/librte_power/power_kvm_vm.c | 2 +- lib/librte_power/rte_power.h | 1 + lib/librte_power/rte_power_guest_channel.h | 3 --- 11 files changed, 5 insertions(+), 14 deletions(-) diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c index c7d5bf5a87..0a28cb643b 100644 --- a/examples/vm_power_manager/channel_manager.c +++ b/examples/vm_power_manager/channel_manager.c @@ -27,7 +27,6 @@ #include #include "channel_manager.h" -#include "rte_power_guest_channel.h" #include "channel_monitor.h" #include "power_manager.h" diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c index 57a7155aad..fe5a183fd7 100644 --- a/examples/vm_power_manager/channel_monitor.c +++ b/examples/vm_power_manager/channel_monitor.c @@ -35,7 +35,6 @@ #include #include "channel_monitor.h" -#include "rte_power_guest_channel.h" #include "channel_manager.h" #include "power_manager.h" #include "oob_monitor.h" diff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h index 5d3537b911..2b38c554b5 100644 --- a/examples/vm_power_manager/channel_monitor.h +++ b/examples/vm_power_manager/channel_monitor.h @@ -5,8 +5,9 @@ #ifndef CHANNEL_MONITOR_H_ #define CHANNEL_MONITOR_H_ +#include + #include "channel_manager.h" -#include "rte_power_guest_channel.h" struct core_share { unsigned int pcpu; diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c index ceb59cad7b..1618030627 100644 --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c @@ -19,7 +19,6 @@ #include #include -#include #include "vm_power_cli_guest.h" diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h index 03af2cda7c..50c435544e 100644 --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.h @@ -9,8 +9,6 @@ extern "C" { #endif -#include "rte_power_guest_channel.h" - struct rte_power_channel_packet *get_policy(void); int set_policy_mac(int port, int idx); diff --git a/examples/vm_power_manager/vm_power_cli.c b/examples/vm_power_manager/vm_power_cli.c index 3df3626577..8eb87217e9 100644 --- a/examples/vm_power_manager/vm_power_cli.c +++ b/examples/vm_power_manager/vm_power_cli.c @@ -21,7 +21,6 @@ #include "channel_manager.h" #include "channel_monitor.h" #include "power_manager.h" -#include "rte_power_guest_channel.h" struct cmd_quit_result { cmdline_fixed_string_t quit; diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c index ff2ad38466..4dadf5ef9f 100644 --- a/lib/librte_power/guest_channel.c +++ b/lib/librte_power/guest_channel.c @@ -14,9 +14,9 @@ #include +#include #include "guest_channel.h" -#include "rte_power_guest_channel.h" #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1 diff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h index 756b16c91d..b790f3661a 100644 --- a/lib/librte_power/guest_channel.h +++ b/lib/librte_power/guest_channel.h @@ -8,8 +8,6 @@ extern "C" { #endif -#include - /** * Connect to the Virtio-Serial VM end-point located in path. It is * thread safe for unique lcore_ids. This function must be only called once from diff --git a/lib/librte_power/power_kvm_vm.c b/lib/librte_power/power_kvm_vm.c index 86a349f493..b34773d9c6 100644 --- a/lib/librte_power/power_kvm_vm.c +++ b/lib/librte_power/power_kvm_vm.c @@ -6,8 +6,8 @@ #include -#include "guest_channel.h" #include "rte_power_guest_channel.h" +#include "guest_channel.h" #include "power_kvm_vm.h" #include "power_common.h" diff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h index 427058b811..04dc4cb1da 100644 --- a/lib/librte_power/rte_power.h +++ b/lib/librte_power/rte_power.h @@ -14,6 +14,7 @@ #include #include #include +#include #ifdef __cplusplus extern "C" { diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h index b9273a025c..adc9738174 100644 --- a/lib/librte_power/rte_power_guest_channel.h +++ b/lib/librte_power/rte_power_guest_channel.h @@ -8,9 +8,6 @@ extern "C" { #endif -#include -#include - #define RTE_POWER_MAX_VFS 10 #define RTE_POWER_VM_MAX_NAME_SZ 32 #define RTE_POWER_MAX_VCPU_PER_VM 8 -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:31.682022905 +0100 +++ 0088-power-clean-up-includes.patch 2021-02-04 12:04:28.094789791 +0100 @@ -1 +1 @@ -From 825fddf651d49b991a5a08eb02bab90695ec85c7 Mon Sep 17 00:00:00 2001 +From b086808ceed59989b5e7b83ce99c98719f45a6bf Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 825fddf651d49b991a5a08eb02bab90695ec85c7 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -31 +32 @@ -index 58a243b230..458e371672 100644 +index c7d5bf5a87..0a28cb643b 100644 @@ -43 +44 @@ -index 7bb33e026c..99f81544d7 100644 +index 57a7155aad..fe5a183fd7 100644 @@ -70 +71 @@ -index ec6409abd7..0bf5774ffc 100644 +index ceb59cad7b..1618030627 100644 @@ -82 +83 @@ -index 5d285ca9de..b578ec0723 100644 +index 03af2cda7c..50c435544e 100644 @@ -95 +96 @@ -index f7e1b596ec..1a55e553b9 100644 +index 3df3626577..8eb87217e9 100644 @@ -107 +108 @@ -index 039cb18729..2f7507a03c 100644 +index ff2ad38466..4dadf5ef9f 100644 @@ -110 +111 @@ -@@ -15,9 +15,9 @@ +@@ -14,9 +14,9 @@ @@ -122 +123 @@ -index a1db4b0580..43d532a5aa 100644 +index 756b16c91d..b790f3661a 100644 @@ -132,2 +133,2 @@ - * Check if any Virtio-Serial VM end-points exist in path. - * + * Connect to the Virtio-Serial VM end-point located in path. It is + * thread safe for unique lcore_ids. This function must be only called once from @@ -135 +136 @@ -index 27f9937aab..ab7d4b8cee 100644 +index 86a349f493..b34773d9c6 100644 @@ -149 +150 @@ -index bbbde4dfb4..c8086bf6ba 100644 +index 427058b811..04dc4cb1da 100644