From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08436A0524 for ; Thu, 4 Feb 2021 12:37:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCC15240781; Thu, 4 Feb 2021 12:37:13 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by mails.dpdk.org (Postfix) with ESMTP id D7DBC240754 for ; Thu, 4 Feb 2021 12:37:11 +0100 (CET) Received: from 2.general.paelzer.uk.vpn ([10.172.196.173] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1l7cwh-0005e0-LX; Thu, 04 Feb 2021 11:37:11 +0000 From: Christian Ehrhardt To: Ciara Power Cc: Declan Doherty , Adam Dybkowski , dpdk stable Date: Thu, 4 Feb 2021 12:29:10 +0100 Message-Id: <20210204112954.2488123-95-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> References: <20210204112954.2488123-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/crypto-perf: fix CSV output format' has been queued to stable release 19.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/06/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/b23e86ea54fd71b1dfaef70c43d624a22a2f4c2d Thanks. Christian Ehrhardt --- >From b23e86ea54fd71b1dfaef70c43d624a22a2f4c2d Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Wed, 20 Jan 2021 17:29:29 +0000 Subject: [PATCH] app/crypto-perf: fix CSV output format [ upstream commit c6ddab873dbf066c40cd268a0216a913b1802b85 ] The csv output for each ptest type used ";" instead of ",". This has now been fixed to use the comma format that is used in the csv headers. Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Fixes: 96dfeb609be1 ("app/crypto-perf: add new PMD benchmarking mode") Fixes: da40ebd6d383 ("app/crypto-perf: display results in test runner") Signed-off-by: Ciara Power Acked-by: Declan Doherty Acked-by: Adam Dybkowski --- app/test-crypto-perf/cperf_test_latency.c | 2 +- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 2 +- app/test-crypto-perf/cperf_test_throughput.c | 4 ++-- app/test-crypto-perf/cperf_test_verify.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c index c3e006604b..951b4d10ac 100644 --- a/app/test-crypto-perf/cperf_test_latency.c +++ b/app/test-crypto-perf/cperf_test_latency.c @@ -317,7 +317,7 @@ cperf_latency_test_runner(void *arg) for (i = 0; i < ctx->options->total_ops; i++) { - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f", + printf("\n%u,%u,%u,%"PRIu64",%"PRIu64",%.3f", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, i + 1, ctx->res[i].tsc_end - ctx->res[i].tsc_start, diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c index 74371faa8d..de01e3bc51 100644 --- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c +++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c @@ -16,7 +16,7 @@ #define PRETTY_HDR_FMT "%12s%12s%12s%12s%12s%12s%12s%12s%12s%12s\n\n" #define PRETTY_LINE_FMT "%12u%12u%12u%12u%12u%12u%12u%12.0f%12.0f%12.0f\n" #define CSV_HDR_FMT "%s,%s,%s,%s,%s,%s,%s,%s,%s,%s\n" -#define CSV_LINE_FMT "%10u;%10u;%u;%u;%u;%u;%u;%.3f;%.3f;%.3f\n" +#define CSV_LINE_FMT "%10u,%10u,%u,%u,%u,%u,%u,%.3f,%.3f,%.3f\n" struct cperf_pmd_cyclecount_ctx { uint8_t dev_id; diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c index 35c51026fe..2528f39571 100644 --- a/app/test-crypto-perf/cperf_test_throughput.c +++ b/app/test-crypto-perf/cperf_test_throughput.c @@ -298,8 +298,8 @@ cperf_throughput_test_runner(void *test_ctx) "Failed Deq,Ops(Millions),Throughput(Gbps)," "Cycles/Buf\n\n"); - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" - "%.3f;%.3f;%.3f\n", + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," + "%.3f,%.3f,%.3f\n", ctx->lcore_id, ctx->options->test_buffer_size, test_burst_size, diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 833bc9a552..2939aeaa93 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -406,7 +406,7 @@ cperf_verify_test_runner(void *test_ctx) "Burst Size,Enqueued,Dequeued,Failed Enq," "Failed Deq,Failed Ops\n"); - printf("%10u;%10u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";" + printf("%10u,%10u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64"," "%"PRIu64"\n", ctx->lcore_id, ctx->options->max_buffer_size, -- 2.30.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-04 12:04:31.946677294 +0100 +++ 0095-app-crypto-perf-fix-CSV-output-format.patch 2021-02-04 12:04:28.098789794 +0100 @@ -1 +1 @@ -From c6ddab873dbf066c40cd268a0216a913b1802b85 Mon Sep 17 00:00:00 2001 +From b23e86ea54fd71b1dfaef70c43d624a22a2f4c2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c6ddab873dbf066c40cd268a0216a913b1802b85 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index c2590a4dcf..159fe8492b 100644 +index c3e006604b..951b4d10ac 100644 @@ -29 +30 @@ -@@ -314,7 +314,7 @@ cperf_latency_test_runner(void *arg) +@@ -317,7 +317,7 @@ cperf_latency_test_runner(void *arg) @@ -39 +40 @@ -index 4e67d3aebd..844659aeca 100644 +index 74371faa8d..de01e3bc51 100644 @@ -52 +53 @@ -index f30f7d5c2c..f6eb8cf259 100644 +index 35c51026fe..2528f39571 100644 @@ -55 +56 @@ -@@ -299,8 +299,8 @@ cperf_throughput_test_runner(void *test_ctx) +@@ -298,8 +298,8 @@ cperf_throughput_test_runner(void *test_ctx)