From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D79EA0524 for ; Fri, 5 Feb 2021 12:30:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69889188742; Fri, 5 Feb 2021 12:30:34 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id 6C043188945 for ; Fri, 5 Feb 2021 12:30:33 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id u14so5626958wmq.4 for ; Fri, 05 Feb 2021 03:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I9r82FhaDs734zkIxVNlOwS5rqjiG7WAZOR0fNS1I2Y=; b=EnqcmQylA1YAKpzy4kBxCsAzt44v2qNxTE018K7FFZEMw4/O7dUblY3iFHfVLEuSHB Qwt6QYizpKzCZOyP0nCTMRnjgjcz1pqGLDd4NpsNCKbIhMtj5hsmZT1Rr23HJKCcMbzD Qo4afJMGaC4frnD/VYsPRdUP3FSzKjQcbWf6I/qBBAN/KOrRvaAZSFQhXcsr+91jJphz W3mULTK+dpDoIJS1fqg0980CrIB5KZH7RX+uoOsWFKlH5KM/mg/MxEf5pv6DPJqysNAE /S+Ja8TTUpW+TMQq6oifrVlQaM77tCUPXBJOHBJg1ChDsE3F0JehnCNKVdDSUkiPJelh 29dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I9r82FhaDs734zkIxVNlOwS5rqjiG7WAZOR0fNS1I2Y=; b=PPzHy2MS7v6K+dk7o35E5ZJtiS01RQ/a+qaG5/LCP/WH4cFbA+rcf0cn/wIP4MZ9Fg nIF0j5ES1lCRh9e35ZsN9N8bKww4tNL1uaNp3h/JA/tLS8UAsCsvTDEB1cf1Z1hWGtyu FbOTPFJC0ZjMQszjjN7X2cNm1CIWBl2GBri/RFoJleASF5lq8jqBQGhTAT1SNhUnjTLB FC9aOiXgL61aE1QI5SWamQdVFpFMvO6e4L2LTvPw8QPVEwx8j1F5scL8G8Kj8F/TE5fn QG46VUNtrwEWteXS9s36y9Vrp0dvni6MOn3wO2wUEX7DUkJh62SXW9BS59WokR0yp09S +uaA== X-Gm-Message-State: AOAM530hIuzakSIBk1W8H0uQJQUyg84wr3tmhhiQ4HVhcB5YYE35DIfq 3mthwTjepzaQTx2BT7xbcpdh66TdRXMeG1+B X-Google-Smtp-Source: ABdhPJxwX3CXqz5HENXLL7H2BXSMtzMpsDbvMB7Zm5rhIOQHYVxVl2CNRFQxb4mBEgQ5qL5Ks9MrkA== X-Received: by 2002:a1c:9845:: with SMTP id a66mr3089772wme.121.1612524633178; Fri, 05 Feb 2021 03:30:33 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p5sm7797071wmq.3.2021.02.05.03.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:30:32 -0800 (PST) From: luca.boccassi@gmail.com To: Leyi Rong Cc: Qi Zhang , dpdk stable Date: Fri, 5 Feb 2021 11:16:30 +0000 Message-Id: <20210205111920.1272063-104-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ice: enlarge Rx queue rearm threshold to 64' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d2475d6fa474d8aff9cf26e442e0c90db7fcae4b Thanks. Luca Boccassi --- >From d2475d6fa474d8aff9cf26e442e0c90db7fcae4b Mon Sep 17 00:00:00 2001 From: Leyi Rong Date: Wed, 6 Jan 2021 13:35:48 +0800 Subject: [PATCH] net/ice: enlarge Rx queue rearm threshold to 64 [ upstream commit 295906ffaad9bd8e730248fb24be8fb437df1769 ] We observe performance drop on ice AVX512 data path after stop and start by using testpmd. As CPU polling is faster in AVX512 path, L3 contested accesses is intensified when rxrearm_start is a random value after testpmd stop/start. Enlarge ICE_RXQ_REARM_THRESH to 64 to ease the contested accesses and fix the performance drop issue. Signed-off-by: Leyi Rong Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h index 6b16716063..adfae016a9 100644 --- a/drivers/net/ice/ice_rxtx.h +++ b/drivers/net/ice/ice_rxtx.h @@ -31,7 +31,7 @@ #define ICE_VPMD_RX_BURST 32 #define ICE_VPMD_TX_BURST 32 -#define ICE_RXQ_REARM_THRESH 32 +#define ICE_RXQ_REARM_THRESH 64 #define ICE_MAX_RX_BURST ICE_RXQ_REARM_THRESH #define ICE_TX_MAX_FREE_BUF_SZ 64 #define ICE_DESCS_PER_LOOP 4 -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:33.911047106 +0000 +++ 0104-net-ice-enlarge-Rx-queue-rearm-threshold-to-64.patch 2021-02-05 11:18:28.954693930 +0000 @@ -1 +1 @@ -From 295906ffaad9bd8e730248fb24be8fb437df1769 Mon Sep 17 00:00:00 2001 +From d2475d6fa474d8aff9cf26e442e0c90db7fcae4b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 295906ffaad9bd8e730248fb24be8fb437df1769 ] + @@ -15,2 +16,0 @@ - -Cc: stable@dpdk.org