From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E120EA0524 for ; Fri, 5 Feb 2021 12:31:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB66940682; Fri, 5 Feb 2021 12:31:57 +0100 (CET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id C72681889FA for ; Fri, 5 Feb 2021 12:31:55 +0100 (CET) Received: by mail-wr1-f42.google.com with SMTP id q7so7244914wre.13 for ; Fri, 05 Feb 2021 03:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b14NQ1ToYODSPVKatZeCnXAPgxZPWpB/L92slns8JWQ=; b=cTPDEMcqpPd+nU1PBRqlyLdY2qnSb5e0JHoGx1TmfMYiWa7SCE6+2E5QMlnwy7oJVw VZInbPf3r46YXhaD6oyUqlSKKOF+6nuYx9SgBDAAOk1SZ1EBQkyDSj1nbQKNcDZzgFmv DV3UEjzsrdGrlI5ajktYqJXnty/h01CbH1oFgncSZ4tGk5deTjLv57INX2Z0PjBsrsev 5c2uDH2yBzYFiijXEmuQblivTlvqw17cQ/9e9rLsmzO0Aa0BqEpxJToqmZkwsU+vJOkE elCdCPfm3TWaGtx9Zap3fWpnZt9eA6XNI8LjJNu7U1ruGjznuerSzVEYazI3tOwtMaOE 6kQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b14NQ1ToYODSPVKatZeCnXAPgxZPWpB/L92slns8JWQ=; b=Tx3mgFspxTFeYioYMifcJu4EDlBF7JzzF+FvQqtD87O6zwzfi3bjpiD7/JxJ9QtwId ax+Vldu5eJ/O20oX5171X3R6ACCCtPittOgumghR+dUbJczAFm+6G5OVsRlC6Ee0YxMQ n92hr3Tcd0uy2xSfuQoFqFDZscBsn1FP/k6qzns5nOQgTetMn/CIOmaBDOjosfzZQg2h 6xc5axMynaZ4M5rd0TLE+EsVc2AqtPPSR7h3BxqfHZnale7YJbLk+v+hXimE9Ignsf9O h/s1GEAhMM36jqKAw+prybNR8ca1RiY73cwUAeVD67BcEM4Ws6TAtfIzwa2CGNdWuLZy LmSw== X-Gm-Message-State: AOAM533GEoLqjQDRV3aD2KnOc9MYj0F4dMPP+HUoqwM0RSjLrC0MXsJ+ A8LB3RTXBOsw/8+FLo1nAAKqpLH11gWDz07z X-Google-Smtp-Source: ABdhPJwzHTMUftE/53QscLRl1wtJGzRMPkb3Gu19ee0ABDj5TslBpNKqaL2biQm/DvJFjg7bFccGcg== X-Received: by 2002:a05:6000:41:: with SMTP id k1mr4475744wrx.386.1612524715604; Fri, 05 Feb 2021 03:31:55 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d9sm12342656wrq.74.2021.02.05.03.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:31:54 -0800 (PST) From: luca.boccassi@gmail.com To: Vladimir Medvedkin Cc: Arek Kusztal , Declan Doherty , dpdk stable Date: Fri, 5 Feb 2021 11:16:55 +0000 Message-Id: <20210205111920.1272063-129-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'crypto/qat: fix access to uninitialized variable' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/cf7cd53c7a3f988b47d529e212e18f9a547229ba Thanks. Luca Boccassi --- >From cf7cd53c7a3f988b47d529e212e18f9a547229ba Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Tue, 15 Dec 2020 18:23:51 +0000 Subject: [PATCH] crypto/qat: fix access to uninitialized variable [ upstream commit 87086b3398edf20d46628481a2959a40ad95b477 ] QAT_LOG() has access to the uninitialized variable "name" Fixes: 21792c443205 ("crypto/qat: add multi-process handling of driver ID") Signed-off-by: Vladimir Medvedkin Acked-by: Arek Kusztal Acked-by: Declan Doherty --- drivers/crypto/qat/qat_asym_pmd.c | 8 ++++---- drivers/crypto/qat/qat_sym_pmd.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c index ed8a2a50b4..a2c8aca2c1 100644 --- a/drivers/crypto/qat/qat_asym_pmd.c +++ b/drivers/crypto/qat/qat_asym_pmd.c @@ -251,6 +251,10 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev, struct rte_cryptodev *cryptodev; struct qat_asym_dev_private *internals; + snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", + qat_pci_dev->name, "asym"); + QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name); + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { qat_pci_dev->qat_asym_driver_id = qat_asym_driver_id; @@ -264,10 +268,6 @@ qat_asym_dev_create(struct qat_pci_device *qat_pci_dev, } } - snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", - qat_pci_dev->name, "asym"); - QAT_LOG(DEBUG, "Creating QAT ASYM device %s\n", name); - /* Populate subset device to use in cryptodev device creation */ qat_dev_instance->asym_rte_dev.driver = &cryptodev_qat_asym_driver; qat_dev_instance->asym_rte_dev.numa_node = diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c index 6da9512fe4..93666fdade 100644 --- a/drivers/crypto/qat/qat_sym_pmd.c +++ b/drivers/crypto/qat/qat_sym_pmd.c @@ -330,6 +330,10 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev, const struct rte_cryptodev_capabilities *capabilities; uint64_t capa_size; + snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", + qat_pci_dev->name, "sym"); + QAT_LOG(DEBUG, "Creating QAT SYM device %s", name); + /* * All processes must use same driver id so they can share sessions. * Store driver_id so we can validate that all processes have the same @@ -349,10 +353,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev, } } - snprintf(name, RTE_CRYPTODEV_NAME_MAX_LEN, "%s_%s", - qat_pci_dev->name, "sym"); - QAT_LOG(DEBUG, "Creating QAT SYM device %s", name); - /* Populate subset device to use in cryptodev device creation */ qat_dev_instance->sym_rte_dev.driver = &cryptodev_qat_sym_driver; qat_dev_instance->sym_rte_dev.numa_node = -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:34.951697273 +0000 +++ 0129-crypto-qat-fix-access-to-uninitialized-variable.patch 2021-02-05 11:18:29.002694843 +0000 @@ -1 +1 @@ -From 87086b3398edf20d46628481a2959a40ad95b477 Mon Sep 17 00:00:00 2001 +From cf7cd53c7a3f988b47d529e212e18f9a547229ba Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 87086b3398edf20d46628481a2959a40ad95b477 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org