From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC857A0524 for ; Fri, 5 Feb 2021 12:33:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B545140682; Fri, 5 Feb 2021 12:33:32 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 8D97C40682 for ; Fri, 5 Feb 2021 12:33:31 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id y187so5649565wmd.3 for ; Fri, 05 Feb 2021 03:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p5kipn1/VNkEFpIByKmBsbfj2drHTa2L/lTj8v4MYp8=; b=JmLCcijKsl+wQIPHGxlIJiLaihXiHF/19oKAuMBTFThKAkeBQ6/v+XNhd+zW9Y0NqK iMRd8sbgOnmOuwo2MDxzrmRVxcVG+aEkcwJ06lcXU34MHdYK5bxy1jcVsvHF95CaLLje 84Bl2NW2b1BdwXQSyJTD/I1nICSLFZNz5Mt2O057n068zB+mZOMST5gSs7WoY7A66y4O GPByIaPqWTdBcOR1Tz6GmLJyUrLxhT95XqFBOi9214Rlo1qaKscZy5BNZmAGYfY5EI8j 7M9TTL6JJTr8mPsUhFOI/I4ba4yeit7hiOWtbZpHo9QM4GydNxKxftHfdBLuGldd5JvO tgRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p5kipn1/VNkEFpIByKmBsbfj2drHTa2L/lTj8v4MYp8=; b=C3bz+J5JqXA6BTqG8WkaiEfHmEApO6eS378EluqLshpL8ZyRa/jRsFQB62/uPXoAo5 mdr2DlVc4yDEcZtgoRnoIBGeDGcE2GGKBCbJhl2EFLV014eE673wXmjQ0XGptb0JdWs2 vIWFV4kzACNSiGCvrJPS/B4kwic4Yhcn10tyr8psRj7z5xn7gkZ7OifXjSVVsDbvWX9r CzKRED8285078RMB31rcMdV/nifL7OlQODWUhjaUHMU+MVHWQSGDd4glisJel+sVjNFt 7rJTCeJGCf3Y9J/1IzjUEgUvIei1SBB4LqtMTqF3nVWr9cIOusjdiUTw92vRaFd0Kj5T g0Yg== X-Gm-Message-State: AOAM5333E2PvE0MUcEIHa2yK/YktriIrB4j0DDQ0MAOM/C/5TtsN05nP ZdXD/zzaj/SwI24L/Bx1DbcAwBpFKBgsz1ct X-Google-Smtp-Source: ABdhPJzRWXP+dTRYrCNRPGj9ApU25quUKiORuDqiO3hiGa1CNVhx1s0gU+3cvIkc+llZFu/Kpyrm3w== X-Received: by 2002:a1c:e255:: with SMTP id z82mr3164936wmg.93.1612524811298; Fri, 05 Feb 2021 03:33:31 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id l2sm8413098wmq.17.2021.02.05.03.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:33:30 -0800 (PST) From: luca.boccassi@gmail.com To: Steve Yang Cc: Ferruh Yigit , dpdk stable Date: Fri, 5 Feb 2021 11:17:22 +0000 Message-Id: <20210205111920.1272063-156-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/sfc: fix jumbo frame flag condition for MTU set' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b026826262e2f2ac49bd7bde50b41aad80482b5f Thanks. Luca Boccassi --- >From b026826262e2f2ac49bd7bde50b41aad80482b5f Mon Sep 17 00:00:00 2001 From: Steve Yang Date: Mon, 18 Jan 2021 07:04:20 +0000 Subject: [PATCH] net/sfc: fix jumbo frame flag condition for MTU set [ upstream commit 7910fd21211f402aac7b7e7d4b6d70f224f0f9be ] The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but the Ether overhead is larger than 18 when it supports VLAN tag. That will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU', that perhaps impacts the cases of the jumbo frame related. Fixes: ff6a1197c3b1 ("net/sfc: convert to new Rx offload API") Signed-off-by: Steve Yang Reviewed-by: Ferruh Yigit --- drivers/net/sfc/sfc_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 93fc7baa0d..f2f5336435 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1017,7 +1017,7 @@ sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) * The driver does not use it, but other PMDs update jumbo frame * flag and max_rx_pkt_len when MTU is set. */ - if (mtu > RTE_ETHER_MAX_LEN) { + if (mtu > RTE_ETHER_MTU) { struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; rxmode->offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; } -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:36.287271907 +0000 +++ 0156-net-sfc-fix-jumbo-frame-flag-condition-for-MTU-set.patch 2021-02-05 11:18:29.094696595 +0000 @@ -1 +1 @@ -From 7910fd21211f402aac7b7e7d4b6d70f224f0f9be Mon Sep 17 00:00:00 2001 +From b026826262e2f2ac49bd7bde50b41aad80482b5f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7910fd21211f402aac7b7e7d4b6d70f224f0f9be ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org