From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC70CA0524 for ; Fri, 5 Feb 2021 12:33:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A67FD40682; Fri, 5 Feb 2021 12:33:51 +0100 (CET) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id 404EC188A0E for ; Fri, 5 Feb 2021 12:33:50 +0100 (CET) Received: by mail-wr1-f47.google.com with SMTP id l12so7346209wry.2 for ; Fri, 05 Feb 2021 03:33:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NTBmtw2fxD4UDyUXNFfngJyyB7I6QVqcFAyZFFby81E=; b=YiFVXJrjb5Ueu6gwxkhaSjQ9N/gyptYCbHTLXQkUBvJt/LIOVNkEd8wmAunoSsD1EV KQGDzpce/tiZ+Kc2qxC4mCUUFfqPzIH24CXJun2xYiIaJ3ncBCGOBf0ki3psrWzp/zrj VOR3g/hvCaAWc2ztUWXUwE2m1LzVyMk/H5LfWRyG0V/w1vEe4IrxiYkwdKT8gZCJbMcn 3QJRc4PaEo96V9k0+dFBTH2XlOrM3G5z8ORl0vtS4rAGqUCMOancp5o2NPhv+C5t+d4y UKOlFOS/QNTbGcHNT8QQNaVh9HPtYpkQfd70/ho+N5pfsdB2vLrDlbULcCO7fb2l+yh1 4ApA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NTBmtw2fxD4UDyUXNFfngJyyB7I6QVqcFAyZFFby81E=; b=qgx2LlfohXwaw2TsRFgnJp2ypc79OetaUm3v3HN0lxore70vE01w2TgElzYBVUJ+XH /8QUo5yHVh5Tq+R6sqq5q6SzNh2B6etEZ1pNlhq/mxxMiw9CP8pjbxxSzlkCRdQpYU6e F+7PYrzho9hiwmCVP4vljFp3v3PU04VHWnd58Ou9ZshQVNXDVTKFgkn/gQ9ocC7HGk71 WJjw6+5Srn0bJt9+QFgwm2Xf1VESWZX40wAbKpNNfbsA5bh/TeZb3FwkPOvfsXVKQ5dj MNCLCXErDHkkKbGBZ/sh/nveFBRoAHAErkCO7dRwYwnxENwu/nviBXNnadVpZyHviLys 89+g== X-Gm-Message-State: AOAM530rL8v3aUcArA9c/B5QEKE8CbeQq2ZwrkL0drt/sBzN/AadL9dC JdLtyxwQvvTpAOfiFvCXTYo= X-Google-Smtp-Source: ABdhPJyGj7w/nMCjhpzBj92MQ92ttT5YOnE/hzdU8exk250wfl5uFXqyQRrxmRxNomcmHSgiMnD0rg== X-Received: by 2002:a5d:5384:: with SMTP id d4mr4353095wrv.177.1612524830024; Fri, 05 Feb 2021 03:33:50 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 62sm8858474wmd.34.2021.02.05.03.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:33:49 -0800 (PST) From: luca.boccassi@gmail.com To: Steve Yang Cc: Ferruh Yigit , dpdk stable Date: Fri, 5 Feb 2021 11:17:29 +0000 Message-Id: <20210205111920.1272063-163-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/nfp: fix jumbo frame flag condition for MTU set' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/102de11806c224ac90f65892d6f93cb3e551105a Thanks. Luca Boccassi --- >From 102de11806c224ac90f65892d6f93cb3e551105a Mon Sep 17 00:00:00 2001 From: Steve Yang Date: Mon, 18 Jan 2021 07:04:27 +0000 Subject: [PATCH] net/nfp: fix jumbo frame flag condition for MTU set [ upstream commit a36974f43c69f7a714ffec237461854ae924ce29 ] The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition. If the Ether overhead is larger than 18 when it supports VLAN tag, that will cause the jumbo flag rx offload is wrong when MTU size is 'RTE_ETHER_MTU'. This fix will change the boundary condition with 'RTE_ETHER_MTU', that perhaps impacts the cases of the jumbo frame related. Fixes: d4a27a3b092a ("nfp: add basic features") Signed-off-by: Steve Yang Reviewed-by: Ferruh Yigit --- drivers/net/nfp/nfp_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 1608bf5ea1..9ea24e5bda 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -1508,7 +1508,7 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) } /* switch to jumbo mode if needed */ - if ((uint32_t)mtu > RTE_ETHER_MAX_LEN) + if ((uint32_t)mtu > RTE_ETHER_MTU) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; else dev->data->dev_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:36.584899541 +0000 +++ 0163-net-nfp-fix-jumbo-frame-flag-condition-for-MTU-set.patch 2021-02-05 11:18:29.114696976 +0000 @@ -1 +1 @@ -From a36974f43c69f7a714ffec237461854ae924ce29 Mon Sep 17 00:00:00 2001 +From 102de11806c224ac90f65892d6f93cb3e551105a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a36974f43c69f7a714ffec237461854ae924ce29 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org