From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C031A0524 for ; Fri, 5 Feb 2021 12:34:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 110CF188A15; Fri, 5 Feb 2021 12:34:05 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id B75BF40682 for ; Fri, 5 Feb 2021 12:34:03 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id p15so7274097wrq.8 for ; Fri, 05 Feb 2021 03:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fY97Mpb/6qchENxWKYJ5ZCrisygYcnZ0BsLYJo/Nnqk=; b=GPsqPWpFacw+VB+vIMkiUUF/CewhTTzi+8PoRETH8KfchaZb9Gujk/pjGAbljnCVt/ 9sjg18p2ICE9uK6ZQ/KIKyC1FlFNP6aeOkMXdKql4siYo86DG/29QHoaU7XfZastVULA tujtP1MVbJnksKbJVyvSRC+XUbJNxxK61n17uinTcMFeKQev7C7jS69vxWz7i3EF8tTi 1XjNPwNU1ee5i/lNBE0QFzbMDnSq9qkCAV+Z8FR9lVK9u2NDaRiLZ/aNky4X2k2f9zsA FiGZLcW4vh+AtM2mq3iIK1/W3+zMw2oqUUOyQwvzi4aFeQZuv3be8r18nti7kXxdiYqw /yaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fY97Mpb/6qchENxWKYJ5ZCrisygYcnZ0BsLYJo/Nnqk=; b=cn94/jy+9zmZMo9ZrvIrzvMqXOytKWs00VTvHAueXJ/PRyz0MgvguSKqknK6zRAXAV qheonoQIqut0mNoyLArGKZkFsXBArp/xSKm00mg/pTtQTv8BBI8pHvTjUcYJ8+TT6ORm M6PfVNehlNe8j/UpdjqmHEMjXEhrdTfDrUUqtRIVuvHQcLtozNayIn9dtPLtDOOwWZjh Os2K+ONmCIuJf1vqZ/gHV1w2b0qRovVyx7WMFhNqxOF+bNtBAxNotwGOISQP5KIZ93D4 Od9ZdUSN5oWd59WsNm/FWnuUuPh1/S9RUYS5YjQRNElOZUG0pv6esa/elouexEmuwIUl i1EA== X-Gm-Message-State: AOAM530qIbO+/SM58vOrt9WUptNXuOLGLVh+TdYWgsCEu/Ll8ud5tQ/3 TiGaMA8/jiUFnKlU/qG24xA= X-Google-Smtp-Source: ABdhPJyUWYpYlLQACgEY1q38nu/GlqO9dNMjG9BBdZf8jKEKf1A+wW9OWSDKHeqx1NUUgtd/+d12Jw== X-Received: by 2002:adf:800b:: with SMTP id 11mr3168360wrk.322.1612524843562; Fri, 05 Feb 2021 03:34:03 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id i7sm11982156wru.49.2021.02.05.03.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:34:02 -0800 (PST) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Ciara Power , Thomas Monjalon , dpdk stable Date: Fri, 5 Feb 2021 11:17:32 +0000 Message-Id: <20210205111920.1272063-166-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'ethdev: avoid blocking telemetry for link status' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/7cef99775d947c9b34c5d62df62374e3cdf2fc0d Thanks. Luca Boccassi --- >From 7cef99775d947c9b34c5d62df62374e3cdf2fc0d Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 14 Jan 2021 12:17:33 +0000 Subject: [PATCH] ethdev: avoid blocking telemetry for link status [ upstream commit 26fe208ad81fc7439728d743bccd4b2a32701bfe ] When querying the link status via telemetry interface, we don't want the client to have to wait for multiple seconds for a reply. Therefore use "rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry callback. Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") Signed-off-by: Bruce Richardson Acked-by: Ciara Power Acked-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 71e1e9a6db..8c584e4c83 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -5711,7 +5711,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused, if (!rte_eth_dev_is_valid_port(port_id)) return -1; - ret = rte_eth_link_get(port_id, &link); + ret = rte_eth_link_get_nowait(port_id, &link); if (ret < 0) return -1; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:36.700173021 +0000 +++ 0166-ethdev-avoid-blocking-telemetry-for-link-status.patch 2021-02-05 11:18:29.122697128 +0000 @@ -1 +1 @@ -From 26fe208ad81fc7439728d743bccd4b2a32701bfe Mon Sep 17 00:00:00 2001 +From 7cef99775d947c9b34c5d62df62374e3cdf2fc0d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 26fe208ad81fc7439728d743bccd4b2a32701bfe ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 9fe1c9d769..daf5f24f7e 100644 +index 71e1e9a6db..8c584e4c83 100644 @@ -25 +26 @@ -@@ -5739,7 +5739,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused, +@@ -5711,7 +5711,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,