From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63A35A0524 for ; Fri, 5 Feb 2021 12:36:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A265188A30; Fri, 5 Feb 2021 12:36:19 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 746861889FD for ; Fri, 5 Feb 2021 12:36:17 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id l12so7354064wry.2 for ; Fri, 05 Feb 2021 03:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vXFY2edIPiipm7YO/1/2HOKGut5003CylZHy+EGD1+U=; b=pqUJMsl/vfToa2DZheGFRBz4iFsC7yV4tDrV+yFdsKGt9B/GwLuZygUM7s5d/zagcQ smrvzZN5HIh+cHCiDYQdHI/cBVlYUfVXe6Kxo3mMmPQN88YX+t6BDYTBUYo2IGV8p3fJ gn6q5qPf8t4QgpLInC9MO2EVxzUDObjduFmdfc7Ad3jx+MGboSUlNKxwtuM5AAXzjUrs QK8T7wAKzc67kz4MGzSN14TihIq0eTirzvkxbgkphsKJ/12kHpNlrTmc9X7S/K2X+Q20 3gKu89mpSUI6oTAiZLTLdorAu4owkDbCMpVd8gA0Zwm9XwqOIeLHpRq9S8qbV7R6F/+6 aUjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vXFY2edIPiipm7YO/1/2HOKGut5003CylZHy+EGD1+U=; b=HXh/P24+U2rZHFX8fc+RZB+yfh/7l3pwBzy5cDW0QUNx6ahx0FDkrIUA/O697MMfBd kFEH8jj5I6peUzfVNkirl0l1fI/lrSbKHnxi6HkW7kEPbmGmSNUp2y6l0Aja9I/Ano6E nHor5vEgHyVMZ+FxGj5Dsz52CH5VDPtaxkhccybrqVgugKQM3iP2amOQZbNArHRtsQlu mRSgGWZhFOAKdrYafxAluN7GvAWiq2Wmdai2Jw0ANJOvOksFPzP/3m5AQf5+M66GxX4g 7AbnqyLZrS9bgfG4nx8zcrRlT2bl/gfFDFWFf2ujnXZ74eXjDNbjMXY6lz039fiiUlki YjJA== X-Gm-Message-State: AOAM533D8k828aLV5+JJmJrZbHHYNuFLfH83tu0Iskp0ZqJ7IdogRjXU qIZwpOPK/XYfgPrnn6f5Im0= X-Google-Smtp-Source: ABdhPJxwkVhahNUjwUZgmxITEIAJp9T22xqpYFDuaiSsdrQYFqhVyRfcEp+0c1yoZ0CnVDmXCZ9eQg== X-Received: by 2002:a05:6000:1788:: with SMTP id e8mr4566887wrg.171.1612524977281; Fri, 05 Feb 2021 03:36:17 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a21sm4209556wmb.5.2021.02.05.03.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:36:16 -0800 (PST) From: luca.boccassi@gmail.com To: Feifei Wang Cc: Ruifeng Wang , Jerin Jacob , dpdk stable Date: Fri, 5 Feb 2021 11:18:14 +0000 Message-Id: <20210205111920.1272063-208-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/eventdev: remove redundant enqueue in burst Tx' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/4f4f0b0747f74ce01e485d918cc265fa57c838a9 Thanks. Luca Boccassi --- >From 4f4f0b0747f74ce01e485d918cc265fa57c838a9 Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Fri, 22 Jan 2021 13:19:16 +0800 Subject: [PATCH] app/eventdev: remove redundant enqueue in burst Tx [ upstream commit 21b1ca4843a09d822cf992872445beb73163f1fb ] For eventdev pipeline test, in burst_tx cases, there is no needed to set ev.op as RTE_EVENT_OP_RELEASE and call pipeline_event_enqueue_burst to release events. This is because for tx mode(internal_port=true), the capability "implicit_release" of dev is enabled, and the app can release events by "rte_event_dequeue_burst" rather than enqueue. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_queue.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-eventdev/test_pipeline_queue.c b/app/test-eventdev/test_pipeline_queue.c index 01f33e3b44..9a9febb199 100644 --- a/app/test-eventdev/test_pipeline_queue.c +++ b/app/test-eventdev/test_pipeline_queue.c @@ -83,16 +83,15 @@ pipeline_queue_worker_single_stage_burst_tx(void *arg) rte_prefetch0(ev[i + 1].mbuf); if (ev[i].sched_type == RTE_SCHED_TYPE_ATOMIC) { pipeline_event_tx(dev, port, &ev[i]); - ev[i].op = RTE_EVENT_OP_RELEASE; w->processed_pkts++; } else { ev[i].queue_id++; pipeline_fwd_event(&ev[i], RTE_SCHED_TYPE_ATOMIC); + pipeline_event_enqueue_burst(dev, port, ev, + nb_rx); } } - - pipeline_event_enqueue_burst(dev, port, ev, nb_rx); } return 0; @@ -213,7 +212,6 @@ pipeline_queue_worker_multi_stage_burst_tx(void *arg) if (ev[i].queue_id == tx_queue[ev[i].mbuf->port]) { pipeline_event_tx(dev, port, &ev[i]); - ev[i].op = RTE_EVENT_OP_RELEASE; w->processed_pkts++; continue; } @@ -222,9 +220,8 @@ pipeline_queue_worker_multi_stage_burst_tx(void *arg) pipeline_fwd_event(&ev[i], cq_id != last_queue ? sched_type_list[cq_id] : RTE_SCHED_TYPE_ATOMIC); + pipeline_event_enqueue_burst(dev, port, ev, nb_rx); } - - pipeline_event_enqueue_burst(dev, port, ev, nb_rx); } return 0; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:38.426310173 +0000 +++ 0208-app-eventdev-remove-redundant-enqueue-in-burst-Tx.patch 2021-02-05 11:18:29.166697965 +0000 @@ -1 +1 @@ -From 21b1ca4843a09d822cf992872445beb73163f1fb Mon Sep 17 00:00:00 2001 +From 4f4f0b0747f74ce01e485d918cc265fa57c838a9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 21b1ca4843a09d822cf992872445beb73163f1fb ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org