From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12CAEA0524 for ; Fri, 5 Feb 2021 12:36:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A1D61889F7; Fri, 5 Feb 2021 12:36:34 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 81B804067B for ; Fri, 5 Feb 2021 12:36:32 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id p15so7282250wrq.8 for ; Fri, 05 Feb 2021 03:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dVFhsk7oYgtOOaTtgFAeGzd+CTw/D5q49gEH5LLd73E=; b=XSXS4zxd8TuSApcYnIjd7jDvdTmYDnOix2RNipxdcrd4xaNPw0LFYel9umvXHRFRKT pz1m9SXK4O+sFovp2bR2iq/KLr/hJefoOTk5Lo+Ih/SbJw1m5yBnmjoRSx9thgS0qfqc t4zWprY2TSaOMZiV4y0JUwXkJPcqYmmRR13n0QWjMuDUIPmNAcIU5+TpH4+3npqfQmwk Pf4Nms7NQVtkAqwRACTP8+0Vrn7P3mIoZ+BeUdGdA8n9vf63OQiMmLSQNKuuIUyKEOqH LhChjkN3AZm8TGu3bIwkE0cn9W/GPIWGIl+Ihhlrkmly+kiKDaxj/n+z2e7BjqN6XfJF Tyeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dVFhsk7oYgtOOaTtgFAeGzd+CTw/D5q49gEH5LLd73E=; b=IjR2dtg7MDD4B4IitWUsIdx2iROVRT6f7l0MEGs/YzvXCd2vBBAaCcZIU8oW5KNnAc Ispu05svlq2JbRuTFufeCmGyB4mmO+EskiwABE+jL4+m/VNjPr08flNfxPCDGI0cHn2P R6LmvuLnK323a/L67X1Mpp6buJixY5Suh1tug7dGO+mBZa72XHb9iCzGFPJCX1EyTcK3 V4Xwidz1jXTOz5CGkz0qsGKNcrA3RfOgdXdF3C3QA6BQEsySdxWdx2zP0hFMiR5TPEEX oGrJKk9Hq5cRd+KE6ufHMEwGHDZzu1VI83+q9IVKnSYBeZG950VAvqtX9HKVGUy4wP8K Quxw== X-Gm-Message-State: AOAM530iP0UGzK7KzzIlHAt1K1MRfYRJnmiw4T92GqDWl1GD2zGeKLgr wH5QMkvvEAXW5BvKXJsnsRSzwN6M/mR2LzoQ X-Google-Smtp-Source: ABdhPJxMdue5/rtsimWcx2Ra0wKy4RfcQ9/az3D5SA2l9fkVg9QL5KxoIvpSlx5qM5Q/xA2ytGsm9g== X-Received: by 2002:adf:cd83:: with SMTP id q3mr4528314wrj.225.1612524992349; Fri, 05 Feb 2021 03:36:32 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s23sm8437143wmc.35.2021.02.05.03.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:36:31 -0800 (PST) From: luca.boccassi@gmail.com To: Feifei Wang Cc: Ruifeng Wang , Pavan Nikhilesh , dpdk stable Date: Fri, 5 Feb 2021 11:18:18 +0000 Message-Id: <20210205111920.1272063-212-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/eventdev: fix SMP barrier in performance test' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/75c9f3fea781fcf1c436e1efc19952827fb18462 Thanks. Luca Boccassi --- >From 75c9f3fea781fcf1c436e1efc19952827fb18462 Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Thu, 14 Jan 2021 15:08:26 +0800 Subject: [PATCH] app/eventdev: fix SMP barrier in performance test [ upstream commit c7c033d173f2d4f14834c0fb942b84725ac940e8 ] This patch fixes RTE SMP barrier bugs for the perf test of eventdev. For the "perf_process_last_stage" function, wmb after storing processed_pkts should be moved before it. This is because the worker lcore should ensure it has really finished data processing, e.g. event stored into buffers, before the shared variables "w->processed_pkts"are stored. For the "perf_process_last_stage_latency", on the one hand, the wmb should be moved before storing into "w->processed_pkts". The reason is the same as above. But on the other hand, for "w->latency", wmb is unnecessary due to data dependency. Fixes: 2369f73329f8 ("app/testeventdev: add perf queue worker functions") Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.h | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/test-eventdev/test_perf_common.h b/app/test-eventdev/test_perf_common.h index ff9705df88..e7233e5a5b 100644 --- a/app/test-eventdev/test_perf_common.h +++ b/app/test-eventdev/test_perf_common.h @@ -97,8 +97,13 @@ perf_process_last_stage(struct rte_mempool *const pool, void *bufs[], int const buf_sz, uint8_t count) { bufs[count++] = ev->event_ptr; - w->processed_pkts++; + + /* wmb here ensures event_prt is stored before + * updating the number of processed packets + * for worker lcores + */ rte_smp_wmb(); + w->processed_pkts++; if (unlikely(count == buf_sz)) { count = 0; @@ -116,6 +121,12 @@ perf_process_last_stage_latency(struct rte_mempool *const pool, struct perf_elt *const m = ev->event_ptr; bufs[count++] = ev->event_ptr; + + /* wmb here ensures event_prt is stored before + * updating the number of processed packets + * for worker lcores + */ + rte_smp_wmb(); w->processed_pkts++; if (unlikely(count == buf_sz)) { @@ -127,7 +138,6 @@ perf_process_last_stage_latency(struct rte_mempool *const pool, } w->latency += latency; - rte_smp_wmb(); return count; } -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:38.575772884 +0000 +++ 0212-app-eventdev-fix-SMP-barrier-in-performance-test.patch 2021-02-05 11:18:29.170698042 +0000 @@ -1 +1 @@ -From c7c033d173f2d4f14834c0fb942b84725ac940e8 Mon Sep 17 00:00:00 2001 +From 75c9f3fea781fcf1c436e1efc19952827fb18462 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c7c033d173f2d4f14834c0fb942b84725ac940e8 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org