From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3D62A0524 for ; Fri, 5 Feb 2021 12:39:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE2DE188A68; Fri, 5 Feb 2021 12:39:35 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id A66FC4067B for ; Fri, 5 Feb 2021 12:39:34 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id y187so5663698wmd.3 for ; Fri, 05 Feb 2021 03:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fnYWSVoqwiGddD+2PtjsGSo8Rpsm+ccweNvINONtnmw=; b=iDSojvVDU1CqOfVVwKSUQgm3wUMIeVHuwUndgUERKn7R6SX0uY0tl2zEN7XEpOHEd6 hviMowoGybs683sMFidEBkqDoBF9S89H5YD9FwWlWg/mP8gU5oQb8p5gTvXGk7oaQZQg Gpu61henPV9AoXrc0q8su5ABspcPMVs8H6EZtjgj+00I/ToGL0ilz73kvYylvAOCbE3X CaPsAJSSDbtGqh+hkBxRxkPrYWXLrrEhyrIeaK9BnCIhnlJInW4h7zHgH248As114wj8 L+YrTQMRrw2ezwWc/p3TCfyzFT6p3cLbeyGTyYxEFqXezqlNwk8ZVYELUrFcjGLNbHCf fY7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fnYWSVoqwiGddD+2PtjsGSo8Rpsm+ccweNvINONtnmw=; b=mTCGoKWelgtEOW3gvDuVFQp8aFThIK+vzJeCmpgWSvqChYIbsoWGpUPJachkwqqZQT PBUY37BfYZtG1wgFNzJ66hqRXskjSdm5Cl4DTep963Z5xdHgaEYOqM+kAVgjAKaero9S +uPTi5YBVpReDtgsTjbtVZsc4pLQVEkLpGhk6grLPOR2817fRV4mzBdF8QhbUS75pK7a wRrYUF8VjOtCtWhN18E+OM3Odgl2F/k+P9a4pbvv0zB//2byDAq46ksktQUmkDbFi2Hs YCViO/YFiQ4dA2nZcBurkmYpdXxAskMba+eOw+HtOBmNmNbkR4RA8LWeghTSJUO+gvab 0owQ== X-Gm-Message-State: AOAM533LHLxI8I8As9GYCOT9KVefq6VYveJ3jHfLIH093okdEVa59C6H RCNF3aQdMDb+Vxy+F6zXRnLoA148RTL0CdJD X-Google-Smtp-Source: ABdhPJyBacxUsP1ngXL0dqRRN6SYJRQf3zQCBxhd8VOaT8pdtWpvQWCIdGnJ5pzg7BzaJHoSf9IM4Q== X-Received: by 2002:a7b:c397:: with SMTP id s23mr3236879wmj.123.1612525174475; Fri, 05 Feb 2021 03:39:34 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id y6sm8772432wma.19.2021.02.05.03.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:39:33 -0800 (PST) From: luca.boccassi@gmail.com To: Ido Segev Cc: Michal Krawczyk , Igor Chauskin , dpdk stable Date: Fri, 5 Feb 2021 11:19:14 +0000 Message-Id: <20210205111920.1272063-268-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ena: flush Rx buffers memory pool cache' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0a6b9a2e34ae99a1df902542b05d4f3263bf0806 Thanks. Luca Boccassi --- >From 0a6b9a2e34ae99a1df902542b05d4f3263bf0806 Mon Sep 17 00:00:00 2001 From: Ido Segev Date: Tue, 26 Jan 2021 19:32:22 +0100 Subject: [PATCH] net/ena: flush Rx buffers memory pool cache [ upstream commit 4387e81c94f4702ec2eb2037df2bfa19927309d7 ] As the refill called as part of ena_start(), we end up the refill progress with stuck buffers at the caller core cache. Calling to flush the cache results with invalidate this cache and free those stuck buffers. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Signed-off-by: Ido Segev Reviewed-by: Michal Krawczyk Reviewed-by: Igor Chauskin --- drivers/net/ena/ena_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 20ff3653c6..516e244295 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1246,6 +1246,10 @@ static int ena_queue_start(struct ena_ring *ring) PMD_INIT_LOG(ERR, "Failed to populate rx ring !"); return ENA_COM_FAULT; } + /* Flush per-core RX buffers pools cache as they can be used on other + * cores as well. + */ + rte_mempool_cache_flush(NULL, ring->mb_pool); return 0; } -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:41.012434710 +0000 +++ 0268-net-ena-flush-Rx-buffers-memory-pool-cache.patch 2021-02-05 11:18:29.350701469 +0000 @@ -1 +1 @@ -From 4387e81c94f4702ec2eb2037df2bfa19927309d7 Mon Sep 17 00:00:00 2001 +From 0a6b9a2e34ae99a1df902542b05d4f3263bf0806 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4387e81c94f4702ec2eb2037df2bfa19927309d7 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index c796af4aa7..dde6e9ce8b 100644 +index 20ff3653c6..516e244295 100644