From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A44D0A0524 for ; Fri, 5 Feb 2021 12:39:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 920CE4067B; Fri, 5 Feb 2021 12:39:53 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 4D7314067B for ; Fri, 5 Feb 2021 12:39:52 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id d16so7278303wro.11 for ; Fri, 05 Feb 2021 03:39:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4riJVTHROqTICBsN90itg9RtYbS39qT4FzPoPmuaXqE=; b=UEPC5++IoopdCOeJOtxcXf+GZn8O2I6eqRkcNIiON1zY7MlvbkoXj4xKxXtzq+fVd4 +oBmgF+bDOAn1F02RWbwJ4vhixq78Nm3lFSLhZmYYtCxpEdlFNNzkD0IATr1iCPR68/6 +POUQ47uixWJmPiH5fTaPzQPUf+8TWdHsf8JwzmbGnw6osN91nB80Acqk7T8UdMxmdD/ QPye1DKyVtsF3j/epjN4mavHGcL652uBanfExwYcIX8yuZ74eNWufbgZXzcE9/Rsfquk gZ/5rNtEhlpQTcRrmrlek8QdZ6MN3UwfH9iSw38IUccXttvfA3pyolLbF7fGYDk9kb48 nEiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4riJVTHROqTICBsN90itg9RtYbS39qT4FzPoPmuaXqE=; b=R1/9YAVriShSAnFZJEy4/r9zspWX1zsHkf7XVJ+jMjzsTxohmsTCQU2LkROHkcLuCV jzR68mNaCwh9W+pB9fmv6JPSHKkeVNkoTJP6idTWBatjlwAmo0UgGK1L70fT1u+3baVP lqnLfHJs2wFRbvInTMNpenEqLbG/AsKC2za12t9XRTALRSsfmB3cjjAL0XAJ0xj/x1X8 10RKk5Phxhu9iEllj8Ggr3UDfE3ORuuJJ+JY4FZlQFaCq7ZRgkpB3PmIdTDWiIfK6FXE wUp8jRY8WgkQFAR9yUoJDUW8hIvaA9TfYXs2W3pQ5jwvKHq9lXTSivtHLyo3zD2COvy2 uDzA== X-Gm-Message-State: AOAM531Kn+NeZgiqcMv+KiUoWYBH+R2A6ULMtixYiQaHHcl/Ni/8qZ/u T4Ari/2ZK1oFoxSy53zm0J4= X-Google-Smtp-Source: ABdhPJyYzqTtH97SeF9Q8pdChVgezZImNPbytxjc2z6j9lJi3uXcKKtXaFrb7UpBeeTfVluNuT7Lkg== X-Received: by 2002:a5d:4988:: with SMTP id r8mr4634292wrq.26.1612525192126; Fri, 05 Feb 2021 03:39:52 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id t67sm8969493wmt.15.2021.02.05.03.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:39:51 -0800 (PST) From: luca.boccassi@gmail.com To: Viacheslav Ovsiienko Cc: Ferruh Yigit , dpdk stable Date: Fri, 5 Feb 2021 11:19:20 +0000 Message-Id: <20210205111920.1272063-274-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix queue reconfig request on Rx split update' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/61593e139ef88379decb94fb18a9fd4c4ebaae0a Thanks. Luca Boccassi --- >From 61593e139ef88379decb94fb18a9fd4c4ebaae0a Mon Sep 17 00:00:00 2001 From: Viacheslav Ovsiienko Date: Thu, 21 Jan 2021 12:46:33 +0000 Subject: [PATCH] app/testpmd: fix queue reconfig request on Rx split update [ upstream commit 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 ] There is the "set rxpkts" command in the testpmd interactive mode, it configures the segment sizes to split the packet on receiving. The mentioned segment sizes are provided on the Rx queue setup as part of queue configuration. Hence, to take the rxpkts command into effect the Rx queues must be explicitly reconfigured. The explained above is related to the "set rxoffs" as well. The patch sets the queue reconfiguration request flag for all devices once Rx split settings are updated, to take the changes into effect the port(s) should be restarted. Fixes: 0f2096d7ab36 ("app/testpmd: add rxpkts commands and parameters") Fixes: 91c78e090eed ("app/testpmd: add rxoffs commands and parameters") Signed-off-by: Viacheslav Ovsiienko Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5436cfbd7d..2b9dd3e1f4 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3789,6 +3789,7 @@ cmd_set_rxoffs_parsed(void *parsed_result, MAX_SEGS_BUFFER_SPLIT, seg_offsets, 0); if (nb_segs > 0) set_rx_pkt_offsets(seg_offsets, nb_segs); + cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1); } cmdline_parse_token_string_t cmd_set_rxoffs_keyword = @@ -3835,6 +3836,7 @@ cmd_set_rxpkts_parsed(void *parsed_result, MAX_SEGS_BUFFER_SPLIT, seg_lengths, 0); if (nb_segs > 0) set_rx_pkt_segments(seg_lengths, nb_segs); + cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1); } cmdline_parse_token_string_t cmd_set_rxpkts_keyword = -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:41.259420898 +0000 +++ 0274-app-testpmd-fix-queue-reconfig-request-on-Rx-split-u.patch 2021-02-05 11:18:29.378702002 +0000 @@ -1 +1 @@ -From 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 Mon Sep 17 00:00:00 2001 +From 61593e139ef88379decb94fb18a9fd4c4ebaae0a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 789f35f099..59722d268b 100644 +index 5436cfbd7d..2b9dd3e1f4 100644 @@ -32 +33 @@ -@@ -3791,6 +3791,7 @@ cmd_set_rxoffs_parsed(void *parsed_result, +@@ -3789,6 +3789,7 @@ cmd_set_rxoffs_parsed(void *parsed_result, @@ -40 +41 @@ -@@ -3837,6 +3838,7 @@ cmd_set_rxpkts_parsed(void *parsed_result, +@@ -3835,6 +3836,7 @@ cmd_set_rxpkts_parsed(void *parsed_result,