From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 908ABA0524 for ; Fri, 5 Feb 2021 12:23:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 880684067B; Fri, 5 Feb 2021 12:23:11 +0100 (CET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id CE3971606C6 for ; Fri, 5 Feb 2021 12:23:08 +0100 (CET) Received: by mail-wr1-f45.google.com with SMTP id c4so7235276wru.9 for ; Fri, 05 Feb 2021 03:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6npbePtqGf/9+cLqwZv7AGB939YGIrYBmIH9fzOQHPo=; b=vY2fflgIpkqJbzdkjoVoYVYVj/OiVyklYngKZJTFbILkM90t7ssKaCWvGMYdEiE4KY PMambnWE0hupieg/KwZWBn2UwKgAz6dlGDhBh9+Z6oiNMIBszjlA4kdm4Lysv+lIiuw6 tk9lS1ZFWWgyUJAtSm/ZcQkfvnfeQY8qg9UWWdnR5oN1Y0Xnt2iwwvsmDNg9EwuKA7ZO lJVUGFUeKjgvZHilyD0gEN0XA2+FPaFBA91okz6S3ED7WAsPw9iEtg7ORLQt5DlWvfkO wCIi9dhFEKM+GkmzdQTgsciYDVeo8gU1vFnEaJTfovR0sJ8LxFaXnSfgwUsS1TmrG1qu 9k3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6npbePtqGf/9+cLqwZv7AGB939YGIrYBmIH9fzOQHPo=; b=BjeN8FeSi/ywsaKpxXH7Hy2Pe1PQYcBvPNvL25s9Go4m/3PwGUkd54vCA/OCfRDrkq e/MWjTibQiPNGEUuxi+4bTbBzNVy7pwEoKwQcbCT/hgmwYZcfHWsiO5J+f/gGLCnRe+c pwDTmCOpHwEw6+MF74Zg8Xhk6SrRwXMSziO08AHccvQaMAc8UPPQuih6fF0IlkCsFViz wqdvyNaqd4b5elK5OE8whsppRPMYOpp/oIezcXxZBPsqtl4JtIjhqmSXwjEbNfoJ3ooA NYT9bhFL9yK0vNK9lOFwtPi9thZqTuAT+mvN/+Dvz55ErnpV4X4manu4zX5gY6nUdQzV 5klg== X-Gm-Message-State: AOAM533/5CHRyaVFdx7at6PuuPTgOmF/1yLW52e0XHGyXaJpJXmJpYub nAXInvDW9nJsH+GvdnIR2P0jPUNT7SSke1L7 X-Google-Smtp-Source: ABdhPJyJybF3dsIx5AIg3qqjLqQKYIyObuSIL0B1zy/rtv0UZhJi8b+qnrzl4+GUxenCPWkb6eEHpw== X-Received: by 2002:adf:ff91:: with SMTP id j17mr4322423wrr.377.1612524188649; Fri, 05 Feb 2021 03:23:08 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n19sm7960887wmq.25.2021.02.05.03.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:23:07 -0800 (PST) From: luca.boccassi@gmail.com To: Lance Richardson Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Date: Fri, 5 Feb 2021 11:15:55 +0000 Message-Id: <20210205111920.1272063-69-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: limit Rx representor packets per poll' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fe18437e3489fa06bdecf616fa62e14b00e6d698 Thanks. Luca Boccassi --- >From fe18437e3489fa06bdecf616fa62e14b00e6d698 Mon Sep 17 00:00:00 2001 From: Lance Richardson Date: Mon, 14 Dec 2020 13:53:52 -0500 Subject: [PATCH] net/bnxt: limit Rx representor packets per poll [ upstream commit f0beaf802145e21e1ce60d4ca2724436b70c316e ] Without some limit on the number of packets transferred from the HW ring to the representor ring per burst receive call, an entire ring's worth of packets can be transferred. This can break assumptions about ring indices (index on return could be identical to the index on entry, which is assumed to mean that no packets were processed), and can result in representor packets being dropped unnecessarily due to representor ring overflow. Fix by limiting the number of representor packets transferred per poll to requested burst size. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index af1774844a..cadc598cf2 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -891,7 +891,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } raw_cons = NEXT_RAW_CMP(raw_cons); - if (nb_rx_pkts == nb_pkts || evt) + if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt) break; /* Post some Rx buf early in case of larger burst processing */ if (nb_rx_pkts == BNXT_RX_POST_THRESH) -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:32.362865018 +0000 +++ 0069-net-bnxt-limit-Rx-representor-packets-per-poll.patch 2021-02-05 11:18:28.834691645 +0000 @@ -1 +1 @@ -From f0beaf802145e21e1ce60d4ca2724436b70c316e Mon Sep 17 00:00:00 2001 +From fe18437e3489fa06bdecf616fa62e14b00e6d698 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f0beaf802145e21e1ce60d4ca2724436b70c316e ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 445e6150d1..e2d388e69f 100644 +index af1774844a..cadc598cf2 100644 @@ -31 +32 @@ -@@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, +@@ -891,7 +891,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,