From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA55A0524 for ; Fri, 5 Feb 2021 12:23:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 985101606D2; Fri, 5 Feb 2021 12:23:26 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id F21474067B for ; Fri, 5 Feb 2021 12:23:24 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id j11so5716996wmi.3 for ; Fri, 05 Feb 2021 03:23:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ggL3gH9IX3b/kS3b/JIFbS6ReikzIOqfqwdo1tfcB5Y=; b=anQu9OUGftvYlH9HSU4GC6YcY7hT2PaYQWj6p8AhIuHNgXK4J7sBLPYDgRytTZwtZH 5xMNMGmOwboU7xTJjCfmuIZCst7t5OPlaMTAzMw8N5uppafxxyd0vCgvLwE9ctCxKE3E 1ZEZBlPd21UrWr+OT1Vy3F8XvmqaB0yVssiawz4+ZGmMrjw6UmqgkPdEkbaoLHimfHmr 4NXdVyB1wuBEieU0N5fkH+p616OOa8UZwG8T0l2gTYJSfxa/gcmBaSpE5QnQofMKPrmw 4ZS3OblxeTZqug1BGIMu+9o6EmLZ3U9YWAt/QfC2oWeHwK5iHtk3R2Wrw4G2TnQmcXUY eutw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ggL3gH9IX3b/kS3b/JIFbS6ReikzIOqfqwdo1tfcB5Y=; b=ptS3mZMDXr1vzl1D/mauceszdvNgrBEYCoqXTaIhg2UmuHAuytImDwuN3XrtoOxA29 cEQYRrERhE58Yui8YFzojSgU78Lv2q1rgtH7WH1XiCkClQ1LFRro4TNFGuf85gTjPJop n3TjcCqNWNLVBU5h/YuEqAdTbS8XjDh8U0VcIt5ROi6KIsxAVrPX+IrWSKy9Uwq3H5oH 6oIIsEdTvMbpAwZbjrxg43Dm/C4sG0NHUAScoqLcTeyTgxEU4BA5NgW3v6QOjHOBm52x WrCfSx+z3v3OMEJ9ghkvrMQPFH9Ut5VZVpNHug0WkKFMd1puzYxCDS/e51juT9Im8xtP Gidg== X-Gm-Message-State: AOAM531MFxyZHxib8Q/Wr6BcshCZVLUz2ZKi4QIqfDPN6nprG9g21wX3 pK1dDxJCVq1I3l0QNFCulgqV5AAAS4GeqjRB X-Google-Smtp-Source: ABdhPJx6j5dC0SpHRXJFA/TZGZxewXNWBVvyGrXGAnvxlvIDQ7281rA0yfRMeT5Y2LH6o9cA/RlahA== X-Received: by 2002:a1c:a512:: with SMTP id o18mr3149664wme.138.1612524204788; Fri, 05 Feb 2021 03:23:24 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id l5sm11798934wrv.44.2021.02.05.03.23.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:23:24 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Ori Kam , Ajit Khaparde , dpdk stable Date: Fri, 5 Feb 2021 11:16:00 +0000 Message-Id: <20210205111920.1272063-74-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: release flows left before port stop' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/3e33fc7c8b0f68d34f3053daafd591245e712f25 Thanks. Luca Boccassi --- >From 3e33fc7c8b0f68d34f3053daafd591245e712f25 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Thu, 26 Nov 2020 18:43:02 +0200 Subject: [PATCH] app/testpmd: release flows left before port stop [ upstream commit 0f93edbf7c874480e21e365f527fecdb305984b9 ] According to RTE flow user guide, PMD will not keep flow rules after port stop. Application resources that refer to flow rules become obsolete after port stop and must not be used. Testpmd maintains linked list of active flows for each port. Entries in that list are allocated dynamically and must be explicitly released to prevent memory leak. The patch releases testpmd port flow_list that holds remaining flows before port is stopped. Signed-off-by: Gregory Etelson Acked-by: Ori Kam Acked-by: Ajit Khaparde --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 33a060dffd..2b60f6c5d3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2734,6 +2734,9 @@ stop_port(portid_t pid) } } + if (port->flow_list) + port_flow_flush(pi); + if (rte_eth_dev_stop(pi) != 0) RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n", pi); -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:32.579515480 +0000 +++ 0074-app-testpmd-release-flows-left-before-port-stop.patch 2021-02-05 11:18:28.850691949 +0000 @@ -1 +1 @@ -From 0f93edbf7c874480e21e365f527fecdb305984b9 Mon Sep 17 00:00:00 2001 +From 3e33fc7c8b0f68d34f3053daafd591245e712f25 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0f93edbf7c874480e21e365f527fecdb305984b9 ] + @@ -14,2 +15,0 @@ - -Cc: stable@dpdk.org