From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1294A0524 for ; Fri, 5 Feb 2021 12:23:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B98434067B; Fri, 5 Feb 2021 12:23:27 +0100 (CET) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 27B701606D2 for ; Fri, 5 Feb 2021 12:23:26 +0100 (CET) Received: by mail-wr1-f42.google.com with SMTP id c12so7261028wrc.7 for ; Fri, 05 Feb 2021 03:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j1EaO8dEM20pysYGnjNsG5vPMPi/y25f/Ph8vuuFWZE=; b=G+HjbhOdRvzholvcs3gjgVrrqtxc/DtYpz57+vysMJmWajqf3zif7Ph3LlS8l5lHp+ Rf+P1j6fZm+nuS1RouAPsvurUSa0ld6gw4V/CaS4z7DzJlkb5PaF8Q0m7eJIaKHijFKS 2oj85RDgz3jTdCvPR348j6JwOdmYvyGLl3Jg4w00K865dqkR9bYmuVMCjg6ypIAQjpVa uo6DuMs6gQJMcf1TI+dHJU87QELq+eqIf1cXGyRvvyF5DV0p7nVjBs09oRyNmXungZiC Z/kd+hYJdFUANTGI+hCWdLZjkITRjqZGvfjeQKheya9YDp5QWcRdUnxOSCNY32KQ2Row 6zMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j1EaO8dEM20pysYGnjNsG5vPMPi/y25f/Ph8vuuFWZE=; b=EQerH191CikyO4NqoITxt7wNt+BeA2oOI7O5OcgZisqNjFlERJf2DxB2tJBbk4pjQV 2LNLgK8jYNdLG/eFIcvyEs30CDeea1kvpMkUjtXkON0IIbB/cpU+zUqHOUHclAdsu/2s tTP7PpEX9x4dk9JFMpSQIAD7VD6f+pL+reZKmoTpFwBjdlQvRX1ULRunfSCkf03Ki8zY Sxxlxpbj7JCxsB5XK+3OyP9gLuYfhLgHG68tBSlJp4YlggSgQUQCgGiiaTvUQ+TqDu9b aqYxfK4Ly2Z5+04btG/9hrb5mRI3PelZNtEhG03EYUml7slLZgrU/CMF0JUwX51xlmLS lfPQ== X-Gm-Message-State: AOAM533eUZj+KHMbOLCFImORL1uLI7tDREzg4+fZ7OdmA+WV+m3sREDx gCwRon6xbvlRP3Epdnbgk+RIOONx1yA0Zm9z X-Google-Smtp-Source: ABdhPJzfV3RIi3VmDjWf8Z3TRNQy+KfH0oDOkgG+bk2B2EYsg59xOH5PDO2YsLTx11YvNfNNDS1ZGA== X-Received: by 2002:a5d:4b8e:: with SMTP id b14mr4376043wrt.130.1612524205996; Fri, 05 Feb 2021 03:23:25 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w4sm12415246wrt.69.2021.02.05.03.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 03:23:25 -0800 (PST) From: luca.boccassi@gmail.com To: Gregory Etelson Cc: Viacheslav Ovsiienko , dpdk stable Date: Fri, 5 Feb 2021 11:16:01 +0000 Message-Id: <20210205111920.1272063-75-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210205111920.1272063-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix tunnel rules validation on VF representor' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/07/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/09a68cd6a088cac78547fc7778cbe77d46dc3816 Thanks. Luca Boccassi --- >From 09a68cd6a088cac78547fc7778cbe77d46dc3816 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Fri, 11 Dec 2020 16:46:14 +0200 Subject: [PATCH] net/mlx5: fix tunnel rules validation on VF representor [ upstream commit 187f942b2de0856e62ae10a8b79469f8c4c487fa ] MLX5 PMD implicitly adds vxlan_decap flow action to tunnel offload match type rules. However, VXLAN decap action on VF representors is not supported on MLX5 PMD hardware. The patch rejects attempt to create tunnel offload flow rules on VF representor. Refer commit 9c4971e5231d ("net/mlx5: update VLAN and encap actions validation") Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index f61943f193..7225c8074d 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5282,6 +5282,11 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, } else { tunnel = NULL; } + if (tunnel && priv->representor) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "decap not supported " + "for VF representor"); grp_info.std_tbl_fix = tunnel_use_standard_attr_group_translate (dev, tunnel, attr, items, actions); ret = flow_dv_validate_attributes(dev, tunnel, attr, &grp_info, error); -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-05 11:18:32.618268919 +0000 +++ 0075-net-mlx5-fix-tunnel-rules-validation-on-VF-represent.patch 2021-02-05 11:18:28.858692102 +0000 @@ -1 +1 @@ -From 187f942b2de0856e62ae10a8b79469f8c4c487fa Mon Sep 17 00:00:00 2001 +From 09a68cd6a088cac78547fc7778cbe77d46dc3816 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 187f942b2de0856e62ae10a8b79469f8c4c487fa ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 7c2b389c63..4f638e24ad 100644 +index f61943f193..7225c8074d 100644 @@ -28 +29 @@ -@@ -5280,6 +5280,11 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, +@@ -5282,6 +5282,11 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,