From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE571A0547 for ; Tue, 9 Feb 2021 11:37:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B96E816070C; Tue, 9 Feb 2021 11:37:00 +0100 (CET) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id 5F6B51606DA for ; Tue, 9 Feb 2021 11:36:59 +0100 (CET) Received: by mail-wr1-f52.google.com with SMTP id g6so7984598wrs.11 for ; Tue, 09 Feb 2021 02:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I3hsvVAnJIJDL+flNCapL2AJYL2Ttky0PYvBkHMseTs=; b=twz2b9AHCrkxTPfHXlEIWCD3VqM/Vbj2558klsvskQ+k9+wr+huNg8j7WCCygmWg6s f6IiwG5ROmUoWUzOYS/ci6EHLAna+0eES5Rxt123xHJOHQ0vi/KZDkJh+1A7t+VOl3O4 n1fcCfxI49cQIulGjL2VuhVteA9aRIGiairmsFQYhlvKY5HQsR4xqPyvqBFD75DAIT68 lkNglOjupxhEU1mvW3jcHaswLwSdBmzdj8I6hZqTHQ08Ib4xOJgwTNnsKBnQB9ny3Zk+ bt5hPADfOMy0/M+N3mMGthIfbdQpN3YcaDoKWjy01D1aH31Sf86rMUFfqtDXNjVgHRp2 B6Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I3hsvVAnJIJDL+flNCapL2AJYL2Ttky0PYvBkHMseTs=; b=lhfFgtt2l6CzEaybYis1v3d3e5SC5cyMqdxpYjjX6TlsDxTmXMxWaGP5zAvFLvr7sy bPelhvEBCw9L1yQOc6NG1q/PfM+kyE7MSZpBStWyEkydQyOc1pmTHrmGky9qCoulZzuq yzB0o+ra/NQ3Ruj7NF797llyOpFL8mBEWRR3WE6oyZJ/5I474oIjwdAGYV7IAVZaOUam 0Rju+SQ6sRffoSkO4CmLNJlwWVJwXeaa5A5CJ4zG3BJnJzSgLdsG5z25zHqsrDmbjKx3 5FUDmF2FEngwe1rper7B64aJnMJ0TFo1xr0W45WmZr7lFczF3iCaqM5q3VgZt0Kyr0PZ yOVA== X-Gm-Message-State: AOAM531jNalympTsim7wQVcsnfc0P0YLk0HZZPlYBEaW56TQn0NZfK0J q7vqjYGkFprJ5qjDwDbEO7SkxKyVaTYK1A== X-Google-Smtp-Source: ABdhPJyMJDNXViX2nGG4annhyPUjwvSwDuvOSxAVWDyAt0NcpYktqArWbQXuuCMJvb1qyWEAeddvcg== X-Received: by 2002:adf:80c8:: with SMTP id 66mr25000462wrl.344.1612867019123; Tue, 09 Feb 2021 02:36:59 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id f3sm4036739wme.26.2021.02.09.02.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 02:36:58 -0800 (PST) From: luca.boccassi@gmail.com To: Timothy McDaniel Cc: dpdk stable Date: Tue, 9 Feb 2021 10:35:26 +0000 Message-Id: <20210209103529.466775-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210209103529.466775-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> <20210209103529.466775-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dlb: fix accessing uninitialized variables' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/11/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/29d0b18b5ee25ed93d54f589df40b3bcc6fa916e Thanks. Luca Boccassi --- >From 29d0b18b5ee25ed93d54f589df40b3bcc6fa916e Mon Sep 17 00:00:00 2001 From: Timothy McDaniel Date: Wed, 3 Feb 2021 12:12:21 -0600 Subject: [PATCH] event/dlb: fix accessing uninitialized variables [ upstream commit d9e832951812238c8b7fd4c6a366ba53101704a4 ] This patch updates the PMD to initialize response fields prior to calling into the PF layer. Coverity issue: 366200, 366202, 366205 Fixes: eb14a3421afd ("event/dlb: add eventdev start") Fixes: f0073621940c ("event/dlb: add eventdev stop and close") Signed-off-by: Timothy McDaniel --- drivers/event/dlb/dlb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c index 0c95c4793d..e2d5d43da7 100644 --- a/drivers/event/dlb/dlb.c +++ b/drivers/event/dlb/dlb.c @@ -1847,7 +1847,7 @@ dlb_hw_create_dir_queue(struct dlb_eventdev *dlb, int32_t qm_port_id) { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_create_dir_queue_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int32_t ret; cfg.response = (uintptr_t)&response; @@ -3569,7 +3569,7 @@ dlb_get_ldb_queue_depth(struct dlb_eventdev *dlb, { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_get_ldb_queue_depth_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; cfg.queue_id = queue->qm_queue.id; @@ -3591,7 +3591,7 @@ dlb_get_dir_queue_depth(struct dlb_eventdev *dlb, { struct dlb_hw_dev *handle = &dlb->qm_instance; struct dlb_get_dir_queue_depth_args cfg; - struct dlb_cmd_response response; + struct dlb_cmd_response response = {0}; int ret; cfg.queue_id = queue->qm_queue.id; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-09 10:34:59.036176135 +0000 +++ 0028-event-dlb-fix-accessing-uninitialized-variables.patch 2021-02-09 10:34:57.946584700 +0000 @@ -1 +1 @@ -From d9e832951812238c8b7fd4c6a366ba53101704a4 Mon Sep 17 00:00:00 2001 +From 29d0b18b5ee25ed93d54f589df40b3bcc6fa916e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d9e832951812238c8b7fd4c6a366ba53101704a4 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 64e6df7373..8b26d1d2d2 100644 +index 0c95c4793d..e2d5d43da7 100644 @@ -32 +33 @@ -@@ -3573,7 +3573,7 @@ dlb_get_ldb_queue_depth(struct dlb_eventdev *dlb, +@@ -3569,7 +3569,7 @@ dlb_get_ldb_queue_depth(struct dlb_eventdev *dlb, @@ -41 +42 @@ -@@ -3595,7 +3595,7 @@ dlb_get_dir_queue_depth(struct dlb_eventdev *dlb, +@@ -3591,7 +3591,7 @@ dlb_get_dir_queue_depth(struct dlb_eventdev *dlb,