From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CD3BA0547 for ; Tue, 9 Feb 2021 11:35:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56CB0160712; Tue, 9 Feb 2021 11:35:39 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 77FC4160712 for ; Tue, 9 Feb 2021 11:35:38 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id m1so2967320wml.2 for ; Tue, 09 Feb 2021 02:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Gaf+N5KRTgYpNcR1tlhVJITNFtyyjo1p3w/ClR395oY=; b=ur8FLoyxVBYCxN7LSIi/Ewrp6bO5GUaZHQM0ovIKrVzy54yZ/lIkqA1rt7mDt4u40I SxDZHliF3Q1gVY4io4vsEVYtoLj6qxAo5LBRycqmZskdDDz6D/bvNmZoCeIUR/iKKB8T Gwb9rOvzqyUq2j7pULBkvG/LzYOjzuTrb9WRFNfy0nSnFcyq7Fjj5wtDA791bBY+sYHe lIUs19uQ5I1sUdU65AJJFfirlPI9isvChL/WwvbQTJC2v3TsaL5gDoJKVUDbj20ikQ9F 89+7G6EbuB3jiLTM7QkQmyyWcdPT3RCSsDcMal2wOnNjON3U12euh9RS410eJjZOXtGA 1uVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gaf+N5KRTgYpNcR1tlhVJITNFtyyjo1p3w/ClR395oY=; b=ZwWAOhPe0mJqb9msF9vS9NLzoPSetayKJt0GvfoZcYBcqrLYpcT0dbns7b3e80aefI SOH+7jlRnq/Yq8tkTUh735n4vEFu2IFFcDv9jdW5M+d5aYimEd/LRgcHEgpuYMczxVu3 /EeEhoOcIIblIUl/fmQRLTz+fwfQgdy4s8H9+CcubaIAzfnPBe/ev/lg+FeC5lu48KUv KvgVLELOj/Q0wdh3WO0FWcLaei/fT66MO8c93ZFYX6M9fpWH8CZJLwXryMo16b51t4+b bfxpD/wt4fHlmY4bTVEkj31QGFxXv1/Ro1JbB2H0eqCkbzXDXzwvBYYcvV2IiFR+66Op 6vJA== X-Gm-Message-State: AOAM533+D+MWz5AsJ+/py3NAACEiqeAFIL+9oDXxZlBr9UvA/PnBDLmJ AbE7S6HESHVmlnpBjeu2gN7QfK0w1vbkAQ== X-Google-Smtp-Source: ABdhPJwMM1Q96swFnUjNTAWSKhX04ASO+ywrp93bbzsLxq1jNa0o8ywftEvJyD5rIYAR7CsRb77SwA== X-Received: by 2002:a7b:c04c:: with SMTP id u12mr2830653wmc.185.1612866938268; Tue, 09 Feb 2021 02:35:38 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id t197sm6406093wmt.3.2021.02.09.02.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 02:35:36 -0800 (PST) From: luca.boccassi@gmail.com To: Hyong Youb Kim Cc: John Daley , dpdk stable Date: Tue, 9 Feb 2021 10:35:02 +0000 Message-Id: <20210209103529.466775-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210209103529.466775-1-luca.boccassi@gmail.com> References: <20210205111920.1272063-1-luca.boccassi@gmail.com> <20210209103529.466775-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/enic: fix filter type used for flow API' has been queued to stable release 20.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 20.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/11/21. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/6c8be34e6acee1caf4658ad6e5123f3d2a385b00 Thanks. Luca Boccassi --- >From 6c8be34e6acee1caf4658ad6e5123f3d2a385b00 Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Mon, 1 Feb 2021 16:24:23 -0800 Subject: [PATCH] net/enic: fix filter type used for flow API [ upstream commit d700f0d0d7074c76a94c0278315acb86f9ea30ba ] The filter type (struct filter_v2.type) should always be set to FILTER_DPDK_1, when advanced filtering is enabled in firmware. Otherwise, for some old firmware versions, the driver sets it to FILTER_USNIC_IP, and attempts to install filters fail. This behavior matches that of the now-removed flow director implementation (enic_clsf.c). Fixes: 26faa126d87e ("net/enic: flow API for NICs with advanced filters disabled") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c index cebca7d55a..453c11a3b3 100644 --- a/drivers/net/enic/enic_flow.c +++ b/drivers/net/enic/enic_flow.c @@ -1595,6 +1595,8 @@ enic_flow_parse(struct rte_eth_dev *dev, return -rte_errno; } enic_filter->type = enic->flow_filter_mode; + if (enic->adv_filters) + enic_filter->type = FILTER_DPDK_1; ret = enic_copy_filter(pattern, enic_filter_cap, enic, enic_filter, error); return ret; -- 2.29.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2021-02-09 10:34:58.101345440 +0000 +++ 0004-net-enic-fix-filter-type-used-for-flow-API.patch 2021-02-09 10:34:57.854582918 +0000 @@ -1 +1 @@ -From d700f0d0d7074c76a94c0278315acb86f9ea30ba Mon Sep 17 00:00:00 2001 +From 6c8be34e6acee1caf4658ad6e5123f3d2a385b00 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d700f0d0d7074c76a94c0278315acb86f9ea30ba ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 97ee7509ce..7eb06f889e 100644 +index cebca7d55a..453c11a3b3 100644 @@ -26 +27 @@ -@@ -1598,6 +1598,8 @@ enic_flow_parse(struct rte_eth_dev *dev, +@@ -1595,6 +1595,8 @@ enic_flow_parse(struct rte_eth_dev *dev,