From: luca.boccassi@gmail.com
To: stable@dpdk.org
Cc: stephen@networkplumber.org, Li Feng <fengli@smartx.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [dpdk-stable] [PATCH 19.11 1/2] mem: exclude unused memory from core dump
Date: Mon, 22 Feb 2021 11:58:39 +0000 [thread overview]
Message-ID: <20210222115840.137249-1-luca.boccassi@gmail.com> (raw)
From: Li Feng <fengli@smartx.com>
[ backported from upstream commit d72e4042c5ebda7af81448b387af8218136402d0 ]
Currently, even though memory is mapped with PROT_NONE, this does not
cause it to be excluded from core dumps. This is counter-productive,
because in a lot of cases, this memory will go unused (e.g. when the
memory subsystem preallocates VA space but hasn't yet mapped physical
pages into it).
Use `madvise()` call with MADV_DONTDUMP/MADV_NOCORE to exclude the
unused memory from being dumped.
Signed-off-by: Li Feng <fengli@smartx.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
As requested by Stephen. This stops coredumps from DPDK applications
from massively inflating in size with unused memory chunks.
lib/librte_eal/common/eal_common_memory.c | 15 +++++++++++++++
lib/librte_eal/linux/eal/eal_memalloc.c | 3 +++
2 files changed, 18 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index cc7d54e0c7..9a797a4fa3 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -40,6 +40,14 @@
static void *next_baseaddr;
static uint64_t system_page_sz;
+#ifdef RTE_EXEC_ENV_LINUX
+#define RTE_DONTDUMP MADV_DONTDUMP
+#elif RTE_EXEC_ENV_FREEBSD
+#define RTE_DONTDUMP MADV_NOCORE
+#else
+#error "madvise doesn't support this OS"
+#endif
+
#define MAX_MMAP_WITH_DEFINED_ADDR_TRIES 5
void *
eal_get_virtual_area(void *requested_addr, size_t *size,
@@ -179,6 +187,13 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
munmap(aligned_end, after_len);
}
+ if (!unmap) {
+ /* Exclude these pages from a core dump. */
+ if (madvise(aligned_addr, *size, RTE_DONTDUMP) != 0)
+ RTE_LOG(DEBUG, EAL, "madvise failed: %s\n",
+ strerror(errno));
+ }
+
return aligned_addr;
}
diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c
index 51d239de37..22f1ff68eb 100644
--- a/lib/librte_eal/linux/eal/eal_memalloc.c
+++ b/lib/librte_eal/linux/eal/eal_memalloc.c
@@ -710,6 +710,9 @@ free_seg(struct rte_memseg *ms, struct hugepage_info *hi,
return -1;
}
+ if (madvise(ms->addr, ms->len, MADV_DONTDUMP) != 0)
+ RTE_LOG(DEBUG, EAL, "madvise failed: %s\n", strerror(errno));
+
exit_early = false;
/* if we're using anonymous hugepages, nothing to be done */
--
2.29.2
next reply other threads:[~2021-02-22 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 11:58 luca.boccassi [this message]
2021-02-22 11:58 ` [dpdk-stable] [PATCH 19.11 2/2] mem: fix build luca.boccassi
2021-02-22 14:55 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222115840.137249-1-luca.boccassi@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=fengli@smartx.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).