From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B3DEA0547 for ; Fri, 26 Feb 2021 10:08:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEDC322A252; Fri, 26 Feb 2021 10:08:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 31DB240692; Fri, 26 Feb 2021 10:08:12 +0100 (CET) IronPort-SDR: hxlgXaclpyc2rgItg2MoED0KWtzYRoY2tVy1vlZbG7d/kDbMKeAekF8d9PCE4GyuxypQTGxfhe h3h8pDn2WRkg== X-IronPort-AV: E=McAfee;i="6000,8403,9906"; a="165686718" X-IronPort-AV: E=Sophos;i="5.81,208,1610438400"; d="scan'208";a="165686718" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2021 01:08:11 -0800 IronPort-SDR: EGLgONxha0iZw4easfYxZhVQth/7OFsG56tXSzAjHiOHSDBqHrEvWG/ekwhIcDblgMy8Hm8wiw oSce7cE722LA== X-IronPort-AV: E=Sophos;i="5.81,208,1610438400"; d="scan'208";a="404821881" Received: from dsgurupr-mobl1.gar.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.16.207]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Feb 2021 01:08:07 -0800 Date: Fri, 26 Feb 2021 09:08:03 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, ncopa@alpinelinux.org, stable@dpdk.org, Hemant Agrawal , Sachin Saxena , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Cristian Dumitrescu , John McNamara , Maxime Coquelin , Chenbo Xia , Anatoly Burakov , Konstantin Ananyev , Marcin Smoczynski Message-ID: <20210226090803.GA1308@bricha3-MOBL.ger.corp.intel.com> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20210225182250.1149592-1-thomas@monjalon.net> <20210225182250.1149592-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225182250.1149592-5-thomas@monjalon.net> Subject: Re: [dpdk-stable] [PATCH v5 04/17] build: define _GNU_SOURCE globally X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Feb 25, 2021 at 07:22:37PM +0100, Thomas Monjalon wrote: > There was an intent to define _GNU_SOURCE globally, > but it was not set in pkg-config for external applications. > Is this something that we really want to do, to force all external apps to use _GNU_SOURCE when compiling? Do some of our header files rely on definitions only available with _GNU_SOURCE? If so, we should probably look to remove that dependency rather than mandating the define.