From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 99B29A0548
for <public@inbox.dpdk.org>; Sun, 28 Feb 2021 13:54:11 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9E85B22A286;
Sun, 28 Feb 2021 13:54:09 +0100 (CET)
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
[66.111.4.224])
by mails.dpdk.org (Postfix) with ESMTP id 2B65C22A268;
Sun, 28 Feb 2021 13:54:06 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailnew.nyi.internal (Postfix) with ESMTP id C652A5800D9;
Sun, 28 Feb 2021 07:54:05 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Sun, 28 Feb 2021 07:54:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=fm3; bh=kXjTeIfaRFwMF
283cB7YA65ARcTmowfSjYiQL8TpI4c=; b=r+iu5VeKFc6zYkOW2ku+adPVcHvKi
laiNPcLDGSOjKm4fiGEzhSiVU4wbHGsgZtm4dDr3r1tcRVXL7BS9C8Siz6+uTc+i
35yIqq+4LI9pFGA9dXbt+TquG0ydqVn17uu/Xq7zmmbfaGc91X3iGVDI6ZZqjKGQ
oa86OXUxmW7+TNz0mIxxT2z/l1G7ywN4BJZf8hz2PlBCgWnH7UefmNlzWqqDwyCU
pBKqiYAfvNHZ7sXwAAM6dhLwReWq0vt+AOGZ+c+4829al7Agvr/Qcc4HbDbF1OSo
Voo6t9yFoOzTTXS/oVfuL5fClasIBT84D/xBBOV9koToWoFWVPNsd5ZeQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm2; bh=kXjTeIfaRFwMF283cB7YA65ARcTmowfSjYiQL8TpI4c=; b=oSvRaNPz
Ll2G5uLga1LT8eixkzMVe9bbBQLuvVWP6w14Uv4DxqXqflHKRFRGG7fUKH0/aWHK
luAtfjxKJoEw0hnTYD0RirKL6fWWK/0wJFTqkdsVlWe5qF9kO0aouA8nbnkykM+L
Te/fzpEyXt4QcUk7DAa2ncbHKR2Hvcfz80TRALDbbGsBQs5yektrGqyJ6e6QjPyn
pC/Ddd+6i9KENfaBuzpuxs9gS5Jg6FFis0G+vYOaX6/t+er+u3+pA3sxvW/5mcWJ
pKPI6zUAYPWuX8BdVNLmvzcBkHGi5gWAeIs6TtRPvvUrv9A5M475x1K+UevSP7H3
6+S7Ed7rrfGlvg==
X-ME-Sender: <xms:bZI7YERIuKJNulbqQS167RZkxcfA73LvPCUU3P1TP0hgxJcKM7rgog>
<xme:bZI7YBz5CbizA7Hq2t-vpdwcNrOYKivj3mTxW7wMyZSO4e66YNxAX-aCRnPiL8H_W
qq_-tkzZuWvIpFhGg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrleeigdegjecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu
tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:bZI7YB2RPjfsIvmZ5RenWCYu6dpuQzornILyJXG9-NbEC7oXKkJl7g>
<xmx:bZI7YIBDo-33mvvBPo_cWsdanVrI973IX0dZyb9xOO1BKQkX9lZHGg>
<xmx:bZI7YNiBbFPPWsmDmVspsppwazyYPovymfcNxuVy9-IF9-8meXhQeA>
<xmx:bZI7YIruZ-Zdx73hsDnXAXByTqufTA7euiidZ1T_vEX-U3WVMcvqIQ>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 30EF11080057;
Sun, 28 Feb 2021 07:54:04 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: ncopa@alpinelinux.org, stable@dpdk.org,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Marcin Smoczynski <marcinx.smoczynski@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Xueming Li <xuemingl@mellanox.com>, Xiaoyu Min <jackmin@mellanox.com>
Date: Sun, 28 Feb 2021 13:53:39 +0100
Message-Id: <20210228125353.2436562-5-thomas@monjalon.net>
X-Mailer: git-send-email 2.30.1
In-Reply-To: <20210228125353.2436562-1-thomas@monjalon.net>
References: <20190313170657.16688-1-ncopa@alpinelinux.org>
<20210228125353.2436562-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] [PATCH v6 04/17] build: remove redundant _GNU_SOURCE
definitions
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
The feature macro _GNU_SOURCE is defined globally,
but there was some remaining useless settings.
The internal definition in config/meson.build is kept,
all other internal definitions of _GNU_SOURCE are removed,
except in examples, which can be built as external applications.
Note: external applications do not inherit of _GNU_SOURCE.
Fixes: 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default")
Fixes: 28188cee2aa0 ("build: enable BSD features visibility for FreeBSD")
Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/test/meson.build | 2 --
drivers/bus/fslmc/qbman/include/compat.h | 3 ---
drivers/common/dpaax/compat.h | 4 ----
drivers/common/dpaax/meson.build | 1 -
drivers/net/memif/rte_eth_memif.h | 4 ----
drivers/net/mlx5/linux/mlx5_socket.c | 4 ----
6 files changed, 18 deletions(-)
diff --git a/app/test/meson.build b/app/test/meson.build
index 099895fc87..76eaaea457 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -398,8 +398,6 @@ if cc.has_argument('-Wno-format-truncation')
cflags += '-Wno-format-truncation'
endif
-# specify -D_GNU_SOURCE unconditionally
-cflags += '-D_GNU_SOURCE'
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
cflags += '-fno-strict-aliasing'
diff --git a/drivers/bus/fslmc/qbman/include/compat.h b/drivers/bus/fslmc/qbman/include/compat.h
index 1ddd69e127..a4471a80af 100644
--- a/drivers/bus/fslmc/qbman/include/compat.h
+++ b/drivers/bus/fslmc/qbman/include/compat.h
@@ -8,9 +8,6 @@
#ifndef HEADER_COMPAT_H
#define HEADER_COMPAT_H
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
diff --git a/drivers/common/dpaax/compat.h b/drivers/common/dpaax/compat.h
index 1a5f36e99e..c69e76ab96 100644
--- a/drivers/common/dpaax/compat.h
+++ b/drivers/common/dpaax/compat.h
@@ -10,10 +10,6 @@
#define __COMPAT_H
#include <sched.h>
-
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
#include <stdint.h>
#include <stdlib.h>
#include <stddef.h>
diff --git a/drivers/common/dpaax/meson.build b/drivers/common/dpaax/meson.build
index 4535482701..b7f177a62e 100644
--- a/drivers/common/dpaax/meson.build
+++ b/drivers/common/dpaax/meson.build
@@ -10,7 +10,6 @@ sources = files('dpaax_iova_table.c', 'dpaa_of.c', 'caamflib.c')
includes += include_directories('caamflib')
-cflags += ['-D_GNU_SOURCE']
if cc.has_argument('-Wno-cast-qual')
cflags += '-Wno-cast-qual'
endif
diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h
index 24321d3a39..2038bda742 100644
--- a/drivers/net/memif/rte_eth_memif.h
+++ b/drivers/net/memif/rte_eth_memif.h
@@ -5,10 +5,6 @@
#ifndef _RTE_ETH_MEMIF_H_
#define _RTE_ETH_MEMIF_H_
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif /* GNU_SOURCE */
-
#include <sys/queue.h>
#include <ethdev_driver.h>
diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c
index 1938453980..b1f41bc102 100644
--- a/drivers/net/mlx5/linux/mlx5_socket.c
+++ b/drivers/net/mlx5/linux/mlx5_socket.c
@@ -2,10 +2,6 @@
* Copyright 2019 Mellanox Technologies, Ltd
*/
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>
--
2.30.1