patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ciara Power <ciara.power@intel.com>
To: stable@dpdk.org
Cc: christian.ehrhardt@canonical.com,
	Ciara Power <ciara.power@intel.com>,
	bruce.richardson@intel.com,
	Declan Doherty <declan.doherty@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: [dpdk-stable] [PATCH 19.11.7] build: fix scheduler macro definition for meson
Date: Wed, 10 Mar 2021 10:53:42 +0000	[thread overview]
Message-ID: <20210310105342.3214855-1-ciara.power@intel.com> (raw)

The make and meson macro formats differ slightly,
the make format is checked when registering the scheduler_autotest
command, and when including dependency on the scheduler pmd for the test,
l2fwd-crypto and test-crypto-perf apps. When building with meson,
these things were not done, and the scheduler autotest was unavailable.

To fix this, the scheduler macro in make format is also defined when
using meson, and the meson build files for the apps use the meson format
when adding the scheduler dependency.

A generalised fix patch [1] for this issue didn't make it into 19.11.6,
but given that does not apply cleanly and introduces other unwanted
changes, this patch is an alternative fix for the scheduler test issue
only.

Fixes: 4dfc61fe367c ("app: fix missing dependencies")
Fixes: dcadbbde8e61 ("crypto/null: build with meson")
Fixes: 52e2991eab28 ("examples/l2fwd-crypto: fix missing dependency")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ciara Power <ciara.power@intel.com>

---
[1]
inbox.dpdk.org/dev/20201015150554.950838-4-bruce.richardson@intel.com/
---
 app/test-crypto-perf/meson.build  | 2 +-
 app/test/meson.build              | 2 +-
 config/rte_config.h               | 4 ++++
 examples/l2fwd-crypto/meson.build | 2 +-
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index c416091fdd..dcc4bf9cbc 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -13,6 +13,6 @@ sources = files('cperf_ops.c',
 		'cperf_test_verify.c',
 		'main.c')
 deps += ['cryptodev', 'security']
-if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+if dpdk_conf.has('RTE_LIBRTE_CRYPTO_SCHEDULER_PMD')
 	deps += 'pmd_crypto_scheduler'
 endif
diff --git a/app/test/meson.build b/app/test/meson.build
index df94b4d48f..24fb59f74f 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -378,7 +378,7 @@ if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV')
 	endif
 endif
 
-if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+if dpdk_conf.has('RTE_LIBRTE_CRYPTO_SCHEDULER_PMD')
 	driver_test_names += 'cryptodev_scheduler_autotest'
 	test_deps += 'pmd_crypto_scheduler'
 endif
diff --git a/config/rte_config.h b/config/rte_config.h
index 0f9dae3ba2..8ec0a58f19 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -94,6 +94,10 @@
 #define RTE_SCHED_PORT_N_GRINDERS 8
 #undef RTE_SCHED_VECTOR
 
+#ifdef RTE_LIBRTE_CRYPTO_SCHEDULER_PMD
+#define RTE_LIBRTE_PMD_CRYPTO_SCHEDULER 1
+#endif
+
 /* KNI defines */
 #define RTE_KNI_PREEMPT_DEFAULT 1
 
diff --git a/examples/l2fwd-crypto/meson.build b/examples/l2fwd-crypto/meson.build
index 39e1604fac..c08d8469b4 100644
--- a/examples/l2fwd-crypto/meson.build
+++ b/examples/l2fwd-crypto/meson.build
@@ -7,7 +7,7 @@
 # DPDK instance, use 'make'
 
 deps += 'cryptodev'
-if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+if dpdk_conf.has('RTE_LIBRTE_CRYPTO_SCHEDULER_PMD')
 	deps += 'pmd_crypto_scheduler'
 endif
 allow_experimental_apis = true
-- 
2.25.1


             reply	other threads:[~2021-03-10 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 10:53 Ciara Power [this message]
2021-03-10 11:03 ` Richardson, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310105342.3214855-1-ciara.power@intel.com \
    --to=ciara.power@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=declan.doherty@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).