From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5112A0575 for ; Wed, 10 Mar 2021 22:26:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC1F622A56E; Wed, 10 Mar 2021 22:26:54 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 3A3B722A539 for ; Wed, 10 Mar 2021 22:26:51 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id 30so4578303ple.4 for ; Wed, 10 Mar 2021 13:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=lVxlWKkd852yZ6dZxC1ao0jUnccLM1dcmzDq0GSrT6o=; b=dTqqzynctAubZJ2FO04PRRw0lfRAcNR52H0DZtAMrXW8I7WzFi2ahqtHlRL+rpVS3C rwBD36UT9Z6/1RlXelbOI6cuxsAxAM6m3XxJbcukmjg1Enro3SgH7t+/QatYDf2fHFm/ 7YYQnDtSDP3TOTp8E5AoR8ZCK1bqStqrfLqf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=lVxlWKkd852yZ6dZxC1ao0jUnccLM1dcmzDq0GSrT6o=; b=n49UzvGcp1RrYeLR4/yh8KRshgIsTXqioIPN7TT3lvRUKz4nkGh24lwz8H/QbebqOE 28m9Xq7uJGov++P/XAJzrtXUHCaLpPnPrDXs+yKqYb/+aJZUKaiPr7OKeJq+m9y11qNe DlVZC0e0abLz1kPjwdMGqPzlBdlrRkSPXzUR1Aya9wjgri6FfiiWSeAmK0UicKxQg5TT pKpexBJGzW3w9FMU56pT9x9rRCC2NtPPWyMyCw2wzPF6uRtD5dSd/hfNe2qHCg/8mBH/ n6w3bmuh7TgNb31iFEa/1jtWOBWi34J0x6D6R6+Jvb0eH9i6hHXEGlDeG5WLJFbsQ05G cYPg== X-Gm-Message-State: AOAM532ycZnUrHtIs+AzJM5s3Yp1XHIkBlmlCmj3bMUfxnee5v7gsWPB WZzY4CI+HJnI29WVpt3iEgCUkg== X-Google-Smtp-Source: ABdhPJxUbTFHE3N9ft/ZpIu2m4d/1ppuAStH0J4xYynprQ9mUU+OyH1TocSt0kjpp8Gw3BRb0dX4WA== X-Received: by 2002:a17:902:d2c5:b029:e5:c9ce:cb3c with SMTP id n5-20020a170902d2c5b02900e5c9cecb3cmr4728721plc.74.1615411610389; Wed, 10 Mar 2021 13:26:50 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f2sm265059pju.46.2021.03.10.13.26.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 13:26:49 -0800 (PST) From: Ajit Khaparde To: ferruh.yigit@intel.com Cc: ajit.khaparde@broadcom.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, stable@dpdk.org Date: Wed, 10 Mar 2021 13:26:28 -0800 Message-Id: <20210310212637.72205-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210310212637.72205-1-ajit.khaparde@broadcom.com> References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003921b305bd3553a2" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH v2 03/12] net/bnxt: fix VNIC configuration X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000003921b305bd3553a2 Content-Transfer-Encoding: 8bit From: Kalesh AP PMD should not set any flags to receive RoCE traffic while configuring the vnic. Since the PMD does not support RoCE some of the flags and code is unused. Clean it up. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 10 ---------- drivers/net/bnxt/bnxt_vnic.h | 2 -- 2 files changed, 12 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index cb8baa8776..5366fe72ca 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2013,12 +2013,6 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic) if (vnic->bd_stall) req.flags |= rte_cpu_to_le_32(HWRM_VNIC_CFG_INPUT_FLAGS_BD_STALL_MODE); - if (vnic->roce_dual) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE); - if (vnic->roce_only) - req.flags |= rte_cpu_to_le_32( - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE); if (vnic->rss_dflt_cr) req.flags |= rte_cpu_to_le_32( HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE); @@ -2066,10 +2060,6 @@ int bnxt_hwrm_vnic_qcfg(struct bnxt *bp, struct bnxt_vnic_info *vnic, HWRM_VNIC_QCFG_OUTPUT_FLAGS_VLAN_STRIP_MODE; vnic->bd_stall = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_BD_STALL_MODE; - vnic->roce_dual = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_DUAL_VNIC_MODE; - vnic->roce_only = rte_le_to_cpu_32(resp->flags) & - HWRM_VNIC_QCFG_OUTPUT_FLAGS_ROCE_ONLY_VNIC_MODE; vnic->rss_dflt_cr = rte_le_to_cpu_32(resp->flags) & HWRM_VNIC_QCFG_OUTPUT_FLAGS_RSS_DFLT_CR_MODE; diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h index 917b909284..00a664c8b8 100644 --- a/drivers/net/bnxt/bnxt_vnic.h +++ b/drivers/net/bnxt/bnxt_vnic.h @@ -52,8 +52,6 @@ struct bnxt_vnic_info { bool vlan_strip; bool func_default; bool bd_stall; - bool roce_dual; - bool roce_only; bool rss_dflt_cr; STAILQ_HEAD(, bnxt_filter_info) filter; -- 2.21.1 (Apple Git-122.3) --0000000000003921b305bd3553a2--