From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EBF4A056A for ; Wed, 10 Mar 2021 22:26:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B0AD22A584; Wed, 10 Mar 2021 22:26:57 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 671C322A56E for ; Wed, 10 Mar 2021 22:26:54 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id z5so9148663plg.3 for ; Wed, 10 Mar 2021 13:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=gaqn1ykDdnevvG9x6Mdph1zZNz7Zm45jLrIdMUBF8XU=; b=hYi7RPRaMFJ3Du9CCOLT3MX75w6C4Lot6X4UWlc8SjgYI9EqnqoL8hUZu5AMEjmx2l ubRh2iYs3NqWdj/7cFcCuYXrP3OzlA6YZZzLIWMGyndXV2rthk2ICg2d6sf7otPBS3wt qK2cRn5QE4Ug87wG6hBYEaq4KtJl29824GdUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=gaqn1ykDdnevvG9x6Mdph1zZNz7Zm45jLrIdMUBF8XU=; b=arOg3wjYweHRzWXcMB8emNkiszPElBFzeUjGGu05jt5IWjXurJrmtfZA+5g1tJFBQk qbmZUvHF0ehIRxjkgltRzeUKbnPvppj7B1uFJk88z58Zkrhicb42Fkk/9ds3uAyOaVP8 NRUT2yLI5G8CWCGIGTpsi6jqIidkrvT5+8/AzVbKrwzl1GKyCXwpNo11N1quq+j1RjaI mKyv+a6+S8f9c8Y9v9cfx+6oy0r29CXIIMATN5316UHKzxUnw+jO8RNvLmfMI1IG0P9O b/SnVA3RpIhJXcuCGHWVuuGwKZ/EUY59j86XiGZS69PSlzRxvKX4ix8G/pthvO5ucNf0 os/g== X-Gm-Message-State: AOAM5331n7EoRV31q1JcJJOc90ZaN6rUiXl/secvQEnSi3oYWCUE8oFY WPFEPbtoZIKeCgYtVFqko0nT/A== X-Google-Smtp-Source: ABdhPJw1ylA/2It6Cx4kH1dXBeF2Orx8Qsr+fqu1p+Z9tIv/yaAVsb4nk5HP7UEP7tROLn9FxInczA== X-Received: by 2002:a17:90a:bd90:: with SMTP id z16mr5633871pjr.123.1615411613557; Wed, 10 Mar 2021 13:26:53 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id f2sm265059pju.46.2021.03.10.13.26.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Mar 2021 13:26:52 -0800 (PST) From: Ajit Khaparde To: ferruh.yigit@intel.com Cc: ajit.khaparde@broadcom.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, Venkat Duvvuru , stable@dpdk.org, Somnath Kotur Date: Wed, 10 Mar 2021 13:26:30 -0800 Message-Id: <20210310212637.72205-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210310212637.72205-1-ajit.khaparde@broadcom.com> References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000006993b205bd3553f4" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-stable] [PATCH v2 05/12] net/bnxt: fix queues per VNIC X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --0000000000006993b205bd3553f4 Content-Transfer-Encoding: 8bit From: Venkat Duvvuru Update queues per VNIC in single queue mode. bp->rx_num_qs_per_vnic is not initialized in the single queue mode. As a result of this when an interface is reconfigured to single queue mode from an existing multiqueue mode, bp->rx_num_qs_per_vnic is not updated to the value of 1. Hence, the driver will try to access more than one queue resulting in a crash. This patch fixes it by initializing bp->rx_num_qs_per_vnic in the single queue mode as well. Fixes: 36024b2e7fe5 ("net/bnxt: allow dynamic creation of VNIC") Cc: stable@dpdk.org Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index f46b10c1c5..53a9b52a46 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -106,7 +106,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) pools = RTE_MIN(pools, bp->rx_cp_nr_rings); nb_q_per_grp = bp->rx_cp_nr_rings / pools; - bp->rx_num_qs_per_vnic = nb_q_per_grp; PMD_DRV_LOG(DEBUG, "pools = %u nb_q_per_grp = %u\n", pools, nb_q_per_grp); start_grp_id = 0; @@ -165,6 +164,8 @@ int bnxt_mq_rx_configure(struct bnxt *bp) } out: + bp->rx_num_qs_per_vnic = nb_q_per_grp; + if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { struct rte_eth_rss_conf *rss = &dev_conf->rx_adv_conf.rss_conf; -- 2.21.1 (Apple Git-122.3) --0000000000006993b205bd3553f4--